[labs/task] Infer the return type of Task.render() #4008

justinfagnani · 2023-07-10T20:14:38Z

Supersedes #2821

changeset-bot · 2023-07-10T20:14:42Z

🦋 Changeset detected

Latest commit: 348ac83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/task	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-07-10T20:15:05Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -13% - +4% (-2.89ms - +0.84ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 66.75ms - 71.43ms
lit-html-kitchen-sink: unsure 🔍 -11% - +6% (-3.24ms - +1.73ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +3% (-0.22ms - +0.34ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +2% (-1.34ms - +0.77ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-0.48ms - +0.86ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 680.46ms - 696.07ms
lit-html-kitchen-sink: unsure 🔍 -4% - +6% (-3.21ms - +4.41ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +7% (-1.93ms - +17.37ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +1% (-1.69ms - +0.86ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-3.49ms - +6.34ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 649.19ms - 656.52ms
reactive-element-list: unsure 🔍 -0% - +1% (-1.46ms - +6.54ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 114.0.5735.198
Sample size: 50
Built by: Benchmarks #5024
Commit: 4df657e

render

Version	Avg time	vs
	66.75ms - 71.43ms	-

update

Version	Avg time	vs
	680.46ms - 696.07ms	-

update-reflect

Version	Avg time	vs
	649.19ms - 656.52ms	-

lit-html-kitchen-sink

Browser: chrome-headless 114.0.5735.198
Sample size: 30
Built by: Benchmarks #5024
Commit: 4df657e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	27.60ms - 30.92ms	-	unsure 🔍 -11% - +6% -3.24ms - +1.73ms	unsure 🔍 -8% - +8% -2.35ms - +2.33ms
tip-of-tree tip-of-tree	28.16ms - 31.87ms	unsure 🔍 -6% - +11% -1.73ms - +3.24ms	-	unsure 🔍 -6% - +11% -1.73ms - +3.23ms
previous-release previous-release	27.62ms - 30.92ms	unsure 🔍 -8% - +8% -2.33ms - +2.35ms	unsure 🔍 -11% - +6% -3.23ms - +1.73ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	73.24ms - 79.16ms	-	unsure 🔍 -4% - +6% -3.21ms - +4.41ms	unsure 🔍 -5% - +6% -3.69ms - +4.37ms
tip-of-tree tip-of-tree	73.20ms - 78.00ms	unsure 🔍 -6% - +4% -4.41ms - +3.21ms	-	unsure 🔍 -5% - +4% -3.90ms - +3.38ms
previous-release previous-release	73.12ms - 78.60ms	unsure 🔍 -6% - +5% -4.37ms - +3.69ms	unsure 🔍 -4% - +5% -3.38ms - +3.90ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	20.22ms - 22.78ms	-	unsure 🔍 -13% - +4% -2.89ms - +0.84ms	unsure 🔍 -13% - +6% -2.93ms - +1.47ms
tip-of-tree tip-of-tree	21.17ms - 23.89ms	unsure 🔍 -4% - +14% -0.84ms - +2.89ms	-	unsure 🔍 -9% - +12% -1.95ms - +2.55ms
previous-release previous-release	20.44ms - 24.02ms	unsure 🔍 -7% - +14% -1.47ms - +2.93ms	unsure 🔍 -11% - +9% -2.55ms - +1.95ms	-

lit-html-repeat

Browser: chrome-headless 114.0.5735.198
Sample size: 30
Built by: Benchmarks #5024
Commit: 4df657e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	9.91ms - 10.32ms	-	unsure 🔍 -2% - +3% -0.22ms - +0.34ms	unsure 🔍 -1% - +5% -0.13ms - +0.45ms
tip-of-tree tip-of-tree	9.86ms - 10.25ms	unsure 🔍 -3% - +2% -0.34ms - +0.22ms	-	unsure 🔍 -2% - +4% -0.17ms - +0.39ms
previous-release previous-release	9.75ms - 10.15ms	unsure 🔍 -4% - +1% -0.45ms - +0.13ms	unsure 🔍 -4% - +2% -0.39ms - +0.17ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	255.10ms - 271.06ms	-	unsure 🔍 -1% - +7% -1.93ms - +17.37ms	slower ❌ 0% - 8% 1.09ms - 20.53ms
tip-of-tree tip-of-tree	249.93ms - 260.79ms	unsure 🔍 -7% - +1% -17.37ms - +1.93ms	-	unsure 🔍 -2% - +4% -4.67ms - +10.85ms
previous-release previous-release	246.72ms - 257.82ms	faster ✔ 1% - 8% 1.09ms - 20.53ms	unsure 🔍 -4% - +2% -10.85ms - +4.67ms	-

lit-html-template-heavy

Browser: chrome-headless 114.0.5735.198
Sample size: 50
Built by: Benchmarks #5024
Commit: 4df657e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	48.16ms - 49.77ms	-	unsure 🔍 -3% - +2% -1.34ms - +0.77ms	unsure 🔍 -1% - +4% -0.42ms - +1.76ms
tip-of-tree tip-of-tree	48.56ms - 49.93ms	unsure 🔍 -2% - +3% -0.77ms - +1.34ms	-	unsure 🔍 -0% - +4% -0.05ms - +1.96ms
previous-release previous-release	47.55ms - 49.04ms	unsure 🔍 -4% - +1% -1.76ms - +0.42ms	unsure 🔍 -4% - +0% -1.96ms - +0.05ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	102.10ms - 103.79ms	-	unsure 🔍 -2% - +1% -1.69ms - +0.86ms	unsure 🔍 -2% - +1% -2.05ms - +0.61ms
tip-of-tree tip-of-tree	102.40ms - 104.32ms	unsure 🔍 -1% - +2% -0.86ms - +1.69ms	-	unsure 🔍 -2% - +1% -1.71ms - +1.11ms
previous-release previous-release	102.63ms - 104.69ms	unsure 🔍 -1% - +2% -0.61ms - +2.05ms	unsure 🔍 -1% - +2% -1.11ms - +1.71ms	-

reactive-element-list

Browser: chrome-headless 114.0.5735.198
Sample size: 50
Built by: Benchmarks #5024
Commit: 4df657e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	43.42ms - 44.45ms	-	unsure 🔍 -1% - +2% -0.48ms - +0.86ms	unsure 🔍 -1% - +2% -0.37ms - +1.08ms
tip-of-tree tip-of-tree	43.32ms - 44.16ms	unsure 🔍 -2% - +1% -0.86ms - +0.48ms	-	unsure 🔍 -1% - +2% -0.49ms - +0.82ms
previous-release previous-release	43.07ms - 44.08ms	unsure 🔍 -2% - +1% -1.08ms - +0.37ms	unsure 🔍 -2% - +1% -0.82ms - +0.49ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	676.41ms - 682.87ms	-	unsure 🔍 -1% - +1% -3.49ms - +6.34ms	unsure 🔍 -1% - +0% -8.48ms - +1.14ms
tip-of-tree tip-of-tree	674.51ms - 681.93ms	unsure 🔍 -1% - +1% -6.34ms - +3.49ms	-	unsure 🔍 -1% - +0% -10.24ms - +0.05ms
previous-release previous-release	679.75ms - 686.88ms	unsure 🔍 -0% - +1% -1.14ms - +8.48ms	unsure 🔍 -0% - +2% -0.05ms - +10.24ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	676.27ms - 681.83ms	-	unsure 🔍 -0% - +1% -1.46ms - +6.54ms	unsure 🔍 -1% - +1% -4.28ms - +4.39ms
tip-of-tree tip-of-tree	673.63ms - 679.39ms	unsure 🔍 -1% - +0% -6.54ms - +1.46ms	-	unsure 🔍 -1% - +0% -6.88ms - +1.91ms
previous-release previous-release	675.68ms - 682.31ms	unsure 🔍 -1% - +1% -4.39ms - +4.28ms	unsure 🔍 -0% - +1% -1.91ms - +6.88ms	-

_{tachometer-reporter-action v2 for Benchmarks}

packages/labs/task/src/test/task_test.ts

packages/labs/task/src/task.ts

justinfagnani requested a review from rictic July 10, 2023 20:14

justinfagnani requested a review from kevinpschaaf as a code owner July 10, 2023 20:14

justinfagnani mentioned this pull request Jul 10, 2023

[@labs/task] add render return value #2821

Closed

Infer the return type of Task.render()

eb51235

justinfagnani force-pushed the task-render-return-type branch from 948025b to eb51235 Compare July 10, 2023 20:25

rictic reviewed Jul 10, 2023

View reviewed changes

packages/labs/task/src/test/task_test.ts Outdated Show resolved Hide resolved

packages/labs/task/src/task.ts Outdated Show resolved Hide resolved

justinfagnani added 2 commits July 10, 2023 17:08

Address feedback

4fd43d2

Default task return type to unknown

348ac83

justinfagnani commented Jul 11, 2023

View reviewed changes

packages/labs/task/src/task.ts Show resolved Hide resolved

justinfagnani requested a review from rictic July 11, 2023 00:13

rictic approved these changes Jul 11, 2023

View reviewed changes

justinfagnani merged commit fd7e7cd into main Jul 11, 2023

justinfagnani deleted the task-render-return-type branch July 11, 2023 04:09

lit-robot mentioned this pull request Aug 2, 2023

Version Packages #4066

Merged

[labs/task] Infer the return type of Task.render() #4008

[labs/task] Infer the return type of Task.render() #4008

Uh oh!

Conversation

justinfagnani commented Jul 10, 2023

Uh oh!

changeset-bot bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jul 10, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading