Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Version Packages #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 1 commit into from
Aug 2, 2023
Merged

Version Packages #4066

AndrewJakubowicz merged 1 commit into from
Aug 2, 2023

Conversation

@lit-robot
Copy link
Member

@lit-robot lit-robot commented Aug 2, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@lit-labs/[email protected]

Major Changes

  • #4027 c28cb6ed - - [BREAKING] Removed deprecated call signature for createComponent() taking multiple arguments. A single option object must be passed in instead.

    Example:

    - createComponent(React, 'my-element', MyElement, {onfoo: 'foo'})
+ createComponent({
+   react: React,
+   tagName: 'my-element',
+   elementClass: MyElement,
+   events: {onfoo: 'foo'},
+ })
    • Refactored to move implementation directly into render function of forwardRef rather than creating a class component. This removes an extra React component of the same name showing up in the component tree.

Patch Changes

  • #4000 2118aeb6 - Add @types/react@17||18 as peer dependency as the package makes direct use of those types.

  • #4061 25d10ee1 - Update WebComponentProps type to allow providing ref prop in JSX.

@lit-labs/[email protected]

Major Changes

  • #4004 5beb5f9a - Adds the 'afterUpdate' option for autoRun to Task, and runs tasks by default in hostUpdate() instead of hostUpdated(). 'afterUpdate' is needed to run tasks dependent on DOM updates, but will cause multiple renders of the host element.

  • #4013 a5bf2507 - Add pluggable task args equality functions and deepArrayEquals. Breaking: this removes performTask() and shouldRun() protected methods.

Minor Changes

Patch Changes

@lit-labs/[email protected]

Minor Changes

  • #4030 55bfed2f - Upgrade TypeScript to ~5.0

  • #3980 91611d73 - Add separate entrypoint for createPackageAnalyzer() which requires Node APIs

  • #4029 da6646d8 - Require a TypeScript object to construct an Analyzer

Patch Changes

@lit-labs/[email protected]

Minor Changes

Patch Changes

[email protected]

Minor Changes

  • #3993 e2c50569 - Fix return type of isTemplateResult helper to include the CompiledTemplateResult and fix the cache directive to work correctly with CompiledTemplateResults. Also add an explicit isCompiledTemplateResult helper.

Patch Changes

  • #4031 8057c78d - Rename ReactiveElement._initialize to __initialize, make it private, and remove the @internal annotation. This will help prevent collisions with subclasses that implement their own _initialize method, while using development builds.

  • Updated dependencies [e2c50569]:

[email protected]

Minor Changes

  • #3993 e2c50569 - Fix return type of isTemplateResult helper to include the CompiledTemplateResult and fix the cache directive to work correctly with CompiledTemplateResults. Also add an explicit isCompiledTemplateResult helper.

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

[email protected]

Patch Changes

  • #4031 8057c78d - Rename ReactiveElement._initialize to __initialize, make it private, and remove the @internal annotation. This will help prevent collisions with subclasses that implement their own _initialize method, while using development builds.

  • Updated dependencies [e2c50569]:

@lit/[email protected]

Patch Changes

  • #4031 8057c78d - Rename ReactiveElement._initialize to __initialize, make it private, and remove the @internal annotation. This will help prevent collisions with subclasses that implement their own _initialize method, while using development builds.

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

@lit-robot lit-robot requested a review from kevinpschaaf as a code owner August 2, 2023 16:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +5% (-1.94ms - +1.14ms)
    this-change vs tip-of-tree

render

  • this-change: 90.35ms - 96.91ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +5% (-0.80ms - +1.86ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-1.83ms - +1.15ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +2% (-3.77ms - +1.39ms)
    this-change vs tip-of-tree

update

  • this-change: 943.28ms - 973.95ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +6% (-1.72ms - +5.62ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-2.41ms - +4.68ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-25.61ms - +16.23ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 929.16ms - 954.94ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-19.88ms - +23.88ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
90.35ms - 96.91ms-

update

VersionAvg timevs
943.28ms - 973.95ms-

update-reflect

VersionAvg timevs
929.16ms - 954.94ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.22ms - 39.16ms-unsure 🔍
-2% - +5%
-0.80ms - +1.86ms		unsure 🔍
-6% - +1%
-2.31ms - +0.55ms
tip-of-tree
tip-of-tree		36.75ms - 38.56msunsure 🔍
-5% - +2%
-1.86ms - +0.80ms		-faster ✔
0% - 7%
0.03ms - 2.80ms
previous-release
previous-release		38.02ms - 40.12msunsure 🔍
-1% - +6%
-0.55ms - +2.31ms		slower ❌
0% - 7%
0.03ms - 2.80ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
90.99ms - 95.97ms-unsure 🔍
-2% - +6%
-1.72ms - +5.62ms		slower ❌
0% - 9%
0.53ms - 7.77ms
tip-of-tree
tip-of-tree		88.83ms - 94.22msunsure 🔍
-6% - +2%
-5.62ms - +1.72ms		-unsure 🔍
-2% - +7%
-1.56ms - +5.95ms
previous-release
previous-release		86.71ms - 91.95msfaster ✔
1% - 8%
0.53ms - 7.77ms		unsure 🔍
-6% - +2%
-5.95ms - +1.56ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
21.66ms - 23.73ms-unsure 🔍
-8% - +5%
-1.94ms - +1.14ms		unsure 🔍
-12% - +1%
-2.89ms - +0.24ms
tip-of-tree
tip-of-tree		21.96ms - 24.24msunsure 🔍
-5% - +9%
-1.14ms - +1.94ms		-unsure 🔍
-11% - +3%
-2.56ms - +0.72ms
previous-release
previous-release		22.84ms - 25.19msunsure 🔍
-1% - +13%
-0.24ms - +2.89ms		unsure 🔍
-3% - +11%
-0.72ms - +2.56ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
61.93ms - 63.81ms-unsure 🔍
-3% - +2%
-1.83ms - +1.15ms		unsure 🔍
-2% - +2%
-1.30ms - +1.35ms
tip-of-tree
tip-of-tree		62.06ms - 64.36msunsure 🔍
-2% - +3%
-1.15ms - +1.83ms		-unsure 🔍
-2% - +3%
-1.12ms - +1.84ms
previous-release
previous-release		61.92ms - 63.78msunsure 🔍
-2% - +2%
-1.35ms - +1.30ms		unsure 🔍
-3% - +2%
-1.84ms - +1.12ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
130.95ms - 135.80ms-unsure 🔍
-2% - +4%
-2.41ms - +4.68ms		unsure 🔍
-2% - +3%
-2.44ms - +4.51ms
tip-of-tree
tip-of-tree		129.66ms - 134.83msunsure 🔍
-3% - +2%
-4.68ms - +2.41ms		-unsure 🔍
-3% - +3%
-3.69ms - +3.48ms
previous-release
previous-release		129.86ms - 134.83msunsure 🔍
-3% - +2%
-4.51ms - +2.44ms		unsure 🔍
-3% - +3%
-3.48ms - +3.69ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
61.86ms - 64.74ms-unsure 🔍
-6% - +2%
-3.77ms - +1.39ms		unsure 🔍
-3% - +3%
-2.01ms - +1.72ms
tip-of-tree
tip-of-tree		62.35ms - 66.64msunsure 🔍
-2% - +6%
-1.39ms - +3.77ms		-unsure 🔍
-2% - +6%
-1.40ms - +3.49ms
previous-release
previous-release		62.27ms - 64.63msunsure 🔍
-3% - +3%
-1.72ms - +2.01ms		unsure 🔍
-5% - +2%
-3.49ms - +1.40ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1018.93ms - 1045.28ms-unsure 🔍
-2% - +2%
-25.61ms - +16.23ms		unsure 🔍
-3% - +1%
-33.95ms - +6.40ms
tip-of-tree
tip-of-tree		1020.55ms - 1053.04msunsure 🔍
-2% - +2%
-16.23ms - +25.61ms		-unsure 🔍
-3% - +1%
-31.39ms - +13.21ms
previous-release
previous-release		1030.60ms - 1061.16msunsure 🔍
-1% - +3%
-6.40ms - +33.95ms		unsure 🔍
-1% - +3%
-13.21ms - +31.39ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1028.03ms - 1057.17ms-unsure 🔍
-2% - +2%
-19.88ms - +23.88ms		unsure 🔍
-3% - +1%
-26.27ms - +15.63ms
tip-of-tree
tip-of-tree		1024.28ms - 1056.92msunsure 🔍
-2% - +2%
-23.88ms - +19.88ms		-unsure 🔍
-3% - +1%
-29.53ms - +14.89ms
previous-release
previous-release		1032.86ms - 1062.98msunsure 🔍
-2% - +3%
-15.63ms - +26.27ms		unsure 🔍
-1% - +3%
-14.89ms - +29.53ms		-

tachometer-reporter-action v2 for Benchmarks

AndrewJakubowicz
AndrewJakubowicz reviewed Aug 2, 2023
View reviewed changes
packages/labs/gen-manifest/package.json
@@ -1,8 +1,8 @@
{
"private": true,
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gen-manifest is private. Do we expect it to have the patch changes with dependency updates?

Copy link
Member

@augustjk augustjk Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't really help it with our current config of changeset as it auto bumps with dependent update. Looks like it's already had some version bumps too. We'll just have to reset the version when we decide to publish.

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz Aug 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree – thanks for confirming

AndrewJakubowicz
AndrewJakubowicz reviewed Aug 2, 2023
View reviewed changes
AndrewJakubowicz
AndrewJakubowicz approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewJakubowicz AndrewJakubowicz requested a review from rictic August 2, 2023 17:33
@AndrewJakubowicz AndrewJakubowicz merged commit 51c431e into main Aug 2, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the changeset-release/main branch August 2, 2023 19:50
bennypowers pushed a commit to bennypowers/lit that referenced this pull request Aug 6, 2023
@lit-robot @bennypowers
Version Packages (lit#4066)
7a82a27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@augustjk augustjk augustjk approved these changes

@rictic rictic rictic approved these changes

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lit-robot @rictic @justinfagnani @AndrewJakubowicz @augustjk