Update the analyzer to typescript ~5.0 #4030

justinfagnani · 2023-07-19T08:04:54Z

No description provided.

changeset-bot · 2023-07-19T08:04:56Z

🦋 Changeset detected

Latest commit: 2b68ec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@lit-labs/analyzer	Minor
@lit-labs/cli	Minor
@lit-labs/gen-manifest	Patch
@lit-labs/gen-utils	Patch
@lit-labs/gen-wrapper-angular	Patch
@lit-labs/gen-wrapper-react	Patch
@lit-labs/gen-wrapper-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-07-19T08:05:18Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -14% - +3% (-3.29ms - +0.65ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 65.36ms - 68.18ms
lit-html-kitchen-sink: unsure 🔍 -12% - +4% (-3.60ms - +1.25ms)
^{this-change vs tip-of-tree}
lit-html-repeat: slower ❌ 0% - 7% (0.01ms - 0.64ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.45ms - +1.71ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-0.51ms - +0.83ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 682.58ms - 689.19ms
lit-html-kitchen-sink: unsure 🔍 -3% - +7% (-1.81ms - +5.26ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -10% - +14% (-29.15ms - +38.66ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.14ms - +1.25ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +0% (-7.12ms - +3.32ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 652.83ms - 657.76ms
reactive-element-list: unsure 🔍 -1% - +0% (-4.65ms - +2.96ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 114.0.5735.198
Sample size: 50
Built by: Benchmarks #5065
Commit: cc3dd30

render

Version	Avg time	vs
	65.36ms - 68.18ms	-

update

Version	Avg time	vs
	682.58ms - 689.19ms	-

update-reflect

Version	Avg time	vs
	652.83ms - 657.76ms	-

lit-html-kitchen-sink

Browser: chrome-headless 114.0.5735.198
Sample size: 30
Built by: Benchmarks #5065
Commit: cc3dd30

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	28.06ms - 31.16ms	-	unsure 🔍 -12% - +4% -3.60ms - +1.25ms	unsure 🔍 -6% - +8% -1.81ms - +2.39ms
tip-of-tree tip-of-tree	28.92ms - 32.66ms	unsure 🔍 -4% - +12% -1.25ms - +3.60ms	-	unsure 🔍 -3% - +13% -0.88ms - +3.81ms
previous-release previous-release	27.90ms - 30.74ms	unsure 🔍 -8% - +6% -2.39ms - +1.81ms	unsure 🔍 -12% - +3% -3.81ms - +0.88ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	73.16ms - 78.04ms	-	unsure 🔍 -3% - +7% -1.81ms - +5.26ms	unsure 🔍 -7% - +2% -5.44ms - +1.48ms
tip-of-tree tip-of-tree	71.31ms - 76.43ms	unsure 🔍 -7% - +2% -5.26ms - +1.81ms	-	faster ✔ 0% - 9% 0.16ms - 7.25ms
previous-release previous-release	75.12ms - 80.03ms	unsure 🔍 -2% - +7% -1.48ms - +5.44ms	slower ❌ 0% - 10% 0.16ms - 7.25ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	19.65ms - 22.46ms	-	unsure 🔍 -14% - +3% -3.29ms - +0.65ms	unsure 🔍 -14% - +2% -3.31ms - +0.43ms
tip-of-tree tip-of-tree	20.99ms - 23.75ms	unsure 🔍 -3% - +16% -0.65ms - +3.29ms	-	unsure 🔍 -9% - +8% -1.97ms - +1.73ms
previous-release previous-release	21.26ms - 23.73ms	unsure 🔍 -2% - +16% -0.43ms - +3.31ms	unsure 🔍 -8% - +9% -1.73ms - +1.97ms	-

lit-html-repeat

Browser: chrome-headless 114.0.5735.198
Sample size: 30
Built by: Benchmarks #5065
Commit: cc3dd30

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.01ms - 10.41ms	-	slower ❌ 0% - 7% 0.01ms - 0.64ms	unsure 🔍 -1% - +5% -0.13ms - +0.49ms
tip-of-tree tip-of-tree	9.65ms - 10.13ms	faster ✔ 0% - 6% 0.01ms - 0.64ms	-	unsure 🔍 -5% - +2% -0.49ms - +0.19ms
previous-release previous-release	9.80ms - 10.27ms	unsure 🔍 -5% - +1% -0.49ms - +0.13ms	unsure 🔍 -2% - +5% -0.19ms - +0.49ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	267.89ms - 316.88ms	-	unsure 🔍 -10% - +14% -29.15ms - +38.66ms	unsure 🔍 -12% - +14% -33.08ms - +39.80ms
tip-of-tree tip-of-tree	264.18ms - 311.08ms	unsure 🔍 -13% - +10% -38.66ms - +29.15ms	-	unsure 🔍 -13% - +12% -37.14ms - +34.34ms
previous-release previous-release	262.05ms - 316.00ms	unsure 🔍 -14% - +11% -39.80ms - +33.08ms	unsure 🔍 -12% - +13% -34.34ms - +37.14ms	-

lit-html-template-heavy

Browser: chrome-headless 114.0.5735.198
Sample size: 50
Built by: Benchmarks #5065
Commit: cc3dd30

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	48.22ms - 50.01ms	-	unsure 🔍 -1% - +4% -0.45ms - +1.71ms	unsure 🔍 -1% - +4% -0.63ms - +1.86ms
tip-of-tree tip-of-tree	47.88ms - 49.08ms	unsure 🔍 -3% - +1% -1.71ms - +0.45ms	-	unsure 🔍 -2% - +2% -1.07ms - +1.03ms
previous-release previous-release	47.63ms - 49.36ms	unsure 🔍 -4% - +1% -1.86ms - +0.63ms	unsure 🔍 -2% - +2% -1.03ms - +1.07ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	105.27ms - 106.88ms	-	unsure 🔍 -1% - +1% -1.14ms - +1.25ms	unsure 🔍 -2% - +1% -2.41ms - +0.78ms
tip-of-tree tip-of-tree	105.14ms - 106.90ms	unsure 🔍 -1% - +1% -1.25ms - +1.14ms	-	unsure 🔍 -2% - +1% -2.51ms - +0.77ms
previous-release previous-release	105.51ms - 108.27ms	unsure 🔍 -1% - +2% -0.78ms - +2.41ms	unsure 🔍 -1% - +2% -0.77ms - +2.51ms	-

reactive-element-list

Browser: chrome-headless 114.0.5735.198
Sample size: 50
Built by: Benchmarks #5065
Commit: cc3dd30

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	43.73ms - 44.70ms	-	unsure 🔍 -1% - +2% -0.51ms - +0.83ms	unsure 🔍 -1% - +2% -0.43ms - +0.86ms
tip-of-tree tip-of-tree	43.59ms - 44.51ms	unsure 🔍 -2% - +1% -0.83ms - +0.51ms	-	unsure 🔍 -1% - +2% -0.57ms - +0.68ms
previous-release previous-release	43.57ms - 44.43ms	unsure 🔍 -2% - +1% -0.86ms - +0.43ms	unsure 🔍 -2% - +1% -0.68ms - +0.57ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	678.77ms - 685.96ms	-	unsure 🔍 -1% - +0% -7.12ms - +3.32ms	unsure 🔍 -1% - +1% -5.01ms - +5.11ms
tip-of-tree tip-of-tree	680.49ms - 688.05ms	unsure 🔍 -0% - +1% -3.32ms - +7.12ms	-	unsure 🔍 -0% - +1% -3.25ms - +7.15ms
previous-release previous-release	678.75ms - 685.89ms	unsure 🔍 -1% - +1% -5.11ms - +5.01ms	unsure 🔍 -1% - +0% -7.15ms - +3.25ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	678.36ms - 683.03ms	-	unsure 🔍 -1% - +0% -4.65ms - +2.96ms	unsure 🔍 -1% - +0% -4.70ms - +2.49ms
tip-of-tree tip-of-tree	678.54ms - 684.54ms	unsure 🔍 -0% - +1% -2.96ms - +4.65ms	-	unsure 🔍 -1% - +1% -4.32ms - +3.81ms
previous-release previous-release	679.06ms - 684.53ms	unsure 🔍 -0% - +1% -2.49ms - +4.70ms	unsure 🔍 -1% - +1% -3.81ms - +4.32ms	-

_{tachometer-reporter-action v2 for Benchmarks}

justinfagnani · 2023-07-19T08:16:01Z

This appeared to build and pass tests locally (I need to file a Wireit bug about that), but obviously doesn't. I need to update decorator access.

justinfagnani and others added 11 commits June 24, 2023 17:04

Add separate entrypoint for createPackageAnalyzer

dcfd6aa

Merge branch 'main' into analyzer-files

ee9cbd3

Address feedback

1166c88

Fix build

f55e8bc

Merge branch 'main' into analyzer-files

28d39fa

rename a file

3bcf251

fix package.json

63029eb

fix

1cd4614

format

6bffda8

Require a TypeScript object to construct an Analyzer

f68c4a1

Update the analyzer to typescript ~5.0

ab9eb0e

justinfagnani requested a review from rictic July 19, 2023 08:04

justinfagnani requested a review from kevinpschaaf as a code owner July 19, 2023 08:04

fix build

177e6e8

rictic approved these changes Jul 19, 2023

View reviewed changes

Base automatically changed from analyzer-byots to main July 19, 2023 17:09

justinfagnani added 2 commits July 19, 2023 10:25

Merge branch 'main' into analyzer-ts-5

170b3cd

add changeset

2b68ec4

justinfagnani enabled auto-merge (squash) July 19, 2023 17:36

justinfagnani merged commit 55bfed2 into main Jul 19, 2023

justinfagnani deleted the analyzer-ts-5 branch July 19, 2023 17:46

lit-robot mentioned this pull request Aug 2, 2023

Version Packages #4066

Merged

Update the analyzer to typescript ~5.0 #4030

Update the analyzer to typescript ~5.0 #4030

Uh oh!

Conversation

justinfagnani commented Jul 19, 2023

Uh oh!

changeset-bot bot commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

justinfagnani commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading