Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Provide an AbortSignal to task functions #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 2 commits into from
Jul 7, 2023
Merged

Provide an AbortSignal to task functions #3996

justinfagnani merged 2 commits into from
Jul 7, 2023

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Jul 6, 2023

Fixes #3995

This is part one of full task cancellation support. Up next will be a way for an author to either pass in an AbortSignal or manual cancel the task with task.abort().

@justinfagnani justinfagnani requested a review from rictic July 6, 2023 22:23
@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d4767e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/task Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -10% - +7% (-2.27ms - +1.47ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 66.74ms - 69.16ms
  • lit-html-kitchen-sink: unsure 🔍 -7% - +9% (-2.13ms - +2.63ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +3% (-0.30ms - +0.30ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-1.59ms - +0.99ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +0% (-1.23ms - +0.01ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 668.97ms - 675.94ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +3% (-4.56ms - +2.26ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +7% (-8.22ms - +18.10ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +1% (-4.31ms - +0.95ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-4.77ms - +5.10ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 641.17ms - 646.99ms
  • reactive-element-list: unsure 🔍 -0% - +1% (-2.76ms - +4.34ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
66.74ms - 69.16ms-

update

VersionAvg timevs
668.97ms - 675.94ms-

update-reflect

VersionAvg timevs
641.17ms - 646.99ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
28.80ms - 31.60ms-unsure 🔍
-7% - +9%
-2.13ms - +2.63ms		unsure 🔍
-9% - +7%
-2.71ms - +2.18ms
tip-of-tree
tip-of-tree		28.02ms - 31.88msunsure 🔍
-9% - +7%
-2.63ms - +2.13ms		-unsure 🔍
-11% - +7%
-3.30ms - +2.26ms
previous-release
previous-release		28.46ms - 32.48msunsure 🔍
-7% - +9%
-2.18ms - +2.71ms		unsure 🔍
-8% - +11%
-2.26ms - +3.30ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
73.46ms - 77.56ms-unsure 🔍
-6% - +3%
-4.56ms - +2.26ms		unsure 🔍
-5% - +4%
-3.72ms - +2.89ms
tip-of-tree
tip-of-tree		73.93ms - 79.39msunsure 🔍
-3% - +6%
-2.26ms - +4.56ms		-unsure 🔍
-4% - +6%
-3.03ms - +4.50ms
previous-release
previous-release		73.33ms - 78.52msunsure 🔍
-4% - +5%
-2.89ms - +3.72ms		unsure 🔍
-6% - +4%
-4.50ms - +3.03ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.89ms - 22.47ms-unsure 🔍
-10% - +7%
-2.27ms - +1.47ms		unsure 🔍
-10% - +8%
-2.05ms - +1.76ms
tip-of-tree
tip-of-tree		20.23ms - 22.93msunsure 🔍
-7% - +11%
-1.47ms - +2.27ms		-unsure 🔍
-8% - +10%
-1.69ms - +2.20ms
previous-release
previous-release		19.92ms - 22.72msunsure 🔍
-8% - +10%
-1.76ms - +2.05ms		unsure 🔍
-10% - +8%
-2.20ms - +1.69ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
9.83ms - 10.27ms-unsure 🔍
-3% - +3%
-0.30ms - +0.30ms		unsure 🔍
-3% - +4%
-0.25ms - +0.36ms
tip-of-tree
tip-of-tree		9.85ms - 10.25msunsure 🔍
-3% - +3%
-0.30ms - +0.30ms		-unsure 🔍
-2% - +3%
-0.24ms - +0.35ms
previous-release
previous-release		9.78ms - 10.21msunsure 🔍
-4% - +3%
-0.36ms - +0.25ms		unsure 🔍
-3% - +2%
-0.35ms - +0.24ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
258.54ms - 277.27ms-unsure 🔍
-3% - +7%
-8.22ms - +18.10ms		unsure 🔍
-1% - +8%
-3.27ms - +19.44ms
tip-of-tree
tip-of-tree		253.72ms - 272.21msunsure 🔍
-7% - +3%
-18.10ms - +8.22ms		-unsure 🔍
-3% - +6%
-8.11ms - +14.40ms
previous-release
previous-release		253.40ms - 266.24msunsure 🔍
-7% - +1%
-19.44ms - +3.27ms		unsure 🔍
-5% - +3%
-14.40ms - +8.11ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
48.28ms - 50.07ms-unsure 🔍
-3% - +2%
-1.59ms - +0.99ms		unsure 🔍
-3% - +3%
-1.31ms - +1.28ms
tip-of-tree
tip-of-tree		48.54ms - 50.40msunsure 🔍
-2% - +3%
-0.99ms - +1.59ms		-unsure 🔍
-2% - +3%
-1.03ms - +1.60ms
previous-release
previous-release		48.26ms - 50.12msunsure 🔍
-3% - +3%
-1.28ms - +1.31ms		unsure 🔍
-3% - +2%
-1.60ms - +1.03ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
106.25ms - 108.72ms-unsure 🔍
-4% - +1%
-4.31ms - +0.95ms		unsure 🔍
-2% - +1%
-2.62ms - +1.14ms
tip-of-tree
tip-of-tree		106.84ms - 111.49msunsure 🔍
-1% - +4%
-0.95ms - +4.31ms		-unsure 🔍
-2% - +3%
-1.77ms - +3.67ms
previous-release
previous-release		106.80ms - 109.63msunsure 🔍
-1% - +2%
-1.14ms - +2.62ms		unsure 🔍
-3% - +2%
-3.67ms - +1.77ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
43.38ms - 44.20ms-unsure 🔍
-3% - +0%
-1.23ms - +0.01ms		unsure 🔍
-1% - +2%
-0.37ms - +0.78ms
tip-of-tree
tip-of-tree		43.93ms - 44.86msunsure 🔍
-0% - +3%
-0.01ms - +1.23ms		-slower ❌
0% - 3%
0.20ms - 1.43ms
previous-release
previous-release		43.17ms - 43.99msunsure 🔍
-2% - +1%
-0.78ms - +0.37ms		faster ✔
0% - 3%
0.20ms - 1.43ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
668.78ms - 676.30ms-unsure 🔍
-1% - +1%
-4.77ms - +5.10ms		unsure 🔍
-1% - +1%
-5.79ms - +3.94ms
tip-of-tree
tip-of-tree		669.18ms - 675.57msunsure 🔍
-1% - +1%
-5.10ms - +4.77ms		-unsure 🔍
-1% - +0%
-5.54ms - +3.34ms
previous-release
previous-release		670.38ms - 676.55msunsure 🔍
-1% - +1%
-3.94ms - +5.79ms		unsure 🔍
-0% - +1%
-3.34ms - +5.54ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
666.88ms - 672.09ms-unsure 🔍
-0% - +1%
-2.76ms - +4.34ms		unsure 🔍
-1% - +0%
-4.71ms - +2.97ms
tip-of-tree
tip-of-tree		666.28ms - 671.11msunsure 🔍
-1% - +0%
-4.34ms - +2.76ms		-unsure 🔍
-1% - +0%
-5.38ms - +2.06ms
previous-release
previous-release		667.53ms - 673.18msunsure 🔍
-0% - +1%
-2.97ms - +4.71ms		unsure 🔍
-0% - +1%
-2.06ms - +5.38ms		-

tachometer-reporter-action v2 for Benchmarks

rictic
rictic approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple additional assertions I'd recommend

@justinfagnani justinfagnani merged commit 012e8bc into main Jul 7, 2023
@justinfagnani justinfagnani deleted the task-abort branch July 7, 2023 02:04
@lit-robot lit-robot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[labs/task] Provide an AbortSignal to task functions and abort pending signals on new task runs

2 participants

@justinfagnani @rictic