Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/analyzer] Add separate entrypoint for createPackageAnalyzer #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 9 commits into from
Jul 19, 2023
Merged

[labs/analyzer] Add separate entrypoint for createPackageAnalyzer #3980

justinfagnani merged 9 commits into from
Jul 19, 2023

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Jun 25, 2023

Previously index.ts imported both the main Analyzer class and createPackageAnalyzer(), which uses Node APIs.

This PR separates the entrypoints into index.ts which only exports the Analyzer class and model interfaces, and package-analyzer.ts which exports all of that, plus createPackageAnalyzer().

This is a breaking change.

@justinfagnani justinfagnani requested a review from rictic June 25, 2023 00:05
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 6bffda8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@lit-labs/analyzer Minor
@lit-labs/cli Patch
@lit-labs/gen-manifest Patch
@lit-labs/gen-utils Patch
@lit-labs/gen-wrapper-angular Patch
@lit-labs/gen-wrapper-react Patch
@lit-labs/gen-wrapper-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@justinfagnani justinfagnani changed the title Add separate entrypoint for createPackageAnalyzer [labs/analyzer] Add separate entrypoint for createPackageAnalyzer Jun 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -13% - +6% (-3.09ms - +1.44ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 68.58ms - 71.90ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +14% (-1.36ms - +4.21ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +3% (-0.25ms - +0.34ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +2% (-1.18ms - +1.21ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +3% (-0.54ms - +1.15ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 776.80ms - 790.53ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +4% (-3.24ms - +3.52ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +4% (-2.66ms - +11.43ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.64ms - +1.72ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +2% (-2.68ms - +11.76ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 733.84ms - 745.09ms
  • reactive-element-list: unsure 🔍 -0% - +1% (-3.45ms - +9.05ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
68.58ms - 71.90ms-

update

VersionAvg timevs
776.80ms - 790.53ms-

update-reflect

VersionAvg timevs
733.84ms - 745.09ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
29.03ms - 33.19ms-unsure 🔍
-5% - +14%
-1.36ms - +4.21ms		unsure 🔍
-10% - +7%
-3.10ms - +2.23ms
tip-of-tree
tip-of-tree		27.83ms - 31.54msunsure 🔍
-13% - +4%
-4.21ms - +1.36ms		-unsure 🔍
-14% - +2%
-4.36ms - +0.64ms
previous-release
previous-release		29.87ms - 33.22msunsure 🔍
-7% - +10%
-2.23ms - +3.10ms		unsure 🔍
-2% - +15%
-0.64ms - +4.36ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
77.63ms - 82.59ms-unsure 🔍
-4% - +4%
-3.24ms - +3.52ms		unsure 🔍
-2% - +9%
-1.06ms - +6.96ms
tip-of-tree
tip-of-tree		77.67ms - 82.27msunsure 🔍
-4% - +4%
-3.52ms - +3.24ms		-unsure 🔍
-2% - +9%
-1.09ms - +6.71ms
previous-release
previous-release		74.00ms - 80.31msunsure 🔍
-9% - +1%
-6.96ms - +1.06ms		unsure 🔍
-8% - +1%
-6.71ms - +1.09ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
20.86ms - 24.63ms-unsure 🔍
-13% - +6%
-3.09ms - +1.44ms		unsure 🔍
-10% - +12%
-2.21ms - +2.65ms
tip-of-tree
tip-of-tree		22.31ms - 24.83msunsure 🔍
-7% - +14%
-1.44ms - +3.09ms		-unsure 🔍
-4% - +14%
-0.95ms - +3.03ms
previous-release
previous-release		20.99ms - 24.07msunsure 🔍
-12% - +10%
-2.65ms - +2.21ms		unsure 🔍
-13% - +4%
-3.03ms - +0.95ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
9.77ms - 10.16ms-unsure 🔍
-3% - +3%
-0.25ms - +0.34ms		unsure 🔍
-2% - +4%
-0.21ms - +0.37ms
tip-of-tree
tip-of-tree		9.70ms - 10.14msunsure 🔍
-3% - +3%
-0.34ms - +0.25ms		-unsure 🔍
-3% - +4%
-0.28ms - +0.35ms
previous-release
previous-release		9.66ms - 10.10msunsure 🔍
-4% - +2%
-0.37ms - +0.21ms		unsure 🔍
-4% - +3%
-0.35ms - +0.28ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
288.90ms - 299.14ms-unsure 🔍
-1% - +4%
-2.66ms - +11.43ms		unsure 🔍
-5% - +2%
-13.52ms - +5.66ms
tip-of-tree
tip-of-tree		284.79ms - 294.47msunsure 🔍
-4% - +1%
-11.43ms - +2.66ms		-unsure 🔍
-6% - +0%
-17.76ms - +1.13ms
previous-release
previous-release		289.83ms - 306.05msunsure 🔍
-2% - +5%
-5.66ms - +13.52ms		unsure 🔍
-0% - +6%
-1.13ms - +17.76ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
51.32ms - 52.97ms-unsure 🔍
-2% - +2%
-1.18ms - +1.21ms		unsure 🔍
-3% - +2%
-1.46ms - +1.19ms
tip-of-tree
tip-of-tree		51.26ms - 52.99msunsure 🔍
-2% - +2%
-1.21ms - +1.18ms		-unsure 🔍
-3% - +2%
-1.50ms - +1.19ms
previous-release
previous-release		51.25ms - 53.32msunsure 🔍
-2% - +3%
-1.19ms - +1.46ms		unsure 🔍
-2% - +3%
-1.19ms - +1.50ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
112.74ms - 115.30ms-unsure 🔍
-1% - +2%
-1.64ms - +1.72ms		unsure 🔍
-0% - +3%
-0.05ms - +3.24ms
tip-of-tree
tip-of-tree		112.90ms - 115.07msunsure 🔍
-2% - +1%
-1.72ms - +1.64ms		-slower ❌
0% - 3%
0.06ms - 3.05ms
previous-release
previous-release		111.39ms - 113.46msunsure 🔍
-3% - +0%
-3.24ms - +0.05ms		faster ✔
0% - 3%
0.06ms - 3.05ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
44.23ms - 45.32ms-unsure 🔍
-1% - +3%
-0.54ms - +1.15ms		unsure 🔍
-1% - +3%
-0.32ms - +1.36ms
tip-of-tree
tip-of-tree		43.83ms - 45.11msunsure 🔍
-3% - +1%
-1.15ms - +0.54ms		-unsure 🔍
-2% - +3%
-0.70ms - +1.13ms
previous-release
previous-release		43.61ms - 44.90msunsure 🔍
-3% - +1%
-1.36ms - +0.32ms		unsure 🔍
-3% - +2%
-1.13ms - +0.70ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
774.65ms - 785.86ms-unsure 🔍
-0% - +2%
-2.68ms - +11.76ms		unsure 🔍
-1% - +1%
-5.91ms - +8.54ms
tip-of-tree
tip-of-tree		771.17ms - 780.26msunsure 🔍
-2% - +0%
-11.76ms - +2.68ms		-unsure 🔍
-1% - +0%
-9.67ms - +3.22ms
previous-release
previous-release		774.38ms - 783.51msunsure 🔍
-1% - +1%
-8.54ms - +5.91ms		unsure 🔍
-0% - +1%
-3.22ms - +9.67ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
755.81ms - 764.81ms-unsure 🔍
-0% - +1%
-3.45ms - +9.05ms		unsure 🔍
-1% - +1%
-7.56ms - +5.70ms
tip-of-tree
tip-of-tree		753.18ms - 761.85msunsure 🔍
-1% - +0%
-9.05ms - +3.45ms		-unsure 🔍
-1% - +0%
-10.25ms - +2.79ms
previous-release
previous-release		756.37ms - 766.11msunsure 🔍
-1% - +1%
-5.70ms - +7.56ms		unsure 🔍
-0% - +1%
-2.79ms - +10.25ms		-

tachometer-reporter-action v2 for Benchmarks

rictic
rictic requested changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing

kevinpschaaf
kevinpschaaf approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the naming issue @rictic raised. Did you want the top-level import to be package-analyzer.js to match analyzer.js? If so, need to rename the file, otherwise rename the exports in package.json.

@justinfagnani justinfagnani requested a review from rictic July 18, 2023 00:28
@justinfagnani
Copy link
Collaborator Author

justinfagnani commented Jul 18, 2023

Argh. I don't understand why the build is failing on CI now. Build and tests are passing on my machine even after a git clean. I also don't understand why it was passing on my machine earlier as I had some obviously bad imports.

@justinfagnani justinfagnani mentioned this pull request Jul 19, 2023
Merged
@justinfagnani justinfagnani enabled auto-merge (squash) July 19, 2023 06:31
@justinfagnani justinfagnani merged commit 91611d7 into main Jul 19, 2023
@justinfagnani justinfagnani deleted the analyzer-files branch July 19, 2023 16:24
@lit-robot lit-robot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfagnani @rictic @kevinpschaaf