[labs/analyzer] Require a TypeScript object to construct an Analyzer #4029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63bc673 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultslit-element-list
render
update
update-reflect
lit-html-kitchen-sink
render
update
nop-update
lit-html-repeat
render
update
lit-html-template-heavy
render
update
reactive-element-list
render
update
update-reflect
|
01401c4 to
f68c4a1
Compare
rictic
approved these changes
Jul 19, 2023
| path: this.path, | ||
| typescript: this.typescript, | ||
| getProgram: this._getProgram, | ||
| } = init); |
Collaborator
There was a problem hiding this comment.
Is this syntax any better? a sequence of assignments seems more legible and more likely to be optimized by VMs
Collaborator
Author
There was a problem hiding this comment.
In size constrained libraries it removes a dereference per property, and I've started to like the look of the pattern. It's also nice for code-completion when you add a new option to the init interface.
| */ | ||
| const parseType = (typeString: string): ts.TypeNode | undefined => { | ||
| // TODO (justinfagnani): This would probably be a bit cleaner as an instance | ||
| // method on Analyzer now. |
Collaborator
There was a problem hiding this comment.
There will never be an easier time to make breaking changes than now
Collaborator
Author
There was a problem hiding this comment.
This wouldn't be a breaking change, and would add public API, so I wanted to be conservative.
There are a lot of potential cleanups I saw while in here, I also needed to limit the changes to just the relevant ones to keep things reviewable.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4018
Builds on #3980
Implements a BYOTS pattern for the analyzer. This PR does not update TypeScript yet, but I think we should update it to 5.0 as a follow up.
I implemented this fairly mechanically, bottom-up, adding a typescript arg to functions that needed it, and re-using the analyzer argument if there already was one. The end result might be a little inconsistent, but functions generally take only what they need. I think stylistically it might be nice to most the analyzer argument first, as would be done with curry-compatible style (put the varying arguments last).