fix (labs/analyzer): use analyzer typescript instead of import #4252
Conversation
There are still some places where we use methods available on our imported `ts` rather than from the analyzer's reference (`analyzer.typescript`). This causes various problems with version mismatches and bundling. These have now been updated to use the analyzer's typescript.
🦋 Changeset detectedLatest commit: 0ca3a98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Regarding the API shape question, I noted when I made the change that it's a bit inconsistent: #4029 I think I'd like to see the types narrowed to just what's necessary. There a couple of issues to consider though:
That said, I think it'd be good to clean up now. I'm starting to add template utilities that are useful without full program analysis, like in #4261 and made those just take a typescript and checker (though maybe that should be a Program?). Another thing is the order of operations. I think the Analyzer or TypeScript lib objects should probably come first in the parameter list. |
fix (labs/analyzer): use analyzer typescript instead of import There are still some places where we use methods available on our imported `ts` rather than from the analyzer's reference (`analyzer.typescript`). This causes various problems with version mismatches and bundling. These have now been updated to use the analyzer's typescript.
There are still some places where we use methods available on our imported
tsrather than from the analyzer's reference (analyzer.typescript). This causes various problems with version mismatches and bundling.These have now been updated to use the analyzer's typescript.
Related question
While doing this change, I noticed we generally follow two common signatures for our functions:
(node, analyzer)(ts, node)For the latter, it does make a sense from a purist point of view... type guards and what not which operate purely on a given AST node don't need the analyzer in theory, so they accept a typescript lib ref instead.
But it does mean we switch back and forth inconsistently sometimes between these signatures. maybe we want to always pass an analyzer and just pull the typescript from that?