Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/gen-wrapper-react] Update to emit createComponent with option object syntax #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
augustjk merged 1 commit into from
Jul 17, 2023
Merged

[labs/gen-wrapper-react] Update to emit createComponent with option object syntax #4021

augustjk merged 1 commit into from
Jul 17, 2023

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Jul 14, 2023

It should not emit deprecated syntax.

@augustjk augustjk requested a review from kevinpschaaf as a code owner July 14, 2023 22:48
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: 1fed525

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/gen-wrapper-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -4% - +16% (-0.81ms - +3.36ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 67.45ms - 70.71ms
  • lit-html-kitchen-sink: unsure 🔍 -15% - +2% (-5.04ms - +0.79ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +3% (-0.41ms - +0.28ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +2% (-1.10ms - +1.11ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-0.75ms - +0.65ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 712.81ms - 725.05ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +6% (-2.80ms - +4.51ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +5% (-7.83ms - +12.95ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.63ms - +1.28ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-1.28ms - +8.36ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 681.60ms - 689.70ms
  • reactive-element-list: unsure 🔍 -1% - +0% (-4.58ms - +3.44ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
67.45ms - 70.71ms-

update

VersionAvg timevs
712.81ms - 725.05ms-

update-reflect

VersionAvg timevs
681.60ms - 689.70ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
28.05ms - 31.52ms-unsure 🔍
-15% - +2%
-5.04ms - +0.79ms		unsure 🔍
-10% - +5%
-3.13ms - +1.54ms
tip-of-tree
tip-of-tree		29.57ms - 34.26msunsure 🔍
-3% - +17%
-0.79ms - +5.04ms		-unsure 🔍
-5% - +14%
-1.48ms - +4.15ms
previous-release
previous-release		29.02ms - 32.14msunsure 🔍
-5% - +11%
-1.54ms - +3.13ms		unsure 🔍
-13% - +4%
-4.15ms - +1.48ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
78.23ms - 83.46ms-unsure 🔍
-4% - +6%
-2.80ms - +4.51ms		unsure 🔍
-3% - +6%
-2.19ms - +4.77ms
tip-of-tree
tip-of-tree		77.44ms - 82.55msunsure 🔍
-6% - +3%
-4.51ms - +2.80ms		-unsure 🔍
-4% - +5%
-3.00ms - +3.88ms
previous-release
previous-release		77.25ms - 81.86msunsure 🔍
-6% - +3%
-4.77ms - +2.19ms		unsure 🔍
-5% - +4%
-3.88ms - +3.00ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
20.97ms - 23.93ms-unsure 🔍
-4% - +16%
-0.81ms - +3.36ms		unsure 🔍
-5% - +15%
-1.01ms - +3.08ms
tip-of-tree
tip-of-tree		19.71ms - 22.64msunsure 🔍
-15% - +3%
-3.36ms - +0.81ms		-unsure 🔍
-11% - +8%
-2.28ms - +1.80ms
previous-release
previous-release		20.00ms - 22.82msunsure 🔍
-14% - +4%
-3.08ms - +1.01ms		unsure 🔍
-9% - +11%
-1.80ms - +2.28ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
9.77ms - 10.26ms-unsure 🔍
-4% - +3%
-0.41ms - +0.28ms		unsure 🔍
-5% - +1%
-0.52ms - +0.11ms
tip-of-tree
tip-of-tree		9.84ms - 10.32msunsure 🔍
-3% - +4%
-0.28ms - +0.41ms		-unsure 🔍
-4% - +2%
-0.45ms - +0.17ms
previous-release
previous-release		10.02ms - 10.42msunsure 🔍
-1% - +5%
-0.11ms - +0.52ms		unsure 🔍
-2% - +5%
-0.17ms - +0.45ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
258.87ms - 272.42ms-unsure 🔍
-3% - +5%
-7.83ms - +12.95ms		unsure 🔍
-4% - +4%
-9.76ms - +9.60ms
tip-of-tree
tip-of-tree		255.21ms - 270.96msunsure 🔍
-5% - +3%
-12.95ms - +7.83ms		-unsure 🔍
-5% - +3%
-13.12ms - +7.84ms
previous-release
previous-release		258.81ms - 272.65msunsure 🔍
-4% - +4%
-9.60ms - +9.76ms		unsure 🔍
-3% - +5%
-7.84ms - +13.12ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
49.91ms - 51.45ms-unsure 🔍
-2% - +2%
-1.10ms - +1.11ms		unsure 🔍
-2% - +2%
-0.90ms - +1.26ms
tip-of-tree
tip-of-tree		49.89ms - 51.47msunsure 🔍
-2% - +2%
-1.11ms - +1.10ms		-unsure 🔍
-2% - +3%
-0.91ms - +1.27ms
previous-release
previous-release		49.75ms - 51.26msunsure 🔍
-2% - +2%
-1.26ms - +0.90ms		unsure 🔍
-3% - +2%
-1.27ms - +0.91ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
111.04ms - 113.18ms-unsure 🔍
-1% - +1%
-1.63ms - +1.28ms		unsure 🔍
-2% - +1%
-2.53ms - +0.75ms
tip-of-tree
tip-of-tree		111.31ms - 113.27msunsure 🔍
-1% - +1%
-1.28ms - +1.63ms		-unsure 🔍
-2% - +1%
-2.30ms - +0.87ms
previous-release
previous-release		111.76ms - 114.25msunsure 🔍
-1% - +2%
-0.75ms - +2.53ms		unsure 🔍
-1% - +2%
-0.87ms - +2.30ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
45.40ms - 46.39ms-unsure 🔍
-2% - +1%
-0.75ms - +0.65ms		unsure 🔍
-3% - +0%
-1.33ms - +0.10ms
tip-of-tree
tip-of-tree		45.45ms - 46.44msunsure 🔍
-1% - +2%
-0.65ms - +0.75ms		-unsure 🔍
-3% - +0%
-1.28ms - +0.15ms
previous-release
previous-release		45.99ms - 47.03msunsure 🔍
-0% - +3%
-0.10ms - +1.33ms		unsure 🔍
-0% - +3%
-0.15ms - +1.28ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
709.91ms - 717.39ms-unsure 🔍
-0% - +1%
-1.28ms - +8.36ms		unsure 🔍
-1% - +1%
-4.24ms - +5.60ms
tip-of-tree
tip-of-tree		707.07ms - 713.15msunsure 🔍
-1% - +0%
-8.36ms - +1.28ms		-unsure 🔍
-1% - +0%
-7.27ms - +1.54ms
previous-release
previous-release		709.78ms - 716.16msunsure 🔍
-1% - +1%
-5.60ms - +4.24ms		unsure 🔍
-0% - +1%
-1.54ms - +7.27ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
709.05ms - 714.90ms-unsure 🔍
-1% - +0%
-4.58ms - +3.44ms		unsure 🔍
-1% - +0%
-5.24ms - +3.15ms
tip-of-tree
tip-of-tree		709.81ms - 715.29msunsure 🔍
-0% - +1%
-3.44ms - +4.58ms		-unsure 🔍
-1% - +1%
-4.54ms - +3.59ms
previous-release
previous-release		710.02ms - 716.03msunsure 🔍
-0% - +1%
-3.15ms - +5.24ms		unsure 🔍
-1% - +1%
-3.59ms - +4.54ms		-

tachometer-reporter-action v2 for Benchmarks

AndrewJakubowicz
AndrewJakubowicz approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@augustjk augustjk merged commit 7421e1b into main Jul 17, 2023
@augustjk augustjk deleted the gen-react-syntax branch July 17, 2023 22:42
@lit-robot lit-robot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@augustjk @AndrewJakubowicz