Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[infra] improve error message for test:common #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewJakubowicz merged 4 commits into from
Jul 31, 2023
Merged

[infra] improve error message for test:common #4059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d7eed5
provide a better error message for relative imports in tests
AndrewJakubowicz Jul 31, 2023
7ef947a
Reword error
AndrewJakubowicz Jul 31, 2023
13c04a2
add empty changeset
AndrewJakubowicz Jul 31, 2023
1a6f172
add red cross to make the comment stand out
AndrewJakubowicz Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/ninety-moons-fail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
19 changes: 16 additions & 3 deletions packages/tests/src/web-test-runner.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,9 @@ const config: TestRunnerConfig = {
*
* The most common way to get an error here is to have a relative import in
* a /test/ module (e.g. `import '../lit-element.js'`). A bare module should
* instead always be used in test modules (e.g. `import
* '../lit-element.js'`). The bare module is necessary, even for imports
* from the same package, so that export conditions take effect.
* instead always be used in test modules (e.g. `import 'lit-element'`). The
* bare module is necessary, even for imports from the same package, so that
* export conditions take effect.
*/
function devVsProdSourcesChecker(context, next) {
if (mode === 'dev') {
Expand All @@ -248,6 +248,19 @@ const config: TestRunnerConfig = {
!context.url.includes('/development/test/')
) {
console.log('Unexpected dev request in prod mode:', context.url);
const refererHeader = context.req.headers['referer'];
if (refererHeader) {
// Try and extract the <filename>_test.js from the referer.
const maybeTestFile = /[\w-]*_test\.js/.exec(refererHeader)?.[0];
if (maybeTestFile) {
console.log(
`❌ There may be a relative import in '${maybeTestFile}' which ` +
`is resolving to '${context.url}'. Ensure the import is a bare module. ` +
'Reproduce locally with: ' +
'`MODE=prod npm run test:common -w @lit-internal/tests`'
);
}
}
context.response.status = 403;
return;
}
Expand Down