Fix dependencies to use stable instead of pre-release vesrions #4306

augustjk · 2023-10-18T22:37:40Z

Affected packages:

'@lit-labs/gen-wrapper-vue': patch
'@lit/reactive-element': patch
'@lit-labs/testing': patch
'@lit-labs/nextjs': patch
'lit-element': patch

These packages still had -pre versions as production dependencies seemingly missed by changeset during release. Did them separately from #4300 as these would require a version bump so downstream users don't install the prerelease versions.

@lit-labs/testing was also missed from #4299 in upping the version range.

changeset-bot · 2023-10-18T22:37:44Z

🦋 Changeset detected

Latest commit: 9a99998

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@lit-labs/testing	Patch
@lit-labs/gen-wrapper-vue	Patch
@lit/reactive-element	Patch
@lit-labs/nextjs	Patch
lit-element	Patch
@lit-examples/nextjs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-10-18T22:37:56Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -13% - +3% (-2.64ms - +0.72ms)
^{this-change vs tip-of-tree}

render

this-change: 84.17ms - 87.29ms
this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +7% (-1.66ms - +2.67ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +0% (-4.03ms - +0.32ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-3.33ms - +1.76ms)
^{this-change vs tip-of-tree}

update

this-change: 966.28ms - 983.34ms
this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +4% (-7.11ms - +3.43ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +2% (-7.15ms - +2.84ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-12.48ms - +12.50ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 954.75ms - 972.67ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-14.21ms - +15.67ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 118.0.5993.70
Sample size: 50
Built by: Benchmarks #5688
Commit: 9a99998

render

Version	Avg time	vs
	84.17ms - 87.29ms	-

update

Version	Avg time	vs
	966.28ms - 983.34ms	-

update-reflect

Version	Avg time	vs
	954.75ms - 972.67ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 118.0.5993.70
Sample size: 30
Built by: Benchmarks #5688
Commit: 9a99998

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	36.56ms - 39.66ms	-	unsure 🔍 -4% - +7% -1.66ms - +2.67ms	unsure 🔍 -4% - +6% -1.61ms - +2.43ms
tip-of-tree tip-of-tree	36.09ms - 39.11ms	unsure 🔍 -7% - +4% -2.67ms - +1.66ms	-	unsure 🔍 -6% - +5% -2.09ms - +1.89ms
previous-release previous-release	36.41ms - 38.99ms	unsure 🔍 -6% - +4% -2.43ms - +1.61ms	unsure 🔍 -5% - +6% -1.89ms - +2.09ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	75.63ms - 82.93ms	-	unsure 🔍 -9% - +4% -7.11ms - +3.43ms	unsure 🔍 -6% - +6% -4.54ms - +4.73ms
tip-of-tree tip-of-tree	77.31ms - 84.93ms	unsure 🔍 -4% - +9% -3.43ms - +7.11ms	-	unsure 🔍 -4% - +9% -2.82ms - +6.69ms
previous-release previous-release	76.33ms - 82.04ms	unsure 🔍 -6% - +6% -4.73ms - +4.54ms	unsure 🔍 -8% - +3% -6.69ms - +2.82ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.85ms - 20.42ms	-	unsure 🔍 -13% - +3% -2.64ms - +0.72ms	unsure 🔍 -20% - +1% -4.65ms - +0.51ms
tip-of-tree tip-of-tree	19.12ms - 22.08ms	unsure 🔍 -4% - +14% -0.72ms - +2.64ms	-	unsure 🔍 -18% - +8% -3.98ms - +1.75ms
previous-release previous-release	19.25ms - 24.17ms	unsure 🔍 -3% - +24% -0.51ms - +4.65ms	unsure 🔍 -9% - +20% -1.75ms - +3.98ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 118.0.5993.70
Sample size: 50
Built by: Benchmarks #5688
Commit: 9a99998

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	58.65ms - 61.10ms	-	unsure 🔍 -6% - +0% -4.03ms - +0.32ms	unsure 🔍 -2% - +4% -1.27ms - +2.15ms
tip-of-tree tip-of-tree	59.93ms - 63.53ms	unsure 🔍 -1% - +7% -0.32ms - +4.03ms	-	slower ❌ 0% - 8% 0.13ms - 4.45ms
previous-release previous-release	58.24ms - 60.64ms	unsure 🔍 -4% - +2% -2.15ms - +1.27ms	faster ✔ 0% - 7% 0.13ms - 4.45ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	127.60ms - 134.22ms	-	unsure 🔍 -5% - +2% -7.15ms - +2.84ms	unsure 🔍 -3% - +5% -3.49ms - +6.01ms
tip-of-tree tip-of-tree	129.33ms - 136.80ms	unsure 🔍 -2% - +5% -2.84ms - +7.15ms	-	unsure 🔍 -1% - +7% -1.64ms - +8.48ms
previous-release previous-release	126.24ms - 133.05ms	unsure 🔍 -5% - +3% -6.01ms - +3.49ms	unsure 🔍 -6% - +1% -8.48ms - +1.64ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 118.0.5993.70
Sample size: 50
Built by: Benchmarks #5688
Commit: 9a99998

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	60.51ms - 63.73ms	-	unsure 🔍 -5% - +3% -3.33ms - +1.76ms	unsure 🔍 -5% - +2% -3.12ms - +1.55ms
tip-of-tree tip-of-tree	60.93ms - 64.88ms	unsure 🔍 -3% - +5% -1.76ms - +3.33ms	-	unsure 🔍 -4% - +4% -2.60ms - +2.60ms
previous-release previous-release	61.21ms - 64.60ms	unsure 🔍 -3% - +5% -1.55ms - +3.12ms	unsure 🔍 -4% - +4% -2.60ms - +2.60ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	982.63ms - 1000.09ms	-	unsure 🔍 -1% - +1% -12.48ms - +12.50ms	unsure 🔍 -1% - +2% -7.38ms - +18.30ms
tip-of-tree tip-of-tree	982.42ms - 1000.29ms	unsure 🔍 -1% - +1% -12.50ms - +12.48ms	-	unsure 🔍 -1% - +2% -7.53ms - +18.44ms
previous-release previous-release	976.48ms - 995.32ms	unsure 🔍 -2% - +1% -18.30ms - +7.38ms	unsure 🔍 -2% - +1% -18.44ms - +7.53ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	989.20ms - 1013.18ms	-	unsure 🔍 -1% - +2% -14.21ms - +15.67ms	unsure 🔍 -1% - +2% -14.45ms - +16.70ms
tip-of-tree tip-of-tree	991.55ms - 1009.37ms	unsure 🔍 -2% - +1% -15.67ms - +14.21ms	-	unsure 🔍 -1% - +1% -12.96ms - +13.74ms
previous-release previous-release	990.13ms - 1010.01ms	unsure 🔍 -2% - +1% -16.70ms - +14.45ms	unsure 🔍 -1% - +1% -13.74ms - +12.96ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2023-10-18T22:39:25Z

The size of lit-html.js and lit-core.min.js are as expected.

augustjk · 2023-10-18T22:42:21Z

Edited to add 'lit-element' too.

Now the only outstanding packages that need a pass are labs/ssr and related ones like labs/eleventy-plugin-lit, labs/ssr-client, labs/ssr-dom-shim.

augustjk added 3 commits October 18, 2023 15:25

Fix deps to use stable instead of pre versions

1be2419

Add changeset

1cdb113

Separate changeset for testing for accepting lit 2

2be3a7a

augustjk requested review from AndrewJakubowicz, justinfagnani and rictic October 18, 2023 22:37

augustjk requested a review from kevinpschaaf as a code owner October 18, 2023 22:37

rictic approved these changes Oct 18, 2023

View reviewed changes

Also fix 'lit-element' package

9a99998

AndrewJakubowicz approved these changes Oct 18, 2023

View reviewed changes

augustjk merged commit c28ebba into main Oct 18, 2023

augustjk deleted the fix-pre-deps branch October 18, 2023 23:38

This was referenced Oct 27, 2023

Version Packages #4338

Closed

Version Packages #4341

Merged

CxsLucyfer mentioned this pull request Jan 29, 2024

[Snyk] Upgrade @lit/localize-tools from 0.6.3 to 0.7.1 CxsLucyfer/lit#3

Open

Fix dependencies to use stable instead of pre-release vesrions #4306

Fix dependencies to use stable instead of pre-release vesrions #4306

Uh oh!

Conversation

augustjk commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Oct 18, 2023

Uh oh!

augustjk commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

augustjk commented Oct 18, 2023 •

edited

Loading

changeset-bot bot commented Oct 18, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023 •

edited

Loading