[labs/ssr-client] Avoid nullish logical assignment in hydrate-lit-html #4312

augustjk · 2023-10-20T00:46:56Z

While swc did fix this upstream it's not released yet and I don't know how long it takes for that to make it into Next.js's version of swc.

It seems like a tiny lift for us to add this to make it work now.

changeset-bot · 2023-10-20T00:47:01Z

🦋 Changeset detected

Latest commit: 0153dd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/ssr-client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/labs/ssr-client/src/lib/hydrate-lit-html.ts

Co-authored-by: Peter Burns <[email protected]>

AndrewJakubowicz

Nice!

github-actions · 2023-10-20T04:00:24Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +5% (-1.42ms - +1.01ms)
^{this-change vs tip-of-tree}

render

this-change: 76.55ms - 79.44ms
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +8% (-1.07ms - +2.74ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.63ms - +1.86ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +5% (-0.55ms - +2.52ms)
^{this-change vs tip-of-tree}

update

this-change: 872.31ms - 890.40ms
this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +0% (-5.80ms - +0.42ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-2.98ms - +4.07ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-3.38ms - +21.66ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 851.40ms - 867.99ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-13.36ms - +10.04ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 118.0.5993.70
Sample size: 50
Built by: Benchmarks #5700
Commit: 0153dd0

render

Version	Avg time	vs
	76.55ms - 79.44ms	-

update

Version	Avg time	vs
	872.31ms - 890.40ms	-

update-reflect

Version	Avg time	vs
	851.40ms - 867.99ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 118.0.5993.70
Sample size: 30
Built by: Benchmarks #5700
Commit: 0153dd0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	33.97ms - 36.36ms	-	unsure 🔍 -3% - +8% -1.07ms - +2.74ms	unsure 🔍 -0% - +11% +0.04ms - +3.75ms
tip-of-tree tip-of-tree	32.85ms - 35.81ms	unsure 🔍 -8% - +3% -2.74ms - +1.07ms	-	unsure 🔍 -3% - +9% -0.99ms - +3.11ms
previous-release previous-release	31.85ms - 34.69ms	faster ✔ 0% - 11% 0.04ms - 3.75ms	unsure 🔍 -9% - +3% -3.11ms - +0.99ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	72.37ms - 76.65ms	-	unsure 🔍 -7% - +0% -5.80ms - +0.42ms	unsure 🔍 -9% - +0% -7.39ms - +0.40ms
tip-of-tree tip-of-tree	74.94ms - 79.45ms	unsure 🔍 -1% - +8% -0.42ms - +5.80ms	-	unsure 🔍 -6% - +4% -4.77ms - +3.15ms
previous-release previous-release	74.75ms - 81.26ms	unsure 🔍 -1% - +10% -0.40ms - +7.39ms	unsure 🔍 -4% - +6% -3.15ms - +4.77ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	19.88ms - 21.69ms	-	unsure 🔍 -7% - +5% -1.42ms - +1.01ms	unsure 🔍 -8% - +5% -1.76ms - +1.02ms
tip-of-tree tip-of-tree	20.18ms - 21.80ms	unsure 🔍 -5% - +7% -1.01ms - +1.42ms	-	unsure 🔍 -7% - +6% -1.50ms - +1.17ms
previous-release previous-release	20.09ms - 22.22ms	unsure 🔍 -5% - +9% -1.02ms - +1.76ms	unsure 🔍 -6% - +7% -1.17ms - +1.50ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 118.0.5993.70
Sample size: 50
Built by: Benchmarks #5700
Commit: 0153dd0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	59.42ms - 61.88ms	-	unsure 🔍 -3% - +3% -1.63ms - +1.86ms	unsure 🔍 -4% - +5% -2.54ms - +2.82ms
tip-of-tree tip-of-tree	59.30ms - 61.78ms	unsure 🔍 -3% - +3% -1.86ms - +1.63ms	-	unsure 🔍 -4% - +4% -2.66ms - +2.72ms
previous-release previous-release	58.12ms - 62.90ms	unsure 🔍 -5% - +4% -2.82ms - +2.54ms	unsure 🔍 -4% - +4% -2.72ms - +2.66ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	136.15ms - 141.63ms	-	unsure 🔍 -2% - +3% -2.98ms - +4.07ms	unsure 🔍 -1% - +4% -1.52ms - +5.85ms
tip-of-tree tip-of-tree	136.12ms - 140.56ms	unsure 🔍 -3% - +2% -4.07ms - +2.98ms	-	unsure 🔍 -1% - +4% -1.70ms - +4.94ms
previous-release previous-release	134.26ms - 139.19ms	unsure 🔍 -4% - +1% -5.85ms - +1.52ms	unsure 🔍 -4% - +1% -4.94ms - +1.70ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 118.0.5993.70
Sample size: 50
Built by: Benchmarks #5700
Commit: 0153dd0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.28ms - 56.50ms	-	unsure 🔍 -1% - +5% -0.55ms - +2.52ms	unsure 🔍 -4% - +2% -1.99ms - +1.07ms
tip-of-tree tip-of-tree	53.34ms - 55.47ms	unsure 🔍 -5% - +1% -2.52ms - +0.55ms	-	unsure 🔍 -5% - +0% -2.94ms - +0.06ms
previous-release previous-release	54.79ms - 56.91ms	unsure 🔍 -2% - +4% -1.07ms - +1.99ms	unsure 🔍 -0% - +5% -0.06ms - +2.94ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	914.49ms - 933.28ms	-	unsure 🔍 -0% - +2% -3.38ms - +21.66ms	unsure 🔍 -2% - +1% -16.71ms - +11.71ms
tip-of-tree tip-of-tree	906.48ms - 923.02ms	unsure 🔍 -2% - +0% -21.66ms - +3.38ms	-	unsure 🔍 -3% - +0% -25.14ms - +1.85ms
previous-release previous-release	915.72ms - 937.06ms	unsure 🔍 -1% - +2% -11.71ms - +16.71ms	unsure 🔍 -0% - +3% -1.85ms - +25.14ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	898.66ms - 914.97ms	-	unsure 🔍 -1% - +1% -13.36ms - +10.04ms	unsure 🔍 -1% - +1% -12.02ms - +12.48ms
tip-of-tree tip-of-tree	900.09ms - 916.86ms	unsure 🔍 -1% - +1% -10.04ms - +13.36ms	-	unsure 🔍 -1% - +2% -10.52ms - +14.30ms
previous-release previous-release	897.44ms - 915.73ms	unsure 🔍 -1% - +1% -12.48ms - +12.02ms	unsure 🔍 -2% - +1% -14.30ms - +10.52ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2023-10-20T04:02:08Z

The size of lit-html.js and lit-core.min.js are as expected.

augustjk added 2 commits October 19, 2023 17:32

Avoid nullish logical assignment for root part

8681a95

Add changeset

ab978c5

augustjk requested review from AndrewJakubowicz, justinfagnani and rictic October 20, 2023 00:46

augustjk requested a review from kevinpschaaf as a code owner October 20, 2023 00:46

rictic approved these changes Oct 20, 2023

View reviewed changes

packages/labs/ssr-client/src/lib/hydrate-lit-html.ts Outdated Show resolved Hide resolved

Update packages/labs/ssr-client/src/lib/hydrate-lit-html.ts

0153dd0

Co-authored-by: Peter Burns <[email protected]>

AndrewJakubowicz approved these changes Oct 20, 2023

View reviewed changes

augustjk merged commit 2618273 into main Oct 20, 2023

augustjk deleted the ssr-client-hydrate branch October 20, 2023 20:38

This was referenced Oct 27, 2023

Version Packages #4338

Closed

Version Packages #4341

Merged

CxsLucyfer mentioned this pull request Jan 29, 2024

[Snyk] Upgrade @lit/localize-tools from 0.6.3 to 0.7.1 CxsLucyfer/lit#3

Open

[labs/ssr-client] Avoid nullish logical assignment in hydrate-lit-html #4312

[labs/ssr-client] Avoid nullish logical assignment in hydrate-lit-html #4312

Uh oh!

Conversation

augustjk commented Oct 20, 2023

Uh oh!

changeset-bot bot commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

AndrewJakubowicz left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading