Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/ssr-client] Avoid nullish logical assignment in hydrate-lit-html #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
augustjk merged 3 commits into from
Oct 20, 2023
Merged

[labs/ssr-client] Avoid nullish logical assignment in hydrate-lit-html #4312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8681a95
Avoid nullish logical assignment for root part
augustjk Oct 20, 2023
ab978c5
Add changeset
augustjk Oct 20, 2023
0153dd0
Update packages/labs/ssr-client/src/lib/hydrate-lit-html.ts
augustjk Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-otters-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lit-labs/ssr-client': patch
---

Avoid nullish logical assignment in hydrate-lit-html which some minification process would not handle correctly. Fixes hydration errors in Next.js production bundles.
7 changes: 6 additions & 1 deletion packages/labs/ssr-client/src/lib/hydrate-lit-html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,12 @@ export const hydrate = (
}
// Create a new ChildPart and push it onto the stack
currentChildPart = openChildPart(rootValue, marker, stack, options);
rootPart ??= currentChildPart;
// Using nullish logical assignment below can cause next.js's swc to move
// the `openChildPart()` call above behind the nullish check.
// See https://github.com/lit/lit/issues/4289
if (rootPart === undefined) {
rootPart = currentChildPart;
}
rootPartMarker ??= marker;
} else if (markerText.startsWith('lit-node')) {
// Create and hydrate attribute parts into the current ChildPart on the
Expand Down