Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lit-labs/ssr-dom-shim] fix toggleAttribute clearing prior values if force is true #4494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 2 commits into from
Jan 12, 2024
Merged

[lit-labs/ssr-dom-shim] fix toggleAttribute clearing prior values if force is true #4494

AndrewJakubowicz merged 2 commits into from
Jan 12, 2024

Conversation

@AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Jan 12, 2024

This addresses the bug pointed out by @justinfagnani in #4493 (comment)

A new unit test ensures the bug is covered.
Changeset is empty since this will be covered by the changeset adding toggleAttribute.

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: ca8a672

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-0.60ms - +0.31ms)
    this-change vs tip-of-tree

render

  • this-change: 47.69ms - 49.57ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +1% (-1.01ms - +0.22ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.78ms - +0.59ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: slower ❌ 0% - 4% (0.03ms - 1.28ms)
    this-change vs tip-of-tree

update

  • this-change: 491.28ms - 494.74ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +2% (-3.11ms - +0.87ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-1.19ms - +0.85ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-7.44ms - +9.31ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 495.36ms - 498.10ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-5.26ms - +11.00ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
47.69ms - 49.57ms-

update

VersionAvg timevs
491.28ms - 494.74ms-

update-reflect

VersionAvg timevs
495.36ms - 498.10ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.15ms - 19.02ms-unsure 🔍
-5% - +1%
-1.01ms - +0.22ms		unsure 🔍
-6% - +1%
-1.05ms - +0.20ms
tip-of-tree
tip-of-tree		18.54ms - 19.42msunsure 🔍
-1% - +5%
-0.22ms - +1.01ms		-unsure 🔍
-3% - +3%
-0.66ms - +0.60ms
previous-release
previous-release		18.56ms - 19.47msunsure 🔍
-1% - +6%
-0.20ms - +1.05ms		unsure 🔍
-3% - +3%
-0.60ms - +0.66ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.95ms - 40.56ms-unsure 🔍
-8% - +2%
-3.11ms - +0.87ms		unsure 🔍
-10% - +1%
-4.00ms - +0.34ms
tip-of-tree
tip-of-tree		38.87ms - 41.88msunsure 🔍
-2% - +8%
-0.87ms - +3.11ms		-unsure 🔍
-7% - +4%
-3.01ms - +1.59ms
previous-release
previous-release		39.34ms - 42.82msunsure 🔍
-1% - +10%
-0.34ms - +4.00ms		unsure 🔍
-4% - +7%
-1.59ms - +3.01ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.93ms - 11.50ms-unsure 🔍
-5% - +3%
-0.60ms - +0.31ms		unsure 🔍
-8% - +1%
-0.97ms - +0.08ms
tip-of-tree
tip-of-tree		11.01ms - 11.72msunsure 🔍
-3% - +5%
-0.31ms - +0.60ms		-unsure 🔍
-7% - +2%
-0.86ms - +0.27ms
previous-release
previous-release		11.22ms - 12.10msunsure 🔍
-1% - +9%
-0.08ms - +0.97ms		unsure 🔍
-2% - +8%
-0.27ms - +0.86ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
33.17ms - 34.17ms-unsure 🔍
-2% - +2%
-0.78ms - +0.59ms		unsure 🔍
-3% - +2%
-0.98ms - +0.59ms
tip-of-tree
tip-of-tree		33.29ms - 34.24msunsure 🔍
-2% - +2%
-0.59ms - +0.78ms		-unsure 🔍
-3% - +2%
-0.87ms - +0.66ms
previous-release
previous-release		33.26ms - 34.47msunsure 🔍
-2% - +3%
-0.59ms - +0.98ms		unsure 🔍
-2% - +3%
-0.66ms - +0.87ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
67.72ms - 69.14ms-unsure 🔍
-2% - +1%
-1.19ms - +0.85ms		unsure 🔍
-3% - +1%
-2.02ms - +0.59ms
tip-of-tree
tip-of-tree		67.87ms - 69.34msunsure 🔍
-1% - +2%
-0.85ms - +1.19ms		-unsure 🔍
-3% - +1%
-1.86ms - +0.77ms
previous-release
previous-release		68.05ms - 70.24msunsure 🔍
-1% - +3%
-0.59ms - +2.02ms		unsure 🔍
-1% - +3%
-0.77ms - +1.86ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
33.35ms - 34.36ms-slower ❌
0% - 4%
0.03ms - 1.28ms		unsure 🔍
-1% - +3%
-0.50ms - +0.95ms
tip-of-tree
tip-of-tree		32.83ms - 33.56msfaster ✔
0% - 4%
0.03ms - 1.28ms		-unsure 🔍
-3% - +1%
-1.06ms - +0.20ms
previous-release
previous-release		33.11ms - 34.14msunsure 🔍
-3% - +1%
-0.95ms - +0.50ms		unsure 🔍
-1% - +3%
-0.20ms - +1.06ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
504.88ms - 516.63ms-unsure 🔍
-1% - +2%
-7.44ms - +9.31ms		unsure 🔍
-2% - +2%
-8.19ms - +8.80ms
tip-of-tree
tip-of-tree		503.85ms - 515.80msunsure 🔍
-2% - +1%
-9.31ms - +7.44ms		-unsure 🔍
-2% - +2%
-9.19ms - +7.94ms
previous-release
previous-release		504.31ms - 516.59msunsure 🔍
-2% - +2%
-8.80ms - +8.19ms		unsure 🔍
-2% - +2%
-7.94ms - +9.19ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
512.04ms - 524.52ms-unsure 🔍
-1% - +2%
-5.26ms - +11.00ms		unsure 🔍
-1% - +2%
-7.53ms - +10.45ms
tip-of-tree
tip-of-tree		510.20ms - 520.62msunsure 🔍
-2% - +1%
-11.00ms - +5.26ms		-unsure 🔍
-2% - +1%
-9.71ms - +6.89ms
previous-release
previous-release		510.35ms - 523.29msunsure 🔍
-2% - +1%
-10.45ms - +7.53ms		unsure 🔍
-1% - +2%
-6.89ms - +9.71ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024

The size of lit-html.js and lit-core.min.js are as expected.

@AndrewJakubowicz AndrewJakubowicz mentioned this pull request Jan 12, 2024
Merged
augustjk
augustjk approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @justinfagnani for catching this.

@AndrewJakubowicz AndrewJakubowicz merged commit 546d75d into main Jan 12, 2024
@AndrewJakubowicz AndrewJakubowicz deleted the fix-toggle-attribute branch January 12, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

@rictic rictic Awaiting requested review from rictic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewJakubowicz @augustjk