Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[lit-labs/ssr-dom-shim] fix toggleAttribute clearing prior values if force is true #4494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewJakubowicz merged 2 commits into from
Jan 12, 2024
Merged

[lit-labs/ssr-dom-shim] fix toggleAttribute clearing prior values if force is true #4494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10fbbc2
fix toggleAttribute bug where force cleared attribute value
AndrewJakubowicz Jan 12, 2024
ca8a672
add empty changeset since this is a new unreleased feature
AndrewJakubowicz Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/funny-camels-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
25 changes: 18 additions & 7 deletions packages/labs/ssr-dom-shim/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,26 @@ const ElementShim = class Element {
attributesForElement(this).delete(name);
}
toggleAttribute(name: string, force?: boolean): boolean {
if (force === undefined) {
force = !this.hasAttribute(name);
}
if (force) {
this.setAttribute(name, '');
// Steps reference https://dom.spec.whatwg.org/#dom-element-toggleattribute
if (this.hasAttribute(name)) {
// Step 5
if (force === undefined || !force) {
this.removeAttribute(name);
return false;
}
} else {
this.removeAttribute(name);
// Step 4
if (force === undefined || force) {
// Step 4.1
this.setAttribute(name, '');
return true;
} else {
// Step 4.2
return false;
}
}
return force;
// Step 6
return true;
}
hasAttribute(name: string) {
return attributesForElement(this).has(name);
Expand Down
7 changes: 7 additions & 0 deletions packages/labs/ssr-dom-shim/src/test/element-shim_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ test('toggleAttribute accepts an optional force parameter', () => {
assert.ok(shimmedEl.hasAttribute('potato'));
});

test('toggleAttribute retains a previously set value if force is true', () => {
const shimmedEl = new HTMLElement();
shimmedEl.setAttribute('foo', 'bar');
assert.ok(shimmedEl.toggleAttribute('foo', true));
assert.equal(shimmedEl.getAttribute('foo'), 'bar');
});

test('setAttribute silently casts values to a string', () => {
const shimmedEl = new HTMLElement();
// It is possible to pass any value to `setAttribute`, and we
Expand Down