Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/testing] Fix DSD feature detection and use setHTMLUnsafe for parsing #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 2 commits into from
Feb 7, 2024
Merged

[labs/testing] Fix DSD feature detection and use setHTMLUnsafe for parsing #4541

justinfagnani merged 2 commits into from
Feb 7, 2024

Conversation

@augustjk
Copy link
Member

@augustjk augustjk commented Feb 6, 2024

Fixes #4539

Confirmed this works by running test with latest webkit which has DSD and setHTMLUnsafe support.

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: 31c181a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-0.62ms - +0.39ms)
    this-change vs tip-of-tree

render

  • this-change: 46.80ms - 48.80ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +5% (-0.41ms - +0.86ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.47ms - +0.96ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +4% (-0.01ms - +1.22ms)
    this-change vs tip-of-tree

update

  • this-change: 530.36ms - 539.56ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +5% (-3.20ms - +2.08ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.86ms - +2.23ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +0% (-8.09ms - +2.62ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 532.30ms - 541.91ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.79ms - +6.03ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
46.80ms - 48.80ms-

update

VersionAvg timevs
530.36ms - 539.56ms-

update-reflect

VersionAvg timevs
532.30ms - 541.91ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.40ms - 19.32ms-unsure 🔍
-2% - +5%
-0.41ms - +0.86ms		unsure 🔍
-5% - +2%
-0.92ms - +0.39ms
tip-of-tree
tip-of-tree		18.20ms - 19.08msunsure 🔍
-5% - +2%
-0.86ms - +0.41ms		-unsure 🔍
-6% - +1%
-1.13ms - +0.15ms
previous-release
previous-release		18.66ms - 19.59msunsure 🔍
-2% - +5%
-0.39ms - +0.92ms		unsure 🔍
-1% - +6%
-0.15ms - +1.13ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
39.89ms - 43.61ms-unsure 🔍
-8% - +5%
-3.20ms - +2.08ms		unsure 🔍
-10% - +2%
-4.44ms - +1.02ms
tip-of-tree
tip-of-tree		40.44ms - 44.18msunsure 🔍
-5% - +8%
-2.08ms - +3.20ms		-unsure 🔍
-9% - +4%
-3.89ms - +1.59ms
previous-release
previous-release		41.46ms - 45.46msunsure 🔍
-3% - +11%
-1.02ms - +4.44ms		unsure 🔍
-4% - +9%
-1.59ms - +3.89ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.88ms - 11.60ms-unsure 🔍
-5% - +3%
-0.62ms - +0.39ms		unsure 🔍
-6% - +3%
-0.70ms - +0.40ms
tip-of-tree
tip-of-tree		11.00ms - 11.71msunsure 🔍
-4% - +6%
-0.39ms - +0.62ms		-unsure 🔍
-5% - +4%
-0.59ms - +0.51ms
previous-release
previous-release		10.97ms - 11.81msunsure 🔍
-4% - +6%
-0.40ms - +0.70ms		unsure 🔍
-5% - +5%
-0.51ms - +0.59ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
33.78ms - 34.79ms-unsure 🔍
-1% - +3%
-0.47ms - +0.96ms		unsure 🔍
-0% - +4%
-0.14ms - +1.25ms
tip-of-tree
tip-of-tree		33.53ms - 34.55msunsure 🔍
-3% - +1%
-0.96ms - +0.47ms		-unsure 🔍
-1% - +3%
-0.39ms - +1.01ms
previous-release
previous-release		33.25ms - 34.21msunsure 🔍
-4% - +0%
-1.25ms - +0.14ms		unsure 🔍
-3% - +1%
-1.01ms - +0.39ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
73.10ms - 75.81ms-unsure 🔍
-3% - +3%
-1.86ms - +2.23ms		unsure 🔍
-3% - +2%
-2.24ms - +1.52ms
tip-of-tree
tip-of-tree		72.74ms - 75.80msunsure 🔍
-3% - +2%
-2.23ms - +1.86ms		-unsure 🔍
-3% - +2%
-2.55ms - +1.46ms
previous-release
previous-release		73.51ms - 76.11msunsure 🔍
-2% - +3%
-1.52ms - +2.24ms		unsure 🔍
-2% - +3%
-1.46ms - +2.55ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
31.58ms - 32.53ms-unsure 🔍
-0% - +4%
-0.01ms - +1.22ms		unsure 🔍
-2% - +2%
-0.65ms - +0.69ms
tip-of-tree
tip-of-tree		31.05ms - 31.84msunsure 🔍
-4% - +0%
-1.22ms - +0.01ms		-unsure 🔍
-4% - +0%
-1.20ms - +0.02ms
previous-release
previous-release		31.56ms - 32.51msunsure 🔍
-2% - +2%
-0.69ms - +0.65ms		unsure 🔍
-0% - +4%
-0.02ms - +1.20ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
516.73ms - 524.08ms-unsure 🔍
-2% - +0%
-8.09ms - +2.62ms		unsure 🔍
-2% - +1%
-8.45ms - +3.72ms
tip-of-tree
tip-of-tree		519.24ms - 527.04msunsure 🔍
-1% - +2%
-2.62ms - +8.09ms		-unsure 🔍
-1% - +1%
-5.86ms - +6.59ms
previous-release
previous-release		517.92ms - 527.62msunsure 🔍
-1% - +2%
-3.72ms - +8.45ms		unsure 🔍
-1% - +1%
-6.59ms - +5.86ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
524.09ms - 533.40ms-unsure 🔍
-1% - +1%
-6.79ms - +6.03ms		unsure 🔍
-1% - +1%
-5.14ms - +7.39ms
tip-of-tree
tip-of-tree		524.72ms - 533.54msunsure 🔍
-1% - +1%
-6.03ms - +6.79ms		-unsure 🔍
-1% - +1%
-4.59ms - +7.59ms
previous-release
previous-release		523.42ms - 531.82msunsure 🔍
-1% - +1%
-7.39ms - +5.14ms		unsure 🔍
-1% - +1%
-7.59ms - +4.59ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani justinfagnani merged commit d128391 into main Feb 7, 2024
@justinfagnani justinfagnani deleted the testing-dsd-parse branch February 7, 2024 17:48
@lit-robot lit-robot mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[labs/testing] Use setHTMLUnsafe() for parsing declarative shadow DOM

2 participants

@augustjk @justinfagnani