Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/testing] Fix DSD feature detection and use setHTMLUnsafe for parsing #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinfagnani merged 2 commits into from
Feb 7, 2024
Merged

[labs/testing] Fix DSD feature detection and use setHTMLUnsafe for parsing #4541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4905079
Use setHTMLUnsafe
augustjk Feb 5, 2024
31c181a
Add changeset
augustjk Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-rats-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@lit-labs/testing': patch
---

Fix declarative shadowroot detection and parsing to use the correct spec behavior.
36 changes: 11 additions & 25 deletions packages/labs/testing/src/lib/fixtures/ssr-fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,11 @@ import type {LitElement, TemplateResult} from 'lit';
import type {FixtureOptions, SsrFixtureOptions} from './fixture-options.js';
import type {Payload} from '../lit-ssr-plugin.js';

// Enhance DOMParser's parseFromString method to include `includeShadowRoots`
// option for browsers that support declarative shadow DOM as proposed in
// https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#mitigation.
// Enhance `Element` with method that parses declarative shadow DOM
// See https://github.com/whatwg/html/pull/9538
declare global {
interface DOMParser {
parseFromString(
string: string,
type: DOMParserSupportedType,
option: {includeShadowRoots: boolean}
): Document;
interface Element {
setHTMLUnsafe(html: string): void;
}
}

Expand Down Expand Up @@ -77,22 +72,13 @@ export async function ssrFixture<T extends HTMLElement>(

const container = createContainer();

if (HTMLTemplateElement.prototype.hasOwnProperty('shadowRoot')) {
// Browser natively supports declarative shadowroot.
// Shadowroots are only parsed and attached during initial HTML parsing.
// innerHTML will not work and must use DOMParser.
// See https://web.dev/declarative-shadow-dom/#parser-only
const fragment = new DOMParser().parseFromString(
// DOMParser could separate opening lit-part comment from others as it
// selectively places some elements into <body>. Wrapping the entire
// rendered content in <body> preserves order.
'<body>' + rendered + '</body>',
'text/html',
{
includeShadowRoots: true,
}
);
container.replaceChildren(...Array.from(fragment.body.childNodes));
if (
HTMLTemplateElement.prototype.hasOwnProperty('shadowRootMode') &&
'setHTMLUnsafe' in Element.prototype
) {
// Browser natively supports Declarative Shadow DOM and `setHTMLUnsafe()`
// which is needed for DSD to be parsed and attached.
container.setHTMLUnsafe(rendered);
} else {
// Utilize ponyfill
container.innerHTML = rendered;
Expand Down