Thanks to visit codestin.com
Credit goes to github.com

Skip to content

style(copilot-instructions): add a copilot instructions file #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
e111077 merged 2 commits into from
May 19, 2025
Merged

style(copilot-instructions): add a copilot instructions file #4970

e111077 merged 2 commits into from
May 19, 2025

Conversation

@e111077
Copy link
Contributor

@e111077 e111077 commented Apr 11, 2025 •
edited
Loading

Added copilot instructions. Please bikeshed, copilot instructions docs recommend a very short instructions

Parent Children
#4991 #4971, #4990

@google-cla
Copy link

google-cla bot commented Apr 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -11% - +9% (-1.48ms - +1.15ms)
    this-change vs tip-of-tree

render

  • this-change: 48.19ms - 63.97ms
  • this-change, tip-of-tree, previous-release: faster ✔ 1% - 9% (0.20ms - 1.76ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.66ms - +0.39ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -24% - +26% (-13.88ms - +14.54ms)
    this-change vs tip-of-tree

update

  • this-change: 485.56ms - 494.53ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +3% (-2.96ms - +1.34ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-1.37ms - +2.19ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-3.83ms - +7.78ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 472.57ms - 478.26ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-3.01ms - +7.43ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
48.19ms - 63.97ms-

update

VersionAvg timevs
485.56ms - 494.53ms-

update-reflect

VersionAvg timevs
472.57ms - 478.26ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.76ms - 19.63ms-faster ✔
1% - 9%
0.20ms - 1.76ms		unsure 🔍
-6% - +1%
-1.10ms - +0.11ms
tip-of-tree
tip-of-tree		19.53ms - 20.83msslower ❌
1% - 9%
0.20ms - 1.76ms		-unsure 🔍
-2% - +6%
-0.29ms - +1.26ms
previous-release
previous-release		19.27ms - 20.11msunsure 🔍
-1% - +6%
-0.11ms - +1.10ms		unsure 🔍
-6% - +1%
-1.26ms - +0.29ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.56ms - 40.16ms-unsure 🔍
-7% - +3%
-2.96ms - +1.34ms		unsure 🔍
-5% - +4%
-2.01ms - +1.53ms
tip-of-tree
tip-of-tree		37.96ms - 41.38msunsure 🔍
-3% - +8%
-1.34ms - +2.96ms		-unsure 🔍
-4% - +7%
-1.52ms - +2.66ms
previous-release
previous-release		37.90ms - 40.30msunsure 🔍
-4% - +5%
-1.53ms - +2.01ms		unsure 🔍
-7% - +4%
-2.66ms - +1.52ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.24ms - 14.09ms-unsure 🔍
-11% - +9%
-1.48ms - +1.15ms		unsure 🔍
-7% - +14%
-0.87ms - +1.81ms
tip-of-tree
tip-of-tree		12.39ms - 14.26msunsure 🔍
-9% - +11%
-1.15ms - +1.48ms		-unsure 🔍
-6% - +16%
-0.71ms - +1.97ms
previous-release
previous-release		11.73ms - 13.66msunsure 🔍
-14% - +6%
-1.81ms - +0.87ms		unsure 🔍
-15% - +5%
-1.97ms - +0.71ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.98ms - 35.57ms-unsure 🔍
-2% - +1%
-0.66ms - +0.39ms		faster ✔
0% - 3%
0.01ms - 1.07ms
tip-of-tree
tip-of-tree		34.97ms - 35.84msunsure 🔍
-1% - +2%
-0.39ms - +0.66ms		-unsure 🔍
-3% - +1%
-1.02ms - +0.21ms
previous-release
previous-release		35.38ms - 36.25msslower ❌
0% - 3%
0.01ms - 1.07ms		unsure 🔍
-1% - +3%
-0.21ms - +1.02ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
74.93ms - 77.23ms-unsure 🔍
-2% - +3%
-1.37ms - +2.19ms		unsure 🔍
-4% - +1%
-3.23ms - +0.59ms
tip-of-tree
tip-of-tree		74.30ms - 77.03msunsure 🔍
-3% - +2%
-2.19ms - +1.37ms		-unsure 🔍
-5% - +0%
-3.78ms - +0.32ms
previous-release
previous-release		75.87ms - 78.93msunsure 🔍
-1% - +4%
-0.59ms - +3.23ms		unsure 🔍
-0% - +5%
-0.32ms - +3.78ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
46.99ms - 67.39ms-unsure 🔍
-24% - +26%
-13.88ms - +14.54ms		unsure 🔍
-12% - +48%
-4.86ms - +22.18ms
tip-of-tree
tip-of-tree		46.97ms - 66.76msunsure 🔍
-25% - +24%
-14.54ms - +13.88ms		-unsure 🔍
-12% - +47%
-4.96ms - +21.63ms
previous-release
previous-release		39.66ms - 57.41msunsure 🔍
-37% - +7%
-22.18ms - +4.86ms		unsure 🔍
-36% - +7%
-21.63ms - +4.96ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
483.07ms - 491.43ms-unsure 🔍
-1% - +2%
-3.83ms - +7.78ms		unsure 🔍
-2% - +1%
-7.94ms - +3.92ms
tip-of-tree
tip-of-tree		481.26ms - 489.30msunsure 🔍
-2% - +1%
-7.78ms - +3.83ms		-unsure 🔍
-2% - +0%
-9.80ms - +1.83ms
previous-release
previous-release		485.06ms - 493.46msunsure 🔍
-1% - +2%
-3.92ms - +7.94ms		unsure 🔍
-0% - +2%
-1.83ms - +9.80ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
493.04ms - 500.59ms-unsure 🔍
-1% - +2%
-3.01ms - +7.43ms		unsure 🔍
-1% - +1%
-5.03ms - +5.54ms
tip-of-tree
tip-of-tree		491.00ms - 498.21msunsure 🔍
-1% - +1%
-7.43ms - +3.01ms		-unsure 🔍
-1% - +1%
-7.12ms - +3.21ms
previous-release
previous-release		492.86ms - 500.26msunsure 🔍
-1% - +1%
-5.54ms - +5.03ms		unsure 🔍
-1% - +1%
-3.21ms - +7.12ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@e111077 e111077 force-pushed the copilot-instructions branch from 843cdd1 to 2e2b4ee Compare April 11, 2025 07:16
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 83e7f0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@e111077 e111077 mentioned this pull request Apr 11, 2025
Merged
@e111077 e111077 marked this pull request as ready for review April 11, 2025 07:23
@e111077 e111077 requested a review from kevinpschaaf as a code owner April 11, 2025 07:23
@e111077 e111077 requested a review from justinfagnani April 11, 2025 07:24
sorvell
sorvell reviewed May 16, 2025
View reviewed changes
sorvell
sorvell approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally include my suggestion

@e111077 e111077 force-pushed the copilot-instructions branch from 2e2b4ee to 256df49 Compare May 17, 2025 01:58
@e111077 e111077 mentioned this pull request May 17, 2025
Merged
@e111077 e111077 force-pushed the copilot-instructions branch 3 times, most recently from 2213cb5 to a81b2a8 Compare May 17, 2025 02:54
@e111077 e111077 mentioned this pull request May 17, 2025
Merged
@e111077 e111077 changed the base branch from main to fix-release-image-sandbox-issue May 17, 2025 02:55
@e111077 e111077 force-pushed the fix-release-image-sandbox-issue branch from 2917551 to 8a6ec41 Compare May 17, 2025 02:59
@e111077 e111077 force-pushed the copilot-instructions branch from a81b2a8 to 42f84b1 Compare May 17, 2025 02:59
e111077 added 2 commits May 16, 2025 21:13
@e111077
[ci] fix release image sandbox error
713bc4f 
CI is broken based on the kernel used by GH Actions. We are using unbuntu-latest. [See this CI error](https://github.com/lit/lit/actions/runs/15080547701/job/42397010351?pr=4970). Pretty sure we can trust the content we are running so we should be able to just turn the sandbox off since this just generates an image.
@e111077
style(copilot-instructions): add a copilot instructions file
83e7f0b
@e111077 e111077 force-pushed the fix-release-image-sandbox-issue branch from 8a6ec41 to 713bc4f Compare May 17, 2025 04:13
@e111077 e111077 force-pushed the copilot-instructions branch from 42f84b1 to 83e7f0b Compare May 17, 2025 04:13
@e111077
Copy link
Contributor Author

e111077 commented May 17, 2025

CI was failing because of two unrelated issues. See #4991 before we can merge this one

Base automatically changed from fix-release-image-sandbox-issue to main May 19, 2025 06:08
@e111077 e111077 merged commit 5fac502 into main May 19, 2025
7 checks passed
@e111077 e111077 deleted the copilot-instructions branch May 19, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorvell sorvell sorvell approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e111077 @sorvell