Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(ai): add symlinks to copy AI instructions for more formats #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
e111077 merged 1 commit into from
Jun 5, 2025
Merged

feat(ai): add symlinks to copy AI instructions for more formats #4971

e111077 merged 1 commit into from
Jun 5, 2025

Conversation

@e111077
Copy link
Contributor

@e111077 e111077 commented Apr 11, 2025 •
edited
Loading

Add a symlinks that link to the copilot instructions for

Parent Children
#4970

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b8330e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: slower ❌ 4% - 24% (0.51ms - 2.68ms)
    this-change vs tip-of-tree

render

  • this-change: 44.22ms - 57.11ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +1% (-1.11ms - +0.30ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-0.53ms - +0.40ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -28% - +19% (-17.03ms - +11.95ms)
    this-change vs tip-of-tree

update

  • this-change: 487.06ms - 492.34ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +8% (-0.67ms - +3.03ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.41ms - +1.62ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-5.66ms - +7.80ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 472.34ms - 475.17ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.65ms - +5.94ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
44.22ms - 57.11ms-

update

VersionAvg timevs
487.06ms - 492.34ms-

update-reflect

VersionAvg timevs
472.34ms - 475.17ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.97ms - 19.91ms-unsure 🔍
-6% - +1%
-1.11ms - +0.30ms		unsure 🔍
-4% - +3%
-0.75ms - +0.56ms
tip-of-tree
tip-of-tree		19.32ms - 20.37msunsure 🔍
-2% - +6%
-0.30ms - +1.11ms		-unsure 🔍
-2% - +5%
-0.38ms - +1.01ms
previous-release
previous-release		19.08ms - 19.99msunsure 🔍
-3% - +4%
-0.56ms - +0.75ms		unsure 🔍
-5% - +2%
-1.01ms - +0.38ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.92ms - 39.84ms-unsure 🔍
-2% - +8%
-0.67ms - +3.03ms		unsure 🔍
-5% - +5%
-1.99ms - +2.01ms
tip-of-tree
tip-of-tree		36.07ms - 38.33msunsure 🔍
-8% - +2%
-3.03ms - +0.67ms		-unsure 🔍
-8% - +1%
-2.94ms - +0.60ms
previous-release
previous-release		37.00ms - 39.73msunsure 🔍
-5% - +5%
-2.01ms - +1.99ms		unsure 🔍
-2% - +8%
-0.60ms - +2.94ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.30ms - 14.10ms-slower ❌
4% - 24%
0.51ms - 2.68ms		unsure 🔍
-12% - +8%
-1.58ms - +1.03ms
tip-of-tree
tip-of-tree		11.00ms - 12.22msfaster ✔
4% - 20%
0.51ms - 2.68ms		-faster ✔
6% - 21%
0.74ms - 3.00ms
previous-release
previous-release		12.53ms - 14.43msunsure 🔍
-8% - +12%
-1.03ms - +1.58ms		slower ❌
6% - 26%
0.74ms - 3.00ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.82ms - 36.45ms-unsure 🔍
-1% - +1%
-0.53ms - +0.40ms		unsure 🔍
-2% - +1%
-0.58ms - +0.37ms
tip-of-tree
tip-of-tree		35.86ms - 36.55msunsure 🔍
-1% - +1%
-0.40ms - +0.53ms		-unsure 🔍
-1% - +1%
-0.53ms - +0.45ms
previous-release
previous-release		35.89ms - 36.59msunsure 🔍
-1% - +2%
-0.37ms - +0.58ms		unsure 🔍
-1% - +1%
-0.45ms - +0.53ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
74.78ms - 76.98ms-unsure 🔍
-2% - +2%
-1.41ms - +1.62ms		unsure 🔍
-1% - +3%
-0.74ms - +2.06ms
tip-of-tree
tip-of-tree		74.73ms - 76.82msunsure 🔍
-2% - +2%
-1.62ms - +1.41ms		-unsure 🔍
-1% - +3%
-0.80ms - +1.91ms
previous-release
previous-release		74.35ms - 76.08msunsure 🔍
-3% - +1%
-2.06ms - +0.74ms		unsure 🔍
-3% - +1%
-1.91ms - +0.80ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
47.13ms - 67.67ms-unsure 🔍
-28% - +19%
-17.03ms - +11.95ms		unsure 🔍
-23% - +29%
-12.69ms - +15.90ms
tip-of-tree
tip-of-tree		49.72ms - 70.16msunsure 🔍
-21% - +30%
-11.95ms - +17.03ms		-unsure 🔍
-19% - +34%
-10.12ms - +18.41ms
previous-release
previous-release		45.85ms - 65.75msunsure 🔍
-27% - +22%
-15.90ms - +12.69ms		unsure 🔍
-30% - +16%
-18.41ms - +10.12ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
491.07ms - 499.69ms-unsure 🔍
-1% - +2%
-5.66ms - +7.80ms		unsure 🔍
-2% - +1%
-7.88ms - +4.48ms
tip-of-tree
tip-of-tree		489.14ms - 499.48msunsure 🔍
-2% - +1%
-7.80ms - +5.66ms		-unsure 🔍
-2% - +1%
-9.58ms - +4.03ms
previous-release
previous-release		492.66ms - 501.51msunsure 🔍
-1% - +2%
-4.48ms - +7.88ms		unsure 🔍
-1% - +2%
-4.03ms - +9.58ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
501.21ms - 510.93ms-unsure 🔍
-1% - +1%
-6.65ms - +5.94ms		unsure 🔍
-1% - +1%
-7.12ms - +5.60ms
tip-of-tree
tip-of-tree		502.43ms - 510.42msunsure 🔍
-1% - +1%
-5.94ms - +6.65ms		-unsure 🔍
-1% - +1%
-6.13ms - +5.33ms
previous-release
previous-release		502.72ms - 510.94msunsure 🔍
-1% - +1%
-5.60ms - +7.12ms		unsure 🔍
-1% - +1%
-5.33ms - +6.13ms		-

tachometer-reporter-action v2 for Benchmarks

@e111077 e111077 mentioned this pull request Apr 11, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@e111077 e111077 changed the title build: add postinstall to copy AI instructions for more formats feat(ai): add symlinks to copy AI instructions for more formats Apr 12, 2025
@e111077 e111077 force-pushed the copy-instructions branch from 3812fd4 to 0c4726d Compare April 12, 2025 03:51
@e111077 e111077 force-pushed the copilot-instructions branch from 2e2b4ee to 256df49 Compare May 17, 2025 01:58
@e111077 e111077 force-pushed the copy-instructions branch from 0c4726d to cb6ef7e Compare May 17, 2025 01:58
@e111077 e111077 force-pushed the copilot-instructions branch from 256df49 to ef0d45c Compare May 17, 2025 02:03
@e111077 e111077 force-pushed the copy-instructions branch from cb6ef7e to 7d73d70 Compare May 17, 2025 02:03
@e111077 e111077 force-pushed the copilot-instructions branch from ef0d45c to 2213cb5 Compare May 17, 2025 02:04
@e111077 e111077 force-pushed the copy-instructions branch from 7d73d70 to 0099b73 Compare May 17, 2025 02:04
@e111077 e111077 marked this pull request as ready for review May 17, 2025 02:05
@e111077 e111077 requested a review from kevinpschaaf as a code owner May 17, 2025 02:05
@e111077 e111077 requested review from justinfagnani and sorvell May 17, 2025 02:05
@e111077 e111077 force-pushed the copilot-instructions branch from 2213cb5 to a81b2a8 Compare May 17, 2025 02:54
@e111077 e111077 force-pushed the copy-instructions branch from 0099b73 to 24388ec Compare May 17, 2025 02:54
@e111077 e111077 force-pushed the copilot-instructions branch from a81b2a8 to 42f84b1 Compare May 17, 2025 02:59
@e111077 e111077 force-pushed the copy-instructions branch from 24388ec to 1c10005 Compare May 17, 2025 02:59
@e111077 e111077 force-pushed the copilot-instructions branch from 42f84b1 to 83e7f0b Compare May 17, 2025 04:13
@e111077 e111077 force-pushed the copy-instructions branch from 1c10005 to 2b49aa0 Compare May 17, 2025 04:14
Base automatically changed from copilot-instructions to main May 19, 2025 06:09
rictic
rictic approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenAI Codex looks for an AGENTS.md file anywhere in the repo. Google Jules doesn't yet have a file that it looks for, as far as I can tell.

Hopefully someone standardizes this soon lol.

@e111077
Copy link
Contributor Author

e111077 commented Jun 5, 2025

I'll add an AGENTS.md here before merging?

@e111077 e111077 force-pushed the copy-instructions branch from 2b49aa0 to 4456955 Compare June 5, 2025 18:07
@e111077 e111077 enabled auto-merge (rebase) June 5, 2025 18:08
@e111077 e111077 disabled auto-merge June 5, 2025 18:08
@e111077 e111077 force-pushed the copy-instructions branch from 4456955 to 6501d33 Compare June 5, 2025 18:09
@e111077
Copy link
Contributor Author

e111077 commented Jun 5, 2025

Added AGENTS.md, rebased

@e111077 e111077 enabled auto-merge (rebase) June 5, 2025 18:10
@e111077 e111077 force-pushed the copy-instructions branch from 6501d33 to b8330e1 Compare June 5, 2025 18:33
@e111077 e111077 merged commit fbda6d7 into main Jun 5, 2025
7 of 9 checks passed
@e111077 e111077 deleted the copy-instructions branch June 5, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@sorvell sorvell Awaiting requested review from sorvell

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e111077 @rictic