Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/vscode-extension] Load the tsserver-plugin in the extension #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 1 commit into from
Aug 21, 2025
Merged

[labs/vscode-extension] Load the tsserver-plugin in the extension #5048

justinfagnani merged 1 commit into from
Aug 21, 2025

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Aug 21, 2025

The diagnostics don't always kick in automatically, but if you switch files, open a log, etc., they will.

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025

🦋 Changeset detected

Latest commit: 694bb9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +6% (-0.58ms - +0.69ms)
    this-change vs tip-of-tree

render

  • this-change: 41.43ms - 49.62ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +3% (-0.71ms - +0.67ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.74ms - +0.70ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -31% - +17% (-17.15ms - +9.51ms)
    this-change vs tip-of-tree

update

  • this-change: 459.47ms - 464.98ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +3% (-2.97ms - +1.23ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-1.91ms - +0.96ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-0.65ms - +10.11ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 447.71ms - 453.27ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-5.25ms - +5.59ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
41.43ms - 49.62ms-

update

VersionAvg timevs
459.47ms - 464.98ms-

update-reflect

VersionAvg timevs
447.71ms - 453.27ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.16ms - 20.00ms-unsure 🔍
-4% - +3%
-0.71ms - +0.67ms		unsure 🔍
-4% - +3%
-0.76ms - +0.65ms
tip-of-tree
tip-of-tree		19.04ms - 20.16msunsure 🔍
-3% - +4%
-0.67ms - +0.71ms		-unsure 🔍
-4% - +4%
-0.83ms - +0.77ms
previous-release
previous-release		19.06ms - 20.21msunsure 🔍
-3% - +4%
-0.65ms - +0.76ms		unsure 🔍
-4% - +4%
-0.77ms - +0.83ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.46ms - 38.91ms-unsure 🔍
-8% - +3%
-2.97ms - +1.23ms		unsure 🔍
-8% - +4%
-3.17ms - +1.52ms
tip-of-tree
tip-of-tree		36.86ms - 39.25msunsure 🔍
-3% - +8%
-1.23ms - +2.97ms		-unsure 🔍
-5% - +5%
-1.95ms - +2.03ms
previous-release
previous-release		36.42ms - 39.61msunsure 🔍
-4% - +9%
-1.52ms - +3.17ms		unsure 🔍
-5% - +5%
-2.03ms - +1.95ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.04ms - 12.00ms-unsure 🔍
-5% - +6%
-0.58ms - +0.69ms		unsure 🔍
-9% - +2%
-1.07ms - +0.28ms
tip-of-tree
tip-of-tree		11.04ms - 11.88msunsure 🔍
-6% - +5%
-0.69ms - +0.58ms		-unsure 🔍
-9% - +1%
-1.08ms - +0.18ms
previous-release
previous-release		11.44ms - 12.39msunsure 🔍
-3% - +9%
-0.28ms - +1.07ms		unsure 🔍
-2% - +10%
-0.18ms - +1.08ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.39ms - 36.38ms-unsure 🔍
-2% - +2%
-0.74ms - +0.70ms		unsure 🔍
-1% - +3%
-0.42ms - +0.94ms
tip-of-tree
tip-of-tree		35.38ms - 36.43msunsure 🔍
-2% - +2%
-0.70ms - +0.74ms		-unsure 🔍
-1% - +3%
-0.42ms - +0.99ms
previous-release
previous-release		35.16ms - 36.09msunsure 🔍
-3% - +1%
-0.94ms - +0.42ms		unsure 🔍
-3% - +1%
-0.99ms - +0.42ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
72.14ms - 74.06ms-unsure 🔍
-3% - +1%
-1.91ms - +0.96ms		unsure 🔍
-2% - +3%
-1.11ms - +2.13ms
tip-of-tree
tip-of-tree		72.51ms - 74.64msunsure 🔍
-1% - +3%
-0.96ms - +1.91ms		-unsure 🔍
-1% - +4%
-0.69ms - +2.67ms
previous-release
previous-release		71.28ms - 73.89msunsure 🔍
-3% - +2%
-2.13ms - +1.11ms		unsure 🔍
-4% - +1%
-2.67ms - +0.69ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
40.78ms - 59.17ms-unsure 🔍
-31% - +17%
-17.15ms - +9.51ms		unsure 🔍
-25% - +28%
-12.37ms - +13.64ms
tip-of-tree
tip-of-tree		44.15ms - 63.45msunsure 🔍
-20% - +35%
-9.51ms - +17.15ms		-unsure 🔍
-19% - +37%
-8.88ms - +17.78ms
previous-release
previous-release		40.15ms - 58.54msunsure 🔍
-27% - +25%
-13.64ms - +12.37ms		unsure 🔍
-32% - +15%
-17.78ms - +8.88ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
463.47ms - 470.59ms-unsure 🔍
-0% - +2%
-0.65ms - +10.11ms		unsure 🔍
-1% - +1%
-3.65ms - +6.69ms
tip-of-tree
tip-of-tree		458.26ms - 466.34msunsure 🔍
-2% - +0%
-10.11ms - +0.65ms		-unsure 🔍
-2% - +0%
-8.72ms - +2.30ms
previous-release
previous-release		461.76ms - 469.26msunsure 🔍
-1% - +1%
-6.69ms - +3.65ms		unsure 🔍
-1% - +2%
-2.30ms - +8.72ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
470.06ms - 477.14ms-unsure 🔍
-1% - +1%
-5.25ms - +5.59ms		unsure 🔍
-1% - +1%
-5.16ms - +4.55ms
tip-of-tree
tip-of-tree		469.32ms - 477.54msunsure 🔍
-1% - +1%
-5.59ms - +5.25ms		-unsure 🔍
-1% - +1%
-5.76ms - +4.81ms
previous-release
previous-release		470.59ms - 477.23msunsure 🔍
-1% - +1%
-4.55ms - +5.16ms		unsure 🔍
-1% - +1%
-4.81ms - +5.76ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025

The size of lit-html.js and lit-core.min.js are as expected.

kevinpschaaf
kevinpschaaf reviewed Aug 21, 2025
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after #5049 lands

@justinfagnani justinfagnani merged commit 8ec73de into tools-hackathon Aug 21, 2025
6 of 7 checks passed
@justinfagnani justinfagnani deleted the vscode-tsserver branch August 21, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf left review comments

@rictic rictic Awaiting requested review from rictic

@e111077 e111077 Awaiting requested review from e111077

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @kevinpschaaf