Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/vue] fix the generator causing test failures #5049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 1 commit into from
Aug 21, 2025
Merged

[labs/vue] fix the generator causing test failures #5049

justinfagnani merged 1 commit into from
Aug 21, 2025

Conversation

@e111077
Copy link
Contributor

@e111077 e111077 commented Aug 21, 2025 •
edited
Loading

seems that we needed to replace process

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 769adac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/gen-wrapper-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +13% (-0.16ms - +1.54ms)
    this-change vs tip-of-tree

render

  • this-change: 43.69ms - 55.70ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +6% (-0.27ms - +1.13ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +1% (-1.32ms - +0.34ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -24% - +30% (-12.00ms - +15.11ms)
    this-change vs tip-of-tree

update

  • this-change: 486.21ms - 492.68ms
  • this-change, tip-of-tree, previous-release: slower ❌ 5% - 16% (2.03ms - 6.11ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-1.31ms - +1.71ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.70ms - +5.41ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 474.52ms - 478.66ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.38ms - +3.35ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
43.69ms - 55.70ms-

update

VersionAvg timevs
486.21ms - 492.68ms-

update-reflect

VersionAvg timevs
474.52ms - 478.66ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.82ms - 20.68ms-unsure 🔍
-1% - +6%
-0.27ms - +1.13ms		unsure 🔍
-5% - +3%
-1.09ms - +0.55ms
tip-of-tree
tip-of-tree		19.27ms - 20.36msunsure 🔍
-6% - +1%
-1.13ms - +0.27ms		-unsure 🔍
-8% - +1%
-1.58ms - +0.19ms
previous-release
previous-release		19.82ms - 21.21msunsure 🔍
-3% - +5%
-0.55ms - +1.09ms		unsure 🔍
-1% - +8%
-0.19ms - +1.58ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
41.63ms - 44.57ms-slower ❌
5% - 16%
2.03ms - 6.11ms		unsure 🔍
-3% - +8%
-1.05ms - +3.48ms
tip-of-tree
tip-of-tree		37.61ms - 40.44msfaster ✔
5% - 14%
2.03ms - 6.11ms		-faster ✔
2% - 12%
0.62ms - 5.10ms
previous-release
previous-release		40.16ms - 43.62msunsure 🔍
-8% - +2%
-3.48ms - +1.05ms		slower ❌
1% - 13%
0.62ms - 5.10ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.29ms - 13.53ms-unsure 🔍
-1% - +13%
-0.16ms - +1.54ms		unsure 🔍
-5% - +8%
-0.61ms - +1.01ms
tip-of-tree
tip-of-tree		11.65ms - 12.79msunsure 🔍
-12% - +1%
-1.54ms - +0.16ms		-unsure 🔍
-10% - +2%
-1.26ms - +0.28ms
previous-release
previous-release		12.19ms - 13.23msunsure 🔍
-8% - +5%
-1.01ms - +0.61ms		unsure 🔍
-2% - +10%
-0.28ms - +1.26ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.19ms - 36.60ms-unsure 🔍
-4% - +1%
-1.32ms - +0.34ms		unsure 🔍
-3% - +2%
-0.92ms - +0.84ms
tip-of-tree
tip-of-tree		35.94ms - 36.83msunsure 🔍
-1% - +4%
-0.34ms - +1.32ms		-unsure 🔍
-1% - +3%
-0.25ms - +1.14ms
previous-release
previous-release		35.41ms - 36.47msunsure 🔍
-2% - +3%
-0.84ms - +0.92ms		unsure 🔍
-3% - +1%
-1.14ms - +0.25ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
76.18ms - 78.67ms-unsure 🔍
-2% - +2%
-1.31ms - +1.71ms		unsure 🔍
-1% - +3%
-0.82ms - +2.66ms
tip-of-tree
tip-of-tree		76.37ms - 78.08msunsure 🔍
-2% - +2%
-1.71ms - +1.31ms		-unsure 🔍
-1% - +3%
-0.76ms - +2.20ms
previous-release
previous-release		75.30ms - 77.72msunsure 🔍
-3% - +1%
-2.66ms - +0.82ms		unsure 🔍
-3% - +1%
-2.20ms - +0.76ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
42.75ms - 62.19ms-unsure 🔍
-24% - +30%
-12.00ms - +15.11ms		unsure 🔍
-33% - +13%
-19.86ms - +8.55ms
tip-of-tree
tip-of-tree		41.47ms - 60.37msunsure 🔍
-28% - +22%
-15.11ms - +12.00ms		-unsure 🔍
-35% - +10%
-21.23ms - +6.81ms
previous-release
previous-release		47.76ms - 68.49msunsure 🔍
-18% - +39%
-8.55ms - +19.86ms		unsure 🔍
-15% - +44%
-6.81ms - +21.23ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
490.30ms - 498.73ms-unsure 🔍
-1% - +1%
-6.70ms - +5.41ms		unsure 🔍
-1% - +1%
-5.77ms - +6.27ms
tip-of-tree
tip-of-tree		490.81ms - 499.50msunsure 🔍
-1% - +1%
-5.41ms - +6.70ms		-unsure 🔍
-1% - +1%
-5.22ms - +7.01ms
previous-release
previous-release		489.96ms - 498.57msunsure 🔍
-1% - +1%
-6.27ms - +5.77ms		unsure 🔍
-1% - +1%
-7.01ms - +5.22ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
497.37ms - 504.35ms-unsure 🔍
-1% - +1%
-6.38ms - +3.35ms		unsure 🔍
-2% - +1%
-8.24ms - +2.71ms
tip-of-tree
tip-of-tree		498.98ms - 505.76msunsure 🔍
-1% - +1%
-3.35ms - +6.38ms		-unsure 🔍
-1% - +1%
-6.67ms - +4.16ms
previous-release
previous-release		499.41ms - 507.84msunsure 🔍
-1% - +2%
-2.71ms - +8.24ms		unsure 🔍
-1% - +1%
-4.16ms - +6.67ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@e111077 e111077 force-pushed the fix-failing-vue-tests branch from 25b4dde to 99c6037 Compare August 21, 2025 21:40
@e111077 e111077 marked this pull request as ready for review August 21, 2025 21:40
@e111077 e111077 requested a review from kevinpschaaf as a code owner August 21, 2025 21:40
@kevinpschaaf kevinpschaaf mentioned this pull request Aug 21, 2025
Merged
@e111077 e111077 force-pushed the fix-failing-vue-tests branch from 99c6037 to 4f458d8 Compare August 21, 2025 21:48
@e111077
[labs/vue] fix the generator causing test failures
769adac 
seems that there are some constants that need to be replaced
@e111077 e111077 force-pushed the fix-failing-vue-tests branch from 4f458d8 to 769adac Compare August 21, 2025 21:49
@justinfagnani justinfagnani merged commit 604e930 into main Aug 21, 2025
10 checks passed
@justinfagnani justinfagnani deleted the fix-failing-vue-tests branch August 21, 2025 22:08
@lit-robot lit-robot mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@rictic rictic Awaiting requested review from rictic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e111077 @justinfagnani