Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/analyzer] Adjust attribute source locations in template parser #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 1 commit into from
Aug 22, 2025
Merged

[labs/analyzer] Adjust attribute source locations in template parser #5054

justinfagnani merged 1 commit into from
Aug 22, 2025

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Aug 22, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 72b12d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +8% (-0.30ms - +0.86ms)
    this-change vs tip-of-tree

render

  • this-change: 41.55ms - 51.25ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +0% (-1.52ms - +0.02ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-0.90ms - +0.64ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -25% - +25% (-13.69ms - +13.96ms)
    this-change vs tip-of-tree

update

  • this-change: 442.04ms - 446.69ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +4% (-2.36ms - +1.54ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.45ms - +2.31ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-1.76ms - +6.90ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 429.90ms - 432.03ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +0% (-2.07ms - +2.19ms)
    this-change vs tip-of-tree

Results

⏳ Benchmarks are currently running. Results below are out of date.
this-change

render

VersionAvg timevs
41.55ms - 51.25ms-

update

VersionAvg timevs
442.04ms - 446.69ms-

update-reflect

VersionAvg timevs
429.90ms - 432.03ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.68ms - 19.70ms-unsure 🔍
-8% - +0%
-1.52ms - +0.02ms		unsure 🔍
-5% - +2%
-0.97ms - +0.48ms
tip-of-tree
tip-of-tree		19.37ms - 20.51msunsure 🔍
-0% - +8%
-0.02ms - +1.52ms		-unsure 🔍
-1% - +7%
-0.27ms - +1.28ms
previous-release
previous-release		18.92ms - 19.96msunsure 🔍
-3% - +5%
-0.48ms - +0.97ms		unsure 🔍
-6% - +1%
-1.28ms - +0.27ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.92ms - 38.01ms-unsure 🔍
-6% - +4%
-2.36ms - +1.54ms		unsure 🔍
-6% - +7%
-2.02ms - +2.39ms
tip-of-tree
tip-of-tree		35.68ms - 38.06msunsure 🔍
-4% - +7%
-1.54ms - +2.36ms		-unsure 🔍
-4% - +7%
-1.38ms - +2.56ms
previous-release
previous-release		34.71ms - 37.85msunsure 🔍
-7% - +6%
-2.39ms - +2.02ms		unsure 🔍
-7% - +4%
-2.56ms - +1.38ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.01ms - 11.89ms-unsure 🔍
-3% - +8%
-0.30ms - +0.86ms		unsure 🔍
-3% - +8%
-0.31ms - +0.91ms
tip-of-tree
tip-of-tree		10.79ms - 11.55msunsure 🔍
-7% - +3%
-0.86ms - +0.30ms		-unsure 🔍
-5% - +5%
-0.55ms - +0.59ms
previous-release
previous-release		10.72ms - 11.57msunsure 🔍
-8% - +3%
-0.91ms - +0.31ms		unsure 🔍
-5% - +5%
-0.59ms - +0.55ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.47ms - 35.59ms-unsure 🔍
-3% - +2%
-0.90ms - +0.64ms		unsure 🔍
-1% - +3%
-0.46ms - +1.03ms
tip-of-tree
tip-of-tree		34.63ms - 35.68msunsure 🔍
-2% - +3%
-0.64ms - +0.90ms		-unsure 🔍
-1% - +3%
-0.31ms - +1.14ms
previous-release
previous-release		34.24ms - 35.24msunsure 🔍
-3% - +1%
-1.03ms - +0.46ms		unsure 🔍
-3% - +1%
-1.14ms - +0.31ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
69.40ms - 71.72ms-unsure 🔍
-1% - +3%
-0.45ms - +2.31ms		unsure 🔍
-0% - +4%
-0.21ms - +2.69ms
tip-of-tree
tip-of-tree		68.88ms - 70.38msunsure 🔍
-3% - +1%
-2.31ms - +0.45ms		-unsure 🔍
-1% - +2%
-0.84ms - +1.46ms
previous-release
previous-release		68.44ms - 70.19msunsure 🔍
-4% - +0%
-2.69ms - +0.21ms		unsure 🔍
-2% - +1%
-1.46ms - +0.84ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
46.01ms - 65.48ms-unsure 🔍
-25% - +25%
-13.69ms - +13.96ms		unsure 🔍
-25% - +24%
-14.12ms - +13.33ms
tip-of-tree
tip-of-tree		45.80ms - 65.43msunsure 🔍
-25% - +25%
-13.96ms - +13.69ms		-unsure 🔍
-25% - +23%
-14.30ms - +13.25ms
previous-release
previous-release		46.47ms - 65.81msunsure 🔍
-24% - +25%
-13.33ms - +14.12ms		unsure 🔍
-24% - +26%
-13.25ms - +14.30ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
447.09ms - 453.18ms-unsure 🔍
-0% - +2%
-1.76ms - +6.90ms		unsure 🔍
-1% - +1%
-3.45ms - +4.94ms
tip-of-tree
tip-of-tree		444.48ms - 450.64msunsure 🔍
-2% - +0%
-6.90ms - +1.76ms		-unsure 🔍
-1% - +1%
-6.04ms - +2.40ms
previous-release
previous-release		446.50ms - 452.27msunsure 🔍
-1% - +1%
-4.94ms - +3.45ms		unsure 🔍
-1% - +1%
-2.40ms - +6.04ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
451.40ms - 454.24ms-unsure 🔍
-0% - +0%
-2.07ms - +2.19ms		unsure 🔍
-1% - +0%
-3.29ms - +0.53ms
tip-of-tree
tip-of-tree		451.17ms - 454.34msunsure 🔍
-0% - +0%
-2.19ms - +2.07ms		-unsure 🔍
-1% - +0%
-3.47ms - +0.60ms
previous-release
previous-release		452.92ms - 455.47msunsure 🔍
-0% - +1%
-0.53ms - +3.29ms		unsure 🔍
-0% - +1%
-0.60ms - +3.47ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

The size of lit-html.js and lit-core.min.js are as expected.

Base automatically changed from vscode-syntax to tools-hackathon August 22, 2025 00:10
@justinfagnani justinfagnani force-pushed the template-attribute-positions branch from 756ebe6 to 72b12d5 Compare August 22, 2025 00:12
@justinfagnani justinfagnani merged commit 429895c into tools-hackathon Aug 22, 2025
7 checks passed
@justinfagnani justinfagnani deleted the template-attribute-positions branch August 22, 2025 00:13
@justinfagnani justinfagnani mentioned this pull request Aug 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @kevinpschaaf