Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[labs/analyzer] Adjust attribute source locations in template parser #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinfagnani merged 2 commits into from
Aug 22, 2025
Merged

[labs/analyzer] Adjust attribute source locations in template parser #5057

justinfagnani merged 2 commits into from
Aug 22, 2025

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Aug 22, 2025

This is the same as #5054, just based on main.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 181f3bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/analyzer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +4% (-0.88ms - +0.51ms)
    this-change vs tip-of-tree

render

  • this-change: 44.89ms - 58.92ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +7% (-0.15ms - +1.33ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.77ms - +0.50ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -20% - +29% (-11.41ms - +16.77ms)
    this-change vs tip-of-tree

update

  • this-change: 441.83ms - 448.25ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +11% (-0.19ms - +3.92ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.92ms - +1.27ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-3.88ms - +4.03ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 429.94ms - 433.24ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.21ms - +2.92ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
44.89ms - 58.92ms-

update

VersionAvg timevs
441.83ms - 448.25ms-

update-reflect

VersionAvg timevs
429.94ms - 433.24ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.19ms - 20.21ms-unsure 🔍
-1% - +7%
-0.15ms - +1.33ms		unsure 🔍
-4% - +4%
-0.82ms - +0.77ms
tip-of-tree
tip-of-tree		18.58ms - 19.64msunsure 🔍
-7% - +1%
-1.33ms - +0.15ms		-unsure 🔍
-7% - +1%
-1.42ms - +0.19ms
previous-release
previous-release		19.12ms - 20.34msunsure 🔍
-4% - +4%
-0.77ms - +0.82ms		unsure 🔍
-1% - +8%
-0.19ms - +1.42ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.40ms - 39.02ms-unsure 🔍
-1% - +11%
-0.19ms - +3.92ms		unsure 🔍
-2% - +7%
-0.86ms - +2.63ms
tip-of-tree
tip-of-tree		34.26ms - 37.43msunsure 🔍
-10% - +0%
-3.92ms - +0.19ms		-unsure 🔍
-8% - +3%
-2.94ms - +0.98ms
previous-release
previous-release		35.67ms - 37.98msunsure 🔍
-7% - +2%
-2.63ms - +0.86ms		unsure 🔍
-3% - +8%
-0.98ms - +2.94ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.01ms - 12.03ms-unsure 🔍
-7% - +4%
-0.88ms - +0.51ms		unsure 🔍
-6% - +5%
-0.75ms - +0.61ms
tip-of-tree
tip-of-tree		11.23ms - 12.18msunsure 🔍
-4% - +8%
-0.51ms - +0.88ms		-unsure 🔍
-5% - +7%
-0.53ms - +0.76ms
previous-release
previous-release		11.14ms - 12.03msunsure 🔍
-5% - +6%
-0.61ms - +0.75ms		unsure 🔍
-6% - +4%
-0.76ms - +0.53ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.54ms - 35.46ms-unsure 🔍
-2% - +1%
-0.77ms - +0.50ms		unsure 🔍
-2% - +1%
-0.84ms - +0.50ms
tip-of-tree
tip-of-tree		34.70ms - 35.58msunsure 🔍
-1% - +2%
-0.50ms - +0.77ms		-unsure 🔍
-2% - +2%
-0.69ms - +0.63ms
previous-release
previous-release		34.68ms - 35.66msunsure 🔍
-1% - +2%
-0.50ms - +0.84ms		unsure 🔍
-2% - +2%
-0.63ms - +0.69ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
68.17ms - 69.84ms-unsure 🔍
-1% - +2%
-0.92ms - +1.27ms		unsure 🔍
-3% - +1%
-1.90ms - +0.63ms
tip-of-tree
tip-of-tree		68.12ms - 69.54msunsure 🔍
-2% - +1%
-1.27ms - +0.92ms		-unsure 🔍
-3% - +1%
-1.99ms - +0.38ms
previous-release
previous-release		68.69ms - 70.59msunsure 🔍
-1% - +3%
-0.63ms - +1.90ms		unsure 🔍
-1% - +3%
-0.38ms - +1.99ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
51.64ms - 71.62ms-unsure 🔍
-20% - +29%
-11.41ms - +16.77ms		unsure 🔍
-15% - +39%
-7.15ms - +20.67ms
tip-of-tree
tip-of-tree		49.02ms - 68.89msunsure 🔍
-27% - +18%
-16.77ms - +11.41ms		-unsure 🔍
-19% - +34%
-9.79ms - +17.96ms
previous-release
previous-release		45.18ms - 64.55msunsure 🔍
-32% - +10%
-20.67ms - +7.15ms		unsure 🔍
-30% - +16%
-17.96ms - +9.79ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
445.58ms - 451.49ms-unsure 🔍
-1% - +1%
-3.88ms - +4.03ms		unsure 🔍
-2% - +0%
-11.21ms - +1.58ms
tip-of-tree
tip-of-tree		445.83ms - 451.09msunsure 🔍
-1% - +1%
-4.03ms - +3.88ms		-unsure 🔍
-2% - +0%
-11.15ms - +1.36ms
previous-release
previous-release		447.68ms - 459.03msunsure 🔍
-0% - +3%
-1.58ms - +11.21ms		unsure 🔍
-0% - +2%
-1.36ms - +11.15ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
453.90ms - 458.80ms-unsure 🔍
-1% - +1%
-4.21ms - +2.92ms		unsure 🔍
-1% - +1%
-3.95ms - +2.49ms
tip-of-tree
tip-of-tree		454.40ms - 459.58msunsure 🔍
-1% - +1%
-2.92ms - +4.21ms		-unsure 🔍
-1% - +1%
-3.42ms - +3.24ms
previous-release
previous-release		454.98ms - 459.17msunsure 🔍
-1% - +1%
-2.49ms - +3.95ms		unsure 🔍
-1% - +1%
-3.24ms - +3.42ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani
Copy link
Collaborator Author

justinfagnani commented Aug 22, 2025

Merging this since the other was already approved.

@justinfagnani justinfagnani merged commit 945f5aa into main Aug 22, 2025
10 checks passed
@justinfagnani justinfagnani deleted the template-attribute-positions branch August 22, 2025 20:05
@lit-robot lit-robot mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@justinfagnani