Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add func to get the effective type of a binding expression #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rictic merged 6 commits into from
Aug 21, 2025
Merged

Add func to get the effective type of a binding expression #5052

rictic merged 6 commits into from
Aug 21, 2025

Conversation

@rictic
Copy link
Collaborator

@rictic rictic commented Aug 21, 2025

Introduce the getLitExpressionType function to determine the appropriate type for lit-html binding expressions, including sentinel symbols and directive results.

@rictic rictic requested a review from kevinpschaaf as a code owner August 21, 2025 22:15
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 76909a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/tsserver-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

nop-update

  • this-change, tip-of-tree, previous-release: slower ❌ 1% - 11% (0.16ms - 1.23ms)
    this-change vs tip-of-tree

render

  • this-change: 44.58ms - 57.82ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +6% (-0.58ms - +1.13ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.68ms - +0.72ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: faster ✔ 8% - 45% (2.78ms - 27.93ms)
    this-change vs tip-of-tree

update

  • this-change: 470.68ms - 477.06ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +5% (-2.39ms - +1.88ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-1.22ms - +2.89ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-0.53ms - +8.08ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 464.05ms - 467.52ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-2.92ms - +4.90ms)
    this-change vs tip-of-tree

Results

⏳ Benchmarks are currently running. Results below are out of date.
this-change

render

VersionAvg timevs
44.58ms - 57.82ms-

update

VersionAvg timevs
470.68ms - 477.06ms-

update-reflect

VersionAvg timevs
464.05ms - 467.52ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.35ms - 20.55ms-unsure 🔍
-3% - +6%
-0.58ms - +1.13ms		unsure 🔍
-5% - +4%
-0.91ms - +0.78ms
tip-of-tree
tip-of-tree		19.07ms - 20.29msunsure 🔍
-6% - +3%
-1.13ms - +0.58ms		-unsure 🔍
-6% - +3%
-1.19ms - +0.52ms
previous-release
previous-release		19.42ms - 20.62msunsure 🔍
-4% - +5%
-0.78ms - +0.91ms		unsure 🔍
-3% - +6%
-0.52ms - +1.19ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.64ms - 39.16ms-unsure 🔍
-6% - +5%
-2.39ms - +1.88ms		unsure 🔍
-6% - +6%
-2.37ms - +2.27ms
tip-of-tree
tip-of-tree		36.45ms - 38.86msunsure 🔍
-5% - +6%
-1.88ms - +2.39ms		-unsure 🔍
-5% - +6%
-1.73ms - +2.14ms
previous-release
previous-release		35.94ms - 38.96msunsure 🔍
-6% - +6%
-2.27ms - +2.37ms		unsure 🔍
-6% - +5%
-2.14ms - +1.73ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.59ms - 12.47ms-slower ❌
1% - 11%
0.16ms - 1.23ms		unsure 🔍
-6% - +6%
-0.73ms - +0.72ms
tip-of-tree
tip-of-tree		11.03ms - 11.63msfaster ✔
2% - 10%
0.16ms - 1.23ms		-faster ✔
1% - 11%
0.06ms - 1.35ms
previous-release
previous-release		11.46ms - 12.61msunsure 🔍
-6% - +6%
-0.72ms - +0.73ms		slower ❌
0% - 12%
0.06ms - 1.35ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.89ms - 35.84ms-unsure 🔍
-2% - +2%
-0.68ms - +0.72ms		unsure 🔍
-2% - +2%
-0.87ms - +0.65ms
tip-of-tree
tip-of-tree		34.83ms - 35.86msunsure 🔍
-2% - +2%
-0.72ms - +0.68ms		-unsure 🔍
-3% - +2%
-0.92ms - +0.66ms
previous-release
previous-release		34.88ms - 36.07msunsure 🔍
-2% - +2%
-0.65ms - +0.87ms		unsure 🔍
-2% - +3%
-0.66ms - +0.92ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
72.53ms - 75.58ms-unsure 🔍
-2% - +4%
-1.22ms - +2.89ms		unsure 🔍
-2% - +3%
-1.37ms - +2.47ms
tip-of-tree
tip-of-tree		71.83ms - 74.60msunsure 🔍
-4% - +2%
-2.89ms - +1.22ms		-unsure 🔍
-3% - +2%
-2.09ms - +1.52ms
previous-release
previous-release		72.34ms - 74.67msunsure 🔍
-3% - +2%
-2.47ms - +1.37ms		unsure 🔍
-2% - +3%
-1.52ms - +2.09ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.96ms - 50.43ms-faster ✔
8% - 45%
2.78ms - 27.93ms		faster ✔
9% - 45%
3.22ms - 28.70ms
tip-of-tree
tip-of-tree		48.13ms - 67.97msslower ❌
2% - 70%
2.78ms - 27.93ms		-unsure 🔍
-25% - +23%
-14.78ms - +13.57ms
previous-release
previous-release		48.53ms - 68.78msslower ❌
3% - 72%
3.22ms - 28.70ms		unsure 🔍
-23% - +26%
-13.57ms - +14.78ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
466.92ms - 472.27ms-unsure 🔍
-0% - +2%
-0.53ms - +8.08ms		unsure 🔍
-1% - +1%
-4.70ms - +4.53ms
tip-of-tree
tip-of-tree		462.45ms - 469.19msunsure 🔍
-2% - +0%
-8.08ms - +0.53ms		-unsure 🔍
-2% - +0%
-8.91ms - +1.20ms
previous-release
previous-release		465.91ms - 473.44msunsure 🔍
-1% - +1%
-4.53ms - +4.70ms		unsure 🔍
-0% - +2%
-1.20ms - +8.91ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
473.17ms - 479.01ms-unsure 🔍
-1% - +1%
-2.92ms - +4.90ms		unsure 🔍
-1% - +1%
-4.44ms - +3.38ms
tip-of-tree
tip-of-tree		472.50ms - 477.70msunsure 🔍
-1% - +1%
-4.90ms - +2.92ms		-unsure 🔍
-1% - +0%
-5.20ms - +2.16ms
previous-release
previous-release		474.02ms - 479.22msunsure 🔍
-1% - +1%
-3.38ms - +4.44ms		unsure 🔍
-0% - +1%
-2.16ms - +5.20ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@rictic rictic merged commit a9c864b into tools-hackathon Aug 21, 2025
7 checks passed
@rictic rictic deleted the tools-hackathon-getlitexpressiontype branch August 21, 2025 22:33
@justinfagnani justinfagnani restored the tools-hackathon-getlitexpressiontype branch August 23, 2025 06:50
@justinfagnani justinfagnani mentioned this pull request Aug 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rictic @justinfagnani