[labs/tsserver-plugin] Add func to get the effective type of a binding expression #5062

justinfagnani · 2025-08-23T06:52:48Z

Recreates #5052 onto main.

changeset-bot · 2025-08-23T06:52:53Z

🦋 Changeset detected

Latest commit: a066129

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/tsserver-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-08-23T06:53:02Z

📊 Tachometer Benchmark Results

Summary

nop-update

this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +8% (-0.37ms - +0.87ms)
^{this-change vs tip-of-tree}

render

this-change: 41.79ms - 49.82ms
this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +3% (-1.42ms - +0.72ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-0.63ms - +1.07ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -29% - +21% (-15.26ms - +11.18ms)
^{this-change vs tip-of-tree}

update

this-change: 452.50ms - 462.42ms
this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +7% (-1.46ms - +2.65ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.41ms - +1.79ms)
^{this-change vs tip-of-tree}
this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +0% (-8.67ms - +1.23ms)
^{this-change vs tip-of-tree}

update-reflect

this-change: 437.59ms - 442.55ms
this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.38ms - +3.05ms)
^{this-change vs tip-of-tree}

Results

this-change

Browser: chrome-headless 139.0.0.0
Sample size: 50
Built by: Benchmarks #6923
Commit: a066129

render

Version	Avg time	vs
	41.79ms - 49.82ms	-

update

Version	Avg time	vs
	452.50ms - 462.42ms	-

update-reflect

Version	Avg time	vs
	437.59ms - 442.55ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 139.0.0.0
Sample size: 30
Built by: Benchmarks #6923
Commit: a066129

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	19.32ms - 20.65ms	-	unsure 🔍 -7% - +3% -1.42ms - +0.72ms	unsure 🔍 -4% - +5% -0.83ms - +0.97ms
tip-of-tree tip-of-tree	19.49ms - 21.18ms	unsure 🔍 -4% - +7% -0.72ms - +1.42ms	-	unsure 🔍 -3% - +7% -0.62ms - +1.46ms
previous-release previous-release	19.30ms - 20.52ms	unsure 🔍 -5% - +4% -0.97ms - +0.83ms	unsure 🔍 -7% - +3% -1.46ms - +0.62ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	35.15ms - 37.87ms	-	unsure 🔍 -4% - +7% -1.46ms - +2.65ms	unsure 🔍 -6% - +4% -2.26ms - +1.65ms
tip-of-tree tip-of-tree	34.37ms - 37.45ms	unsure 🔍 -7% - +4% -2.65ms - +1.46ms	-	unsure 🔍 -8% - +3% -2.99ms - +1.18ms
previous-release previous-release	35.41ms - 38.22ms	unsure 🔍 -5% - +6% -1.65ms - +2.26ms	unsure 🔍 -3% - +8% -1.18ms - +2.99ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.23ms - 12.09ms	-	unsure 🔍 -3% - +8% -0.37ms - +0.87ms	unsure 🔍 -3% - +8% -0.32ms - +0.85ms
tip-of-tree tip-of-tree	10.96ms - 11.86ms	unsure 🔍 -7% - +3% -0.87ms - +0.37ms	-	unsure 🔍 -5% - +5% -0.58ms - +0.61ms
previous-release previous-release	11.00ms - 11.78ms	unsure 🔍 -7% - +3% -0.85ms - +0.32ms	unsure 🔍 -5% - +5% -0.61ms - +0.58ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 139.0.0.0
Sample size: 50
Built by: Benchmarks #6923
Commit: a066129

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	34.80ms - 36.13ms	-	unsure 🔍 -2% - +3% -0.63ms - +1.07ms	unsure 🔍 -1% - +3% -0.46ms - +1.16ms
tip-of-tree tip-of-tree	34.71ms - 35.79ms	unsure 🔍 -3% - +2% -1.07ms - +0.63ms	-	unsure 🔍 -2% - +2% -0.57ms - +0.84ms
previous-release previous-release	34.66ms - 35.58ms	unsure 🔍 -3% - +1% -1.16ms - +0.46ms	unsure 🔍 -2% - +2% -0.84ms - +0.57ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.72ms - 72.33ms	-	unsure 🔍 -1% - +3% -0.41ms - +1.79ms	unsure 🔍 -0% - +3% -0.26ms - +1.94ms
tip-of-tree tip-of-tree	70.09ms - 71.58ms	unsure 🔍 -2% - +1% -1.79ms - +0.41ms	-	unsure 🔍 -1% - +2% -0.90ms - +1.21ms
previous-release previous-release	69.93ms - 71.44ms	unsure 🔍 -3% - +0% -1.94ms - +0.26ms	unsure 🔍 -2% - +1% -1.21ms - +0.90ms	-

this-change, tip-of-tree, previous-release

Browser: chrome-headless 139.0.0.0
Sample size: 50
Built by: Benchmarks #6923
Commit: a066129

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	41.07ms - 59.59ms	-	unsure 🔍 -29% - +21% -15.26ms - +11.18ms	unsure 🔍 -33% - +12% -19.28ms - +7.65ms
tip-of-tree tip-of-tree	42.93ms - 61.80ms	unsure 🔍 -23% - +31% -11.18ms - +15.26ms	-	unsure 🔍 -30% - +17% -17.36ms - +9.81ms
previous-release previous-release	46.36ms - 65.91ms	unsure 🔍 -17% - +40% -7.65ms - +19.28ms	unsure 🔍 -20% - +34% -9.81ms - +17.36ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	449.96ms - 455.90ms	-	unsure 🔍 -2% - +0% -8.67ms - +1.23ms	unsure 🔍 -2% - +0% -8.15ms - +1.43ms
tip-of-tree tip-of-tree	452.69ms - 460.62ms	unsure 🔍 -0% - +2% -1.23ms - +8.67ms	-	unsure 🔍 -1% - +1% -5.10ms - +5.82ms
previous-release previous-release	452.54ms - 460.06ms	unsure 🔍 -0% - +2% -1.43ms - +8.15ms	unsure 🔍 -1% - +1% -5.82ms - +5.10ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	454.61ms - 459.49ms	-	unsure 🔍 -1% - +1% -4.38ms - +3.05ms	unsure 🔍 -1% - +0% -5.61ms - +1.59ms
tip-of-tree tip-of-tree	454.91ms - 460.52ms	unsure 🔍 -1% - +1% -3.05ms - +4.38ms	-	unsure 🔍 -1% - +1% -5.20ms - +2.51ms
previous-release previous-release	456.41ms - 461.70ms	unsure 🔍 -0% - +1% -1.59ms - +5.61ms	unsure 🔍 -1% - +1% -2.51ms - +5.20ms	-

_{tachometer-reporter-action v2 for Benchmarks}

github-actions · 2025-08-23T06:54:20Z

The size of lit-html.js and lit-core.min.js are as expected.

rictic and others added 6 commits August 22, 2025 23:51

Initial implementation of getLitExpressionType

a4296bf

Add tests for getLitExpressionType.

540e4c1

Also test type strings

3b9a0c7

Changeset

697ae21

Prettier.

3b1cead

Add todo.

a066129

justinfagnani requested a review from rictic August 23, 2025 06:52

justinfagnani requested a review from kevinpschaaf as a code owner August 23, 2025 06:52

rictic approved these changes Aug 23, 2025

View reviewed changes

justinfagnani merged commit 98e4293 into main Aug 23, 2025
10 checks passed

justinfagnani deleted the tools-hackathon-getlitexpressiontype branch August 23, 2025 16:38

lit-robot mentioned this pull request Dec 18, 2025

Version Packages #5183

Open

[labs/tsserver-plugin] Add func to get the effective type of a binding expression #5062

[labs/tsserver-plugin] Add func to get the effective type of a binding expression #5062

Uh oh!

Conversation

justinfagnani commented Aug 23, 2025

Uh oh!

changeset-bot bot commented Aug 23, 2025

🦋 Changeset detected

Uh oh!

github-actions bot commented Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

update-reflect

Uh oh!

github-actions bot commented Aug 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Aug 23, 2025 •

edited

Loading