Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[infra] Adopt Open JS Code of Conduct #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
justinfagnani wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[infra] Adopt Open JS Code of Conduct #5167

justinfagnani wants to merge 1 commit into from
+78 −36

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Dec 3, 2025

Closes #5133

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

🦋 Changeset detected

Latest commit: 00d0bf6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +6% (-1.23ms - +0.84ms)
    this-change vs tip-of-tree

render

  • this-change: 48.16ms - 61.20ms
  • this-change, tip-of-tree, previous-release: faster ✔ 0% - 8% (0.03ms - 1.63ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.59ms - +0.67ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +1% (-6.05ms - +1.58ms)
    this-change vs tip-of-tree

update

  • this-change: 515.41ms - 523.78ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-2.23ms - +1.40ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +0% (-1.73ms - +0.39ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-3.21ms - +9.37ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 499.78ms - 504.14ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-9.87ms - +2.74ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
48.16ms - 61.20ms-

update

VersionAvg timevs
515.41ms - 523.78ms-

update-reflect

VersionAvg timevs
499.78ms - 504.14ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.31ms - 20.23ms-faster ✔
0% - 8%
0.03ms - 1.63ms		faster ✔
0% - 7%
0.03ms - 1.55ms
tip-of-tree
tip-of-tree		19.94ms - 21.26msslower ❌
0% - 8%
0.03ms - 1.63ms		-unsure 🔍
-4% - +5%
-0.86ms - +0.93ms
previous-release
previous-release		19.96ms - 21.17msslower ❌
0% - 8%
0.03ms - 1.55ms		unsure 🔍
-5% - +4%
-0.93ms - +0.86ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
39.92ms - 42.60ms-unsure 🔍
-5% - +3%
-2.23ms - +1.40ms		faster ✔
1% - 9%
0.44ms - 3.95ms
tip-of-tree
tip-of-tree		40.45ms - 42.90msunsure 🔍
-3% - +5%
-1.40ms - +2.23ms		-faster ✔
0% - 8%
0.11ms - 3.45ms
previous-release
previous-release		42.32ms - 44.60msslower ❌
1% - 10%
0.44ms - 3.95ms		slower ❌
0% - 8%
0.11ms - 3.45ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
13.15ms - 14.61ms-unsure 🔍
-9% - +6%
-1.23ms - +0.84ms		unsure 🔍
-9% - +6%
-1.35ms - +0.86ms
tip-of-tree
tip-of-tree		13.35ms - 14.80msunsure 🔍
-6% - +9%
-0.84ms - +1.23ms		-unsure 🔍
-8% - +7%
-1.15ms - +1.05ms
previous-release
previous-release		13.29ms - 14.95msunsure 🔍
-6% - +10%
-0.86ms - +1.35ms		unsure 🔍
-7% - +8%
-1.05ms - +1.15ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.11ms - 36.98ms-unsure 🔍
-2% - +2%
-0.59ms - +0.67ms		unsure 🔍
-1% - +2%
-0.47ms - +0.83ms
tip-of-tree
tip-of-tree		36.06ms - 36.96msunsure 🔍
-2% - +2%
-0.67ms - +0.59ms		-unsure 🔍
-1% - +2%
-0.52ms - +0.80ms
previous-release
previous-release		35.89ms - 36.85msunsure 🔍
-2% - +1%
-0.83ms - +0.47ms		unsure 🔍
-2% - +1%
-0.80ms - +0.52ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
80.77ms - 82.10ms-unsure 🔍
-2% - +0%
-1.73ms - +0.39ms		unsure 🔍
-3% - +0%
-2.29ms - +0.34ms
tip-of-tree
tip-of-tree		81.28ms - 82.93msunsure 🔍
-0% - +2%
-0.39ms - +1.73ms		-unsure 🔍
-2% - +1%
-1.71ms - +1.09ms
previous-release
previous-release		81.28ms - 83.55msunsure 🔍
-0% - +3%
-0.34ms - +2.29ms		unsure 🔍
-1% - +2%
-1.09ms - +1.71ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
100.56ms - 106.52ms-unsure 🔍
-6% - +1%
-6.05ms - +1.58ms		unsure 🔍
-4% - +2%
-3.80ms - +2.36ms
tip-of-tree
tip-of-tree		103.39ms - 108.16msunsure 🔍
-2% - +6%
-1.58ms - +6.05ms		-unsure 🔍
-1% - +4%
-1.00ms - +4.02ms
previous-release
previous-release		103.47ms - 105.05msunsure 🔍
-2% - +4%
-2.36ms - +3.80ms		unsure 🔍
-4% - +1%
-4.02ms - +1.00ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
467.25ms - 475.93ms-unsure 🔍
-1% - +2%
-3.21ms - +9.37ms		unsure 🔍
-1% - +2%
-3.93ms - +8.06ms
tip-of-tree
tip-of-tree		463.96ms - 473.06msunsure 🔍
-2% - +1%
-9.37ms - +3.21ms		-unsure 🔍
-2% - +1%
-7.17ms - +5.14ms
previous-release
previous-release		465.39ms - 473.66msunsure 🔍
-2% - +1%
-8.06ms - +3.93ms		unsure 🔍
-1% - +2%
-5.14ms - +7.17ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
468.59ms - 476.98ms-unsure 🔍
-2% - +1%
-9.87ms - +2.74ms		unsure 🔍
-1% - +1%
-6.64ms - +5.77ms
tip-of-tree
tip-of-tree		471.64ms - 481.06msunsure 🔍
-1% - +2%
-2.74ms - +9.87ms		-unsure 🔍
-1% - +2%
-3.43ms - +9.69ms
previous-release
previous-release		468.64ms - 477.79msunsure 🔍
-1% - +1%
-5.77ms - +6.64ms		unsure 🔍
-2% - +1%
-9.69ms - +3.43ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

The size of lit-html.js and lit-core.min.js are as expected.

@justinfagnani justinfagnani mentioned this pull request Dec 3, 2025
Closed
kj-powell
kj-powell approved these changes Dec 3, 2025
View reviewed changes
Copy link
Collaborator

@kj-powell kj-powell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you!

kevinpschaaf
kevinpschaaf approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

@kj-powell kj-powell kj-powell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lit - Onboarding] Adopt the OpenJS Foundation Code of Conduct

3 participants

@justinfagnani @kevinpschaaf @kj-powell