[chore] Update lockfiles #2918

augustjk · 2022-05-17T22:35:15Z

Update package-lock files with version bumps that happened in the previous release.
These changes were made by running npm run nuke from the latest commit.

Perhaps we should consider doing something like this changesets/changesets#421 (comment) to automate this.

changeset-bot · 2022-05-17T22:35:17Z

🦋 Changeset detected

Latest commit: 7eff5b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-05-17T22:35:43Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -1% - +1% (-0.27ms - +0.20ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -1% - +1% (-0.57ms - +0.89ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -1% - +2% (-0.19ms - +0.62ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -3% - +2% (-0.30ms - +0.22ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.44ms - +0.71ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -23% - -0% (-20.75ms - +0.41ms)
^{this-change vs tip-of-tree}

update

lit-element-list: faster ✔ 0% - 7% (1.37ms - 56.56ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: faster ✔ 0% - 5% (0.14ms - 4.28ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -10% - +3% (-37.48ms - +9.79ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.80ms - +2.37ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -4% - +17% (-33.70ms - +151.28ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +0% (-10.43ms - +0.85ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +3% (-9.65ms - +23.90ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 101.0.4951.54
Sample size: 50
Built by: Benchmarks #3115
Commit: 8fedd65

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.03ms - 76.97ms	-	unsure 🔍 -1% - +1% -0.57ms - +0.89ms	faster ✔ 17% - 19% 15.80ms - 17.80ms
tip-of-tree tip-of-tree	75.78ms - 76.90ms	unsure 🔍 -1% - +1% -0.89ms - +0.57ms	-	faster ✔ 17% - 19% 15.92ms - 18.01ms
previous-release previous-release	92.42ms - 94.19ms	slower ❌ 21% - 23% 15.80ms - 17.80ms	slower ❌ 21% - 24% 15.92ms - 18.01ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	822.64ms - 830.38ms	-	faster ✔ 0% - 7% 1.37ms - 56.56ms	faster ✔ 35% - 37% 454.88ms - 479.10ms
tip-of-tree tip-of-tree	828.15ms - 882.80ms	slower ❌ 0% - 7% 1.37ms - 56.56ms	-	faster ✔ 32% - 36% 408.39ms - 467.66ms
previous-release previous-release	1282.03ms - 1304.98ms	slower ❌ 55% - 58% 454.88ms - 479.10ms	slower ❌ 46% - 56% 408.39ms - 467.66ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	803.82ms - 810.03ms	-	unsure 🔍 -1% - +0% -10.43ms - +0.85ms	faster ✔ 8% - 9% 68.08ms - 81.40ms
tip-of-tree tip-of-tree	807.01ms - 816.43ms	unsure 🔍 -0% - +1% -0.85ms - +10.43ms	-	faster ✔ 7% - 9% 62.41ms - 77.49ms
previous-release previous-release	875.77ms - 887.56ms	slower ❌ 8% - 10% 68.08ms - 81.40ms	slower ❌ 8% - 10% 62.41ms - 77.49ms	-

lit-html-kitchen-sink

Browser: chrome-headless 101.0.4951.54
Sample size: 30
Built by: Benchmarks #3115
Commit: 8fedd65

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.91ms - 30.66ms	-	unsure 🔍 -1% - +2% -0.19ms - +0.62ms	faster ✔ 13% - 16% 4.39ms - 5.77ms
tip-of-tree tip-of-tree	29.93ms - 30.21ms	unsure 🔍 -2% - +1% -0.62ms - +0.19ms	-	faster ✔ 14% - 16% 4.70ms - 5.89ms
previous-release previous-release	34.79ms - 35.94ms	slower ❌ 14% - 19% 4.39ms - 5.77ms	slower ❌ 16% - 20% 4.70ms - 5.89ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	82.23ms - 85.10ms	-	faster ✔ 0% - 5% 0.14ms - 4.28ms	unsure 🔍 -5% - +4% -4.53ms - +2.99ms
tip-of-tree tip-of-tree	84.38ms - 87.36ms	slower ❌ 0% - 5% 0.14ms - 4.28ms	-	unsure 🔍 -3% - +6% -2.35ms - +5.22ms
previous-release previous-release	80.96ms - 87.91ms	unsure 🔍 -4% - +5% -2.99ms - +4.53ms	unsure 🔍 -6% - +3% -5.22ms - +2.35ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	26.23ms - 26.47ms	-	unsure 🔍 -1% - +1% -0.27ms - +0.20ms	faster ✔ 11% - 17% 3.06ms - 5.18ms
tip-of-tree tip-of-tree	26.18ms - 26.59ms	unsure 🔍 -1% - +1% -0.20ms - +0.27ms	-	faster ✔ 10% - 16% 3.02ms - 5.16ms
previous-release previous-release	29.42ms - 31.52ms	slower ❌ 12% - 20% 3.06ms - 5.18ms	slower ❌ 11% - 20% 3.02ms - 5.16ms	-

lit-html-repeat

Browser: chrome-headless 101.0.4951.54
Sample size: 30
Built by: Benchmarks #3115
Commit: 8fedd65

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.48ms - 10.85ms	-	unsure 🔍 -3% - +2% -0.30ms - +0.22ms	faster ✔ 9% - 13% 1.12ms - 1.51ms
tip-of-tree tip-of-tree	10.52ms - 10.88ms	unsure 🔍 -2% - +3% -0.22ms - +0.30ms	-	faster ✔ 9% - 12% 1.09ms - 1.46ms
previous-release previous-release	11.93ms - 12.03ms	slower ❌ 10% - 14% 1.12ms - 1.51ms	slower ❌ 10% - 14% 1.09ms - 1.46ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	324.92ms - 357.24ms	-	unsure 🔍 -10% - +3% -37.48ms - +9.79ms	faster ✔ 21% - 31% 90.86ms - 144.70ms
tip-of-tree tip-of-tree	337.68ms - 372.18ms	unsure 🔍 -3% - +11% -9.79ms - +37.48ms	-	faster ✔ 17% - 28% 76.34ms - 131.53ms
previous-release previous-release	437.33ms - 480.40ms	slower ❌ 26% - 44% 90.86ms - 144.70ms	slower ❌ 21% - 38% 76.34ms - 131.53ms	-

lit-html-template-heavy

Browser: chrome-headless 101.0.4951.54
Sample size: 50
Built by: Benchmarks #3115
Commit: 8fedd65

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	53.82ms - 54.60ms	-	unsure 🔍 -1% - +1% -0.44ms - +0.71ms	faster ✔ 15% - 19% 9.70ms - 12.73ms
tip-of-tree tip-of-tree	53.65ms - 54.49ms	unsure 🔍 -1% - +1% -0.71ms - +0.44ms	-	faster ✔ 15% - 19% 9.83ms - 12.88ms
previous-release previous-release	63.96ms - 66.89ms	slower ❌ 18% - 24% 9.70ms - 12.73ms	slower ❌ 18% - 24% 9.83ms - 12.88ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	120.95ms - 123.54ms	-	unsure 🔍 -1% - +2% -0.80ms - +2.37ms	faster ✔ 12% - 15% 17.52ms - 20.90ms
tip-of-tree tip-of-tree	120.55ms - 122.37ms	unsure 🔍 -2% - +1% -2.37ms - +0.80ms	-	faster ✔ 13% - 15% 18.58ms - 21.41ms
previous-release previous-release	140.37ms - 142.54ms	slower ❌ 14% - 17% 17.52ms - 20.90ms	slower ❌ 15% - 18% 18.58ms - 21.41ms	-

reactive-element-list

Browser: chrome-headless 101.0.4951.54
Sample size: 50
Built by: Benchmarks #3115
Commit: 8fedd65

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.28ms - 85.15ms	-	unsure 🔍 -23% - -0% -20.75ms - +0.41ms	unsure 🔍 -15% - +12% -11.51ms - +9.63ms
tip-of-tree tip-of-tree	80.35ms - 95.42ms	unsure 🔍 -1% - +28% -0.41ms - +20.75ms	-	unsure 🔍 -3% - +26% -1.41ms - +19.87ms
previous-release previous-release	71.14ms - 86.16ms	unsure 🔍 -12% - +15% -9.63ms - +11.51ms	unsure 🔍 -22% - +1% -19.87ms - +1.41ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	888.27ms - 1041.03ms	-	unsure 🔍 -4% - +17% -33.70ms - +151.28ms	unsure 🔍 -6% - +16% -54.79ms - +142.18ms
tip-of-tree tip-of-tree	853.71ms - 958.01ms	unsure 🔍 -15% - +3% -151.28ms - +33.70ms	-	unsure 🔍 -10% - +7% -96.24ms - +66.06ms
previous-release previous-release	858.78ms - 983.13ms	unsure 🔍 -14% - +5% -142.18ms - +54.79ms	unsure 🔍 -7% - +11% -66.06ms - +96.24ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	856.03ms - 878.31ms	-	unsure 🔍 -1% - +3% -9.65ms - +23.90ms	unsure 🔍 -2% - +1% -19.59ms - +13.09ms
tip-of-tree tip-of-tree	847.51ms - 872.58ms	unsure 🔍 -3% - +1% -23.90ms - +9.65ms	-	unsure 🔍 -3% - +1% -27.70ms - +6.94ms
previous-release previous-release	858.47ms - 882.38ms	unsure 🔍 -2% - +2% -13.09ms - +19.59ms	unsure 🔍 -1% - +3% -6.94ms - +27.70ms	-

_{tachometer-reporter-action v2 for Benchmarks}

justinfagnani · 2022-05-17T22:38:25Z

I don't think updating lock files needs to or really should be associated with releases. I like the idea of regularly and periodically updating dependencies. Dependabot should theoretically be doing that, but we probably need our test stabilized before automatically merging its PRs.

justinfagnani

thanks!

augustjk · 2022-05-17T22:45:07Z

I don't think updating lock files needs to or really should be associated with releases. I like the idea of regularly and periodically updating dependencies. Dependabot should theoretically be doing that, but we probably need our test stabilized before automatically merging its PRs.

In this case we're not actually updating any dependencies. The diffs here are purely the version number of the actual package themselves.

For instance, changeset updates the version in lit's package.json from 2.2.3 to 2.2.4 but does not update the top level "version" property in the package-lock.json, which stays at 2.2.3, and therefore out of sync with the its corresponding package.json.

justinfagnani · 2022-05-17T22:46:00Z

ahhh. In that case, changesets should fix and until then we definitely could :)

augustjk added 2 commits May 17, 2022 15:29

Update lockfiles

16ce081

Add empty changeset

7eff5b7

augustjk requested a review from AndrewJakubowicz May 17, 2022 22:35

augustjk requested a review from justinfagnani as a code owner May 17, 2022 22:35

justinfagnani approved these changes May 17, 2022

View reviewed changes

augustjk merged commit 0594bd8 into main May 17, 2022

augustjk deleted the update-lockfiles branch May 17, 2022 22:49

augustjk mentioned this pull request May 17, 2022

[infra] Update version script to also update package-lock #2921

Merged

[chore] Update lockfiles #2918

[chore] Update lockfiles #2918

Uh oh!

Conversation

augustjk commented May 17, 2022

Uh oh!

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Uh oh!

github-actions bot commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

justinfagnani commented May 17, 2022

Uh oh!

justinfagnani left a comment

Choose a reason for hiding this comment

Uh oh!

augustjk commented May 17, 2022

Uh oh!

justinfagnani commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented May 17, 2022 •

edited

Loading