[infra] Update version script to also update package-lock #2921

augustjk · 2022-05-17T23:30:37Z

When the changeset action runs, it runs npm run version as it creates the Version Release PR as specified here:

Line 60 in 0594bd8

version: npm run version

While this bumps the versions of updated packages in package.json, it does not update them in package-lock.json which necessitated PRs like this #2918

Running lerna bootstrap passing in the --package-lock-only flag documented here https://docs.npmjs.com/cli/v8/commands/npm-install, it will also update the package-lock.json files with the proper versions based on the updated package.json.

Tested this locally by creating a new changeset for a package and running npm run version which resulted in an updated package.json, changelog.md, and package-lock.json.

Edit to add: The lerna bootstrap -- --package-lock-only will only update the package-lock.json file if the node_modules directory for the package is empty, which it would be when this is run in the github actions pipeline. To reproduce locally, make sure the node_modules directory of the modified package is removed. Thanks @AndrewJakubowicz!

We should see this work in the next Version Release PR.

changeset-bot · 2022-05-17T23:30:39Z

⚠️ No Changeset found

Latest commit: 2a538ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-05-17T23:31:08Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -4% - +1% (-1.03ms - +0.25ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -1% - +7% (-0.91ms - +5.06ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -1% - +1% (-0.28ms - +0.15ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +2% (-0.15ms - +0.25ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.34ms - +1.19ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -8% - +19% (-5.77ms - +13.54ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -3% - +3% (-20.54ms - +21.41ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -5% - +1% (-4.44ms - +0.85ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +1% (-2.55ms - +2.48ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +0% (-2.49ms - +0.38ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +0% (-8.72ms - +3.40ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-4.30ms - +5.92ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +1% (-15.40ms - +10.38ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 102.0.5005.61
Sample size: 50
Built by: Benchmarks #3342
Commit: dc937c9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	72.68ms - 78.63ms	-	unsure 🔍 -1% - +7% -0.91ms - +5.06ms	faster ✔ 17% - 23% 15.65ms - 21.85ms
tip-of-tree tip-of-tree	73.30ms - 73.86ms	unsure 🔍 -7% - +1% -5.06ms - +0.91ms	-	faster ✔ 21% - 23% 19.90ms - 21.75ms
previous-release previous-release	93.53ms - 95.28ms	slower ❌ 20% - 30% 15.65ms - 21.85ms	slower ❌ 27% - 30% 19.90ms - 21.75ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	705.37ms - 733.30ms	-	unsure 🔍 -3% - +3% -20.54ms - +21.41ms	faster ✔ 37% - 40% 426.16ms - 463.79ms
tip-of-tree tip-of-tree	703.25ms - 734.55ms	unsure 🔍 -3% - +3% -21.41ms - +20.54ms	-	faster ✔ 37% - 40% 425.32ms - 465.51ms
previous-release previous-release	1151.70ms - 1176.92ms	slower ❌ 58% - 65% 426.16ms - 463.79ms	slower ❌ 58% - 66% 425.32ms - 465.51ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	724.50ms - 731.22ms	-	unsure 🔍 -1% - +1% -4.30ms - +5.92ms	faster ✔ 6% - 8% 47.85ms - 60.38ms
tip-of-tree tip-of-tree	723.20ms - 730.90ms	unsure 🔍 -1% - +1% -5.92ms - +4.30ms	-	faster ✔ 6% - 8% 48.39ms - 61.47ms
previous-release previous-release	776.69ms - 787.26ms	slower ❌ 7% - 8% 47.85ms - 60.38ms	slower ❌ 7% - 8% 48.39ms - 61.47ms	-

lit-html-kitchen-sink

Browser: chrome-headless 102.0.5005.61
Sample size: 30
Built by: Benchmarks #3342
Commit: dc937c9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.20ms - 29.47ms	-	unsure 🔍 -1% - +1% -0.28ms - +0.15ms	faster ✔ 13% - 17% 4.52ms - 6.13ms
tip-of-tree tip-of-tree	29.23ms - 29.57ms	unsure 🔍 -1% - +1% -0.15ms - +0.28ms	-	faster ✔ 13% - 17% 4.45ms - 6.07ms
previous-release previous-release	33.86ms - 35.45ms	slower ❌ 15% - 21% 4.52ms - 6.13ms	slower ❌ 15% - 21% 4.45ms - 6.07ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	77.58ms - 79.96ms	-	unsure 🔍 -5% - +1% -4.44ms - +0.85ms	faster ✔ 3% - 9% 2.52ms - 7.36ms
tip-of-tree tip-of-tree	78.20ms - 82.93ms	unsure 🔍 -1% - +6% -0.85ms - +4.44ms	-	unsure 🔍 -7% - -0% -6.31ms - +0.02ms
previous-release previous-release	81.60ms - 85.82ms	slower ❌ 3% - 9% 2.52ms - 7.36ms	unsure 🔍 -0% - +8% -0.02ms - +6.31ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	25.50ms - 25.92ms	-	unsure 🔍 -4% - +1% -1.03ms - +0.25ms	faster ✔ 11% - 15% 3.14ms - 4.49ms
tip-of-tree tip-of-tree	25.50ms - 26.70ms	unsure 🔍 -1% - +4% -0.25ms - +1.03ms	-	faster ✔ 9% - 14% 2.54ms - 4.30ms
previous-release previous-release	28.88ms - 30.16ms	slower ❌ 12% - 18% 3.14ms - 4.49ms	slower ❌ 10% - 17% 2.54ms - 4.30ms	-

lit-html-repeat

Browser: chrome-headless 102.0.5005.61
Sample size: 30
Built by: Benchmarks #3342
Commit: dc937c9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.02ms - 11.31ms	-	unsure 🔍 -1% - +2% -0.15ms - +0.25ms	faster ✔ 9% - 11% 1.07ms - 1.37ms
tip-of-tree tip-of-tree	10.98ms - 11.25ms	unsure 🔍 -2% - +1% -0.25ms - +0.15ms	-	faster ✔ 9% - 11% 1.12ms - 1.42ms
previous-release previous-release	12.33ms - 12.44ms	slower ❌ 9% - 12% 1.07ms - 1.37ms	slower ❌ 10% - 13% 1.12ms - 1.42ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	368.36ms - 371.87ms	-	unsure 🔍 -1% - +1% -2.55ms - +2.48ms	faster ✔ 19% - 20% 87.76ms - 93.55ms
tip-of-tree tip-of-tree	368.35ms - 371.95ms	unsure 🔍 -1% - +1% -2.48ms - +2.55ms	-	faster ✔ 19% - 20% 87.70ms - 93.54ms
previous-release previous-release	458.47ms - 463.07ms	slower ❌ 24% - 25% 87.76ms - 93.55ms	slower ❌ 24% - 25% 87.70ms - 93.54ms	-

lit-html-template-heavy

Browser: chrome-headless 102.0.5005.61
Sample size: 50
Built by: Benchmarks #3342
Commit: dc937c9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.06ms - 55.15ms	-	unsure 🔍 -1% - +2% -0.34ms - +1.19ms	faster ✔ 15% - 18% 9.81ms - 11.76ms
tip-of-tree tip-of-tree	53.64ms - 54.72ms	unsure 🔍 -2% - +1% -1.19ms - +0.34ms	-	faster ✔ 16% - 18% 10.23ms - 12.19ms
previous-release previous-release	64.58ms - 66.20ms	slower ❌ 18% - 22% 9.81ms - 11.76ms	slower ❌ 19% - 23% 10.23ms - 12.19ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	116.19ms - 118.14ms	-	unsure 🔍 -2% - +0% -2.49ms - +0.38ms	faster ✔ 13% - 15% 17.18ms - 21.30ms
tip-of-tree tip-of-tree	117.17ms - 119.27ms	unsure 🔍 -0% - +2% -0.38ms - +2.49ms	-	faster ✔ 12% - 15% 16.09ms - 20.29ms
previous-release previous-release	134.59ms - 138.22ms	slower ❌ 15% - 18% 17.18ms - 21.30ms	slower ❌ 14% - 17% 16.09ms - 20.29ms	-

reactive-element-list

Browser: chrome-headless 102.0.5005.61
Sample size: 50
Built by: Benchmarks #3342
Commit: dc937c9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.09ms - 84.75ms	-	unsure 🔍 -8% - +19% -5.77ms - +13.54ms	unsure 🔍 -11% - +15% -7.90ms - +11.59ms
tip-of-tree tip-of-tree	67.21ms - 80.85ms	unsure 🔍 -17% - +7% -13.54ms - +5.77ms	-	unsure 🔍 -15% - +10% -11.79ms - +7.70ms
previous-release previous-release	69.12ms - 83.03ms	unsure 🔍 -15% - +10% -11.59ms - +7.90ms	unsure 🔍 -11% - +16% -7.70ms - +11.79ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	726.16ms - 734.69ms	-	unsure 🔍 -1% - +0% -8.72ms - +3.40ms	unsure 🔍 -5% - +2% -41.07ms - +13.59ms
tip-of-tree tip-of-tree	728.78ms - 737.38ms	unsure 🔍 -0% - +1% -3.40ms - +8.72ms	-	unsure 🔍 -5% - +2% -38.42ms - +16.25ms
previous-release previous-release	717.17ms - 771.16ms	unsure 🔍 -2% - +6% -13.59ms - +41.07ms	unsure 🔍 -2% - +5% -16.25ms - +38.42ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	797.00ms - 815.09ms	-	unsure 🔍 -2% - +1% -15.40ms - +10.38ms	unsure 🔍 -3% - +1% -20.70ms - +5.02ms
tip-of-tree tip-of-tree	799.37ms - 817.73ms	unsure 🔍 -1% - +2% -10.38ms - +15.40ms	-	unsure 🔍 -2% - +1% -18.29ms - +7.63ms
previous-release previous-release	804.74ms - 823.03ms	unsure 🔍 -1% - +3% -5.02ms - +20.70ms	unsure 🔍 -1% - +2% -7.63ms - +18.29ms	-

_{tachometer-reporter-action v2 for Benchmarks}

AndrewJakubowicz

Stellar! Manually tested and validated it working. Also great description.

augustjk requested a review from aomarks May 17, 2022 23:30

augustjk requested a review from justinfagnani as a code owner May 17, 2022 23:30

AndrewJakubowicz approved these changes May 25, 2022

View reviewed changes

AndrewJakubowicz mentioned this pull request May 25, 2022

[chore] Update package-lock #2947

Merged

augustjk mentioned this pull request Jun 1, 2022

[chore] Update package-lock.json files #2980

Merged

justinfagnani approved these changes Jun 9, 2022

View reviewed changes

augustjk force-pushed the update-version-script branch 2 times, most recently from ae4ddf0 to df78ada Compare June 9, 2022 22:48

Update version script to also update package-lock

2a538ec

augustjk force-pushed the update-version-script branch from df78ada to 2a538ec Compare June 10, 2022 17:18

augustjk merged commit 1838cb8 into main Jun 10, 2022

augustjk deleted the update-version-script branch June 10, 2022 17:38

augustjk mentioned this pull request Jun 13, 2022

Version Packages #3028

Merged

augustjk mentioned this pull request Jul 6, 2023

[infra] fix root package-lock to bump published dependencies #3992

Merged

[infra] Update version script to also update package-lock #2921

[infra] Update version script to also update package-lock #2921

Uh oh!

Conversation

augustjk commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

AndrewJakubowicz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

augustjk commented May 17, 2022 •

edited

Loading

changeset-bot bot commented May 17, 2022 •

edited

Loading

github-actions bot commented May 17, 2022 •

edited

Loading

AndrewJakubowicz left a comment •

edited

Loading