Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[chore] Update package-lock #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 2 commits into from
May 25, 2022
Merged

[chore] Update package-lock #2947

AndrewJakubowicz merged 2 commits into from
May 25, 2022

Conversation

@AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented May 25, 2022

Found with Augustine while learning about lerna bootstrap -- --package-lock-only and manually testing #2921.

@AndrewJakubowicz
Fix package-lock inconsistencies with package.json
0ab212d 
Found while learning about `lerna bootstrap -- --package-lock-only`
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 672e515

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -12% - +1% (-4.91ms - +0.46ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -7% - +5% (-7.38ms - +4.91ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -10% - +4% (-4.44ms - +1.68ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -15% - +2% (-2.12ms - +0.39ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -8% - +4% (-6.85ms - +3.45ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -10% - +10% (-7.85ms - +8.01ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -9% - +2% (-104.73ms - +26.81ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -5% - +9% (-5.76ms - +11.20ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -9% - +8% (-41.86ms - +39.02ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -6% - +5% (-10.27ms - +9.13ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -7% - +14% (-128.13ms - +285.93ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -4% - +5% (-37.70ms - +55.88ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +7% (-47.42ms - +91.24ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
99.07ms - 107.41ms-unsure 🔍
-7% - +5%
-7.38ms - +4.91ms		faster ✔
18% - 27%
22.76ms - 36.74ms
tip-of-tree
tip-of-tree		99.97ms - 108.98msunsure 🔍
-5% - +7%
-4.91ms - +7.38ms		-faster ✔
17% - 26%
21.33ms - 35.71ms
previous-release
previous-release		127.39ms - 138.60msslower ❌
21% - 36%
22.76ms - 36.74ms		slower ❌
20% - 35%
21.33ms - 35.71ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1056.34ms - 1134.70ms-unsure 🔍
-9% - +2%
-104.73ms - +26.81ms		faster ✔
35% - 41%
609.28ms - 732.53ms
tip-of-tree
tip-of-tree		1081.66ms - 1187.30msunsure 🔍
-3% - +10%
-26.81ms - +104.73ms		-faster ✔
32% - 39%
560.86ms - 703.03ms
previous-release
previous-release		1718.86ms - 1813.99msslower ❌
54% - 68%
609.28ms - 732.53ms		slower ❌
47% - 64%
560.86ms - 703.03ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1030.47ms - 1103.27ms-unsure 🔍
-4% - +5%
-37.70ms - +55.88ms		faster ✔
1% - 9%
11.70ms - 104.29ms
tip-of-tree
tip-of-tree		1028.38ms - 1087.18msunsure 🔍
-5% - +4%
-55.88ms - +37.70ms		-faster ✔
2% - 10%
26.06ms - 108.10ms
previous-release
previous-release		1096.25ms - 1153.47msslower ❌
1% - 10%
11.70ms - 104.29ms		slower ❌
2% - 10%
26.06ms - 108.10ms		-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
40.26ms - 43.52ms-unsure 🔍
-10% - +4%
-4.44ms - +1.68ms		faster ✔
13% - 24%
6.09ms - 12.62ms
tip-of-tree
tip-of-tree		40.69ms - 45.86msunsure 🔍
-4% - +11%
-1.68ms - +4.44ms		-faster ✔
9% - 22%
4.14ms - 11.80ms
previous-release
previous-release		48.42ms - 54.07msslower ❌
14% - 31%
6.09ms - 12.62ms		slower ❌
9% - 28%
4.14ms - 11.80ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
119.87ms - 132.15ms-unsure 🔍
-5% - +9%
-5.76ms - +11.20ms		unsure 🔍
-2% - +13%
-1.64ms - +15.02ms
tip-of-tree
tip-of-tree		117.44ms - 129.14msunsure 🔍
-9% - +4%
-11.20ms - +5.76ms		-unsure 🔍
-4% - +10%
-4.15ms - +12.08ms
previous-release
previous-release		113.70ms - 124.95msunsure 🔍
-12% - +1%
-15.02ms - +1.64ms		unsure 🔍
-10% - +3%
-12.08ms - +4.15ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.87ms - 40.37ms-unsure 🔍
-12% - +1%
-4.91ms - +0.46ms		faster ✔
7% - 19%
3.10ms - 8.90ms
tip-of-tree
tip-of-tree		38.81ms - 42.88msunsure 🔍
-1% - +13%
-0.46ms - +4.91ms		-faster ✔
2% - 15%
0.70ms - 6.85ms
previous-release
previous-release		42.31ms - 46.93msslower ❌
8% - 23%
3.10ms - 8.90ms		slower ❌
1% - 17%
0.70ms - 6.85ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.23ms - 13.89ms-unsure 🔍
-15% - +2%
-2.12ms - +0.39ms		faster ✔
1% - 17%
0.15ms - 2.47ms
tip-of-tree
tip-of-tree		12.99ms - 14.87msunsure 🔍
-3% - +17%
-0.39ms - +2.12ms		-unsure 🔍
-12% - +5%
-1.68ms - +0.80ms
previous-release
previous-release		13.56ms - 15.18msslower ❌
1% - 19%
0.15ms - 2.47ms		unsure 🔍
-6% - +12%
-0.80ms - +1.68ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
436.40ms - 496.84ms-unsure 🔍
-9% - +8%
-41.86ms - +39.02ms		faster ✔
20% - 33%
117.31ms - 212.90ms
tip-of-tree
tip-of-tree		441.17ms - 494.91msunsure 🔍
-8% - +9%
-39.02ms - +41.86ms		-faster ✔
20% - 32%
117.93ms - 209.43ms
previous-release
previous-release		594.69ms - 668.76msslower ❌
24% - 47%
117.31ms - 212.90ms		slower ❌
24% - 46%
117.93ms - 209.43ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
76.86ms - 84.06ms-unsure 🔍
-8% - +4%
-6.85ms - +3.45ms		faster ✔
13% - 24%
12.05ms - 24.09ms
tip-of-tree
tip-of-tree		78.48ms - 85.84msunsure 🔍
-4% - +9%
-3.45ms - +6.85ms		-faster ✔
11% - 22%
10.29ms - 22.44ms
previous-release
previous-release		93.70ms - 103.35msslower ❌
14% - 31%
12.05ms - 24.09ms		slower ❌
12% - 28%
10.29ms - 22.44ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
171.20ms - 185.01ms-unsure 🔍
-6% - +5%
-10.27ms - +9.13ms		faster ✔
8% - 18%
14.98ms - 37.98ms
tip-of-tree
tip-of-tree		171.86ms - 185.48msunsure 🔍
-5% - +6%
-9.13ms - +10.27ms		-faster ✔
8% - 18%
14.46ms - 37.35ms
previous-release
previous-release		195.38ms - 213.78msslower ❌
8% - 22%
14.98ms - 37.98ms		slower ❌
8% - 21%
14.46ms - 37.35ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
75.64ms - 86.27ms-unsure 🔍
-10% - +10%
-7.85ms - +8.01ms		unsure 🔍
-11% - +8%
-9.25ms - +6.36ms
tip-of-tree
tip-of-tree		74.99ms - 86.77msunsure 🔍
-10% - +10%
-8.01ms - +7.85ms		-unsure 🔍
-12% - +8%
-9.73ms - +6.69ms
previous-release
previous-release		76.68ms - 88.13msunsure 🔍
-8% - +12%
-6.36ms - +9.25ms		unsure 🔍
-8% - +12%
-6.69ms - +9.73ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1940.16ms - 2229.55ms-unsure 🔍
-7% - +14%
-128.13ms - +285.93ms		unsure 🔍
-0% - +25%
+10.94ms - +444.60ms
tip-of-tree
tip-of-tree		1857.89ms - 2154.03msunsure 🔍
-14% - +6%
-285.93ms - +128.13ms		-unsure 🔍
-4% - +20%
-70.23ms - +367.96ms
previous-release
previous-release		1695.60ms - 2018.58msfaster ✔
1% - 21%
10.94ms - 444.60ms		unsure 🔍
-18% - +3%
-367.96ms - +70.23ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
1234.38ms - 1333.66ms-unsure 🔍
-4% - +7%
-47.42ms - +91.24ms		unsure 🔍
-4% - +8%
-46.84ms - +96.72ms
tip-of-tree
tip-of-tree		1213.71ms - 1310.51msunsure 🔍
-7% - +4%
-91.24ms - +47.42ms		-unsure 🔍
-5% - +6%
-67.89ms - +73.95ms
previous-release
previous-release		1207.24ms - 1310.93msunsure 🔍
-7% - +4%
-96.72ms - +46.84ms		unsure 🔍
-6% - +5%
-73.95ms - +67.89ms		-

tachometer-reporter-action v2 for Benchmarks

@AndrewJakubowicz AndrewJakubowicz requested a review from augustjk May 25, 2022 16:55
augustjk
augustjk approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@AndrewJakubowicz AndrewJakubowicz requested a review from rictic May 25, 2022 16:58
@AndrewJakubowicz AndrewJakubowicz merged commit 3aff893 into main May 25, 2022
@AndrewJakubowicz AndrewJakubowicz deleted the fix-package-lock branch May 25, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@augustjk augustjk augustjk approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewJakubowicz @rictic @augustjk