Version Packages #3028

lit-robot · 2022-06-13T17:34:34Z

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@lit-labs/[email protected]

Patch Changes

#2979 09156025 - Fixes @contextProvider when multiple instances of an element are created; updates docs to consistently reference @contextProvided.
#3029 b373fccd - An element can now provide and request the same context. This lets elements
redefine the context binding in terms of what was provided by the parent.

@lit-labs/[email protected]

Patch Changes

#2987 93b30f7d - [labs/react] useController is compatible with React strict mode.
#2960 16a900c7 - Fix '@lit-labs/react/use-controller.js' not being correctly exported from package.json.

[email protected]

Patch Changes

#2849 b12e8d93 - Expand documentation for render and TemplateResult.

[email protected]

Patch Changes

#2849 b12e8d93 - Expand documentation for render and TemplateResult.

@lit/[email protected]

Patch Changes

#2972 ee864b6d - Fix multiple runtime msg call with same template but different expressions

github-actions · 2022-06-13T17:35:01Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-0.93ms - +0.75ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +2% (-1.75ms - +1.43ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +7% (-0.47ms - +1.99ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -4% - +2% (-0.46ms - +0.26ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +1% (-1.30ms - +0.70ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -16% - +7% (-14.01ms - +6.37ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -4% - +2% (-33.63ms - +20.29ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -5% - +3% (-3.97ms - +2.78ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -4% - +2% (-16.22ms - +8.38ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-1.56ms - +4.22ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -11% - +11% (-111.16ms - +109.13ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-9.10ms - +8.88ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +2% (-21.79ms - +15.40ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 102.0.5005.61
Sample size: 50
Built by: Benchmarks #3369
Commit: 8f3b3ea

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.67ms - 77.69ms	-	unsure 🔍 -1% - +1% -0.44ms - +1.05ms	faster ✔ 20% - 21% 18.89ms - 20.83ms
tip-of-tree tip-of-tree	76.34ms - 77.42ms	unsure 🔍 -1% - +1% -1.05ms - +0.44ms	-	faster ✔ 20% - 22% 19.18ms - 21.14ms
previous-release previous-release	96.22ms - 97.86ms	slower ❌ 24% - 27% 18.89ms - 20.83ms	slower ❌ 25% - 28% 19.18ms - 21.14ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	834.59ms - 867.79ms	-	unsure 🔍 -1% - +4% -6.13ms - +29.46ms	faster ✔ 34% - 37% 445.36ms - 491.26ms
tip-of-tree tip-of-tree	833.12ms - 845.93ms	unsure 🔍 -3% - +1% -29.46ms - +6.13ms	-	faster ✔ 35% - 37% 462.88ms - 497.07ms
previous-release previous-release	1303.65ms - 1335.35ms	slower ❌ 51% - 59% 445.36ms - 491.26ms	slower ❌ 55% - 59% 462.88ms - 497.07ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	841.39ms - 851.58ms	-	unsure 🔍 -1% - +1% -5.65ms - +9.46ms	faster ✔ 7% - 9% 65.40ms - 84.15ms
tip-of-tree tip-of-tree	839.00ms - 850.16ms	unsure 🔍 -1% - +1% -9.46ms - +5.65ms	-	faster ✔ 7% - 9% 67.03ms - 86.33ms
previous-release previous-release	913.39ms - 929.13ms	slower ❌ 8% - 10% 65.40ms - 84.15ms	slower ❌ 8% - 10% 67.03ms - 86.33ms	-

lit-html-kitchen-sink

Browser: chrome-headless 102.0.5005.61
Sample size: 30
Built by: Benchmarks #3370
Commit: 20b981b

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	28.83ms - 31.01ms	-	unsure 🔍 -2% - +7% -0.47ms - +1.99ms	faster ✔ 7% - 15% 2.32ms - 4.92ms
tip-of-tree tip-of-tree	28.59ms - 29.72ms	unsure 🔍 -7% - +1% -1.99ms - +0.47ms	-	faster ✔ 11% - 16% 3.48ms - 5.28ms
previous-release previous-release	32.84ms - 34.24ms	slower ❌ 7% - 17% 2.32ms - 4.92ms	slower ❌ 12% - 18% 3.48ms - 5.28ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	78.37ms - 81.98ms	-	unsure 🔍 -5% - +3% -3.97ms - +2.78ms	faster ✔ 2% - 8% 1.21ms - 6.73ms
tip-of-tree tip-of-tree	77.92ms - 83.63ms	unsure 🔍 -3% - +5% -2.78ms - +3.97ms	-	unsure 🔍 -8% - +0% -6.91ms - +0.17ms
previous-release previous-release	82.05ms - 86.24ms	slower ❌ 1% - 8% 1.21ms - 6.73ms	unsure 🔍 -0% - +9% -0.17ms - +6.91ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	24.97ms - 26.07ms	-	unsure 🔍 -4% - +3% -0.93ms - +0.75ms	faster ✔ 11% - 16% 3.29ms - 4.81ms
tip-of-tree tip-of-tree	24.97ms - 26.24ms	unsure 🔍 -3% - +4% -0.75ms - +0.93ms	-	faster ✔ 11% - 16% 3.14ms - 4.79ms
previous-release previous-release	29.04ms - 30.10ms	slower ❌ 13% - 19% 3.29ms - 4.81ms	slower ❌ 12% - 19% 3.14ms - 4.79ms	-

lit-html-repeat

Browser: chrome-headless 102.0.5005.61
Sample size: 30
Built by: Benchmarks #3369
Commit: 8f3b3ea

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.70ms - 11.02ms	-	unsure 🔍 -4% - +2% -0.42ms - +0.20ms	faster ✔ 9% - 12% 1.10ms - 1.45ms
tip-of-tree tip-of-tree	10.70ms - 11.24ms	unsure 🔍 -2% - +4% -0.20ms - +0.42ms	-	faster ✔ 7% - 12% 0.89ms - 1.44ms
previous-release previous-release	12.06ms - 12.21ms	slower ❌ 10% - 14% 1.10ms - 1.45ms	slower ❌ 8% - 13% 0.89ms - 1.44ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	395.17ms - 411.01ms	-	unsure 🔍 -3% - +4% -12.80ms - +16.65ms	faster ✔ 21% - 25% 104.96ms - 134.73ms
tip-of-tree tip-of-tree	388.75ms - 413.58ms	unsure 🔍 -4% - +3% -16.65ms - +12.80ms	-	faster ✔ 20% - 26% 104.09ms - 139.46ms
previous-release previous-release	510.34ms - 535.54ms	slower ❌ 26% - 34% 104.96ms - 134.73ms	slower ❌ 25% - 35% 104.09ms - 139.46ms	-

lit-html-template-heavy

Browser: chrome-headless 102.0.5005.61
Sample size: 50
Built by: Benchmarks #3370
Commit: 20b981b

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	53.26ms - 54.55ms	-	unsure 🔍 -2% - +1% -1.30ms - +0.70ms	faster ✔ 14% - 17% 8.64ms - 10.80ms
tip-of-tree tip-of-tree	53.45ms - 54.97ms	unsure 🔍 -1% - +2% -0.70ms - +1.30ms	-	faster ✔ 13% - 16% 8.27ms - 10.57ms
previous-release previous-release	62.77ms - 64.49ms	slower ❌ 16% - 20% 8.64ms - 10.80ms	slower ❌ 15% - 20% 8.27ms - 10.57ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	121.45ms - 126.19ms	-	unsure 🔍 -1% - +3% -1.56ms - +4.22ms	faster ✔ 12% - 16% 16.41ms - 22.53ms
tip-of-tree tip-of-tree	120.84ms - 124.14ms	unsure 🔍 -3% - +1% -4.22ms - +1.56ms	-	faster ✔ 13% - 16% 18.25ms - 23.35ms
previous-release previous-release	141.35ms - 145.23ms	slower ❌ 13% - 18% 16.41ms - 22.53ms	slower ❌ 15% - 19% 18.25ms - 23.35ms	-

reactive-element-list

Browser: chrome-headless 102.0.5005.61
Sample size: 50
Built by: Benchmarks #3369
Commit: 8f3b3ea

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	81.21ms - 95.95ms	-	unsure 🔍 -11% - +13% -9.30ms - +11.52ms	unsure 🔍 -17% - +3% -16.42ms - +3.36ms
tip-of-tree tip-of-tree	80.12ms - 94.82ms	unsure 🔍 -13% - +10% -11.52ms - +9.30ms	-	unsure 🔍 -18% - +2% -17.52ms - +2.24ms
previous-release previous-release	88.51ms - 101.71ms	unsure 🔍 -4% - +19% -3.36ms - +16.42ms	unsure 🔍 -3% - +21% -2.24ms - +17.52ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	944.75ms - 1103.94ms	-	unsure 🔍 -9% - +14% -84.01ms - +135.15ms	unsure 🔍 -4% - +18% -32.03ms - +169.00ms
tip-of-tree tip-of-tree	923.46ms - 1074.09ms	unsure 🔍 -13% - +8% -135.15ms - +84.01ms	-	unsure 🔍 -6% - +15% -54.25ms - +140.07ms
previous-release previous-release	894.48ms - 1017.25ms	unsure 🔍 -16% - +3% -169.00ms - +32.03ms	unsure 🔍 -14% - +5% -140.07ms - +54.25ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	917.75ms - 942.11ms	-	unsure 🔍 -2% - +2% -18.10ms - +15.22ms	unsure 🔍 -1% - +2% -12.89ms - +21.02ms
tip-of-tree tip-of-tree	920.00ms - 942.73ms	unsure 🔍 -2% - +2% -15.22ms - +18.10ms	-	unsure 🔍 -1% - +2% -10.88ms - +21.88ms
previous-release previous-release	914.07ms - 937.66ms	unsure 🔍 -2% - +1% -21.02ms - +12.89ms	unsure 🔍 -2% - +1% -21.88ms - +10.88ms	-

_{tachometer-reporter-action v2 for Benchmarks}

AndrewJakubowicz

Two issues in this release PR.

Private packages should not have changesets.
Need to add a changeset entry for 5b4edbb

augustjk · 2022-06-13T17:41:07Z

Agreed, private should not have changesets, or at least only have patch versions so we can release to public with 0.1.0.

@lit-labs/vue-utils's package.json does not have a "private": true. Is this actually meant to be published? @sorvell

AndrewJakubowicz · 2022-06-13T18:21:08Z

Great pickup @augustjk! Rolled the private change into #3029. Thank you!

augustjk · 2022-06-13T23:46:22Z

It doesn't seem like the package-lock files were updated as I hoped this #2921 would do. May need further investigation but isn't a blocker to release.

Also.. This PR doesn't have any test pipelines running? Is it because github-actions bot is the commit author on an update? But I don't see a button to even approve workflows to run, and without those running, this can't be merged. :/

augustjk · 2022-06-14T19:20:31Z

Force pushed to trigger workflows to run with following changes:

Updated package-lock files by manually running lerna bootstrap -- --packcage-lock-only
Updated PR and commit link for the labs/context change that was added later to point to the original PR and commit
I had to add an empty changeset for the lint workflow to pass.. I'm not sure if this would affect the next changeset step of publishing. Worst case, it might create a no-op Version Packages PR again?

augustjk · 2022-06-14T22:00:17Z

I had to add an empty changeset for the lint workflow to pass.. I'm not sure if this would affect the next changeset step of publishing. Worst case, it might create a no-op Version Packages PR again?

Perhaps it might be better to not include the empty changeset here, and loosen the requirement/override it. @aomarks could you help with that?

AndrewJakubowicz · 2022-06-14T22:31:44Z

packages/labs/context/CHANGELOG.md

+
+- [#2979](https://github.com/lit/lit/pull/2979) [`09156025`](https://github.com/lit/lit/commit/0915602543cd211be19ffd2f54e0082df7ac5ea4) - Fixes `@contextProvider` when multiple instances of an element are created; updates docs to consistently reference `@contextProvided`.
+
+- [#2858](https://github.com/lit/lit/pull/2858) [`5b4edbb6`](https://github.com/lit/lit/commit/5b4edbb6b602f3c40034ebe629b94b2e51ac0c1e) - An element can now provide and request the same context. This lets elements


Thank you so much for fixing this @augustjk !

Thanks for pointing it out in the first place!

lit-robot requested a review from justinfagnani as a code owner June 13, 2022 17:34

AndrewJakubowicz requested changes Jun 13, 2022

View reviewed changes

AndrewJakubowicz mentioned this pull request Jun 13, 2022

[meta] Fix release changesets #3029

Merged

github-actions bot force-pushed the changeset-release/main branch from 7e84f0b to 41ee9ba Compare June 13, 2022 23:30

AndrewJakubowicz self-requested a review June 14, 2022 00:57

augustjk force-pushed the changeset-release/main branch 4 times, most recently from 18bf97c to 23e4f3d Compare June 14, 2022 19:10

augustjk force-pushed the changeset-release/main branch from 23e4f3d to a3ad73a Compare June 14, 2022 22:02

Version Packages

4b4d46d

augustjk force-pushed the changeset-release/main branch from a3ad73a to 4b4d46d Compare June 14, 2022 22:03

AndrewJakubowicz reviewed Jun 14, 2022

View reviewed changes

AndrewJakubowicz approved these changes Jun 14, 2022

View reviewed changes

augustjk approved these changes Jun 14, 2022

View reviewed changes

augustjk merged commit df67769 into main Jun 14, 2022

augustjk deleted the changeset-release/main branch June 14, 2022 22:33

augustjk mentioned this pull request Jul 6, 2023

[infra] fix root package-lock to bump published dependencies #3992

Merged


		- [#2979](https://github.com/lit/lit/pull/2979) [`09156025`](https://github.com/lit/lit/commit/0915602543cd211be19ffd2f54e0082df7ac5ea4) - Fixes `@contextProvider` when multiple instances of an element are created; updates docs to consistently reference `@contextProvided`.

		- [#2858](https://github.com/lit/lit/pull/2858) [`5b4edbb6`](https://github.com/lit/lit/commit/5b4edbb6b602f3c40034ebe629b94b2e51ac0c1e) - An element can now provide and request the same context. This lets elements

Version Packages #3028

Version Packages #3028

Uh oh!

Conversation

lit-robot commented Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Releases

@lit-labs/[email protected]

Patch Changes

@lit-labs/[email protected]

Patch Changes

[email protected]

Patch Changes

[email protected]

Patch Changes

@lit/[email protected]

Patch Changes

Uh oh!

github-actions bot commented Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

AndrewJakubowicz left a comment

Choose a reason for hiding this comment

Uh oh!

augustjk commented Jun 13, 2022

Uh oh!

AndrewJakubowicz commented Jun 13, 2022

Uh oh!

augustjk commented Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augustjk commented Jun 14, 2022

Uh oh!

augustjk commented Jun 14, 2022

Uh oh!

AndrewJakubowicz Jun 14, 2022

Choose a reason for hiding this comment

Uh oh!

augustjk Jun 14, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lit-robot commented Jun 13, 2022 •

edited

Loading

github-actions bot commented Jun 13, 2022 •

edited

Loading

augustjk commented Jun 13, 2022 •

edited

Loading