[chore] Update package-lock.json files #2980

augustjk · 2022-06-01T20:57:39Z

Another package-lock.json updates due to desync from the previous release and other sources.

These changes were the result of running npm run nuke from the latest main.

Hoping #2921 will make these unnecessary.

changeset-bot · 2022-06-01T20:57:42Z

🦋 Changeset detected

Latest commit: 3d0a34f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-06-01T20:58:06Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -9% - +2% (-2.89ms - +0.56ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +3% (-1.56ms - +2.40ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +1% (-0.54ms - +0.36ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +3% (-0.23ms - +0.41ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.63ms - +0.93ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -10% - +21% (-7.59ms - +16.74ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -3% - +1% (-27.60ms - +12.40ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +2% (-3.13ms - +2.08ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -3% - +10% (-11.35ms - +41.07ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +0% (-2.99ms - +0.62ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -10% - +14% (-133.04ms - +186.24ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-8.47ms - +10.86ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +2% (-19.42ms - +18.46ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 101.0.4951.64
Sample size: 50
Built by: Benchmarks #3274
Commit: 652c161

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	89.54ms - 92.97ms	-	unsure 🔍 -2% - +3% -1.56ms - +2.40ms	faster ✔ 16% - 20% 17.87ms - 21.99ms
tip-of-tree tip-of-tree	89.85ms - 91.83ms	unsure 🔍 -3% - +2% -2.40ms - +1.56ms	-	faster ✔ 17% - 20% 18.84ms - 21.86ms
previous-release previous-release	110.05ms - 112.33ms	slower ❌ 19% - 24% 17.87ms - 21.99ms	slower ❌ 21% - 24% 18.84ms - 21.86ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	967.00ms - 983.94ms	-	unsure 🔍 -3% - +1% -27.60ms - +12.40ms	faster ✔ 34% - 36% 513.67ms - 544.37ms
tip-of-tree tip-of-tree	964.95ms - 1001.18ms	unsure 🔍 -1% - +3% -12.40ms - +27.60ms	-	faster ✔ 33% - 36% 499.24ms - 543.61ms
previous-release previous-release	1491.69ms - 1517.29ms	slower ❌ 52% - 56% 513.67ms - 544.37ms	slower ❌ 50% - 56% 499.24ms - 543.61ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	947.95ms - 962.85ms	-	unsure 🔍 -1% - +1% -8.47ms - +10.86ms	faster ✔ 8% - 10% 78.79ms - 103.94ms
tip-of-tree tip-of-tree	948.05ms - 960.36ms	unsure 🔍 -1% - +1% -10.86ms - +8.47ms	-	faster ✔ 8% - 10% 80.70ms - 104.42ms
previous-release previous-release	1036.63ms - 1056.90ms	slower ❌ 8% - 11% 78.79ms - 103.94ms	slower ❌ 8% - 11% 80.70ms - 104.42ms	-

lit-html-kitchen-sink

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Benchmarks #3274
Commit: 652c161

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	35.40ms - 35.88ms	-	unsure 🔍 -2% - +1% -0.54ms - +0.36ms	faster ✔ 14% - 17% 5.67ms - 7.42ms
tip-of-tree tip-of-tree	35.35ms - 36.11ms	unsure 🔍 -1% - +2% -0.36ms - +0.54ms	-	faster ✔ 13% - 17% 5.53ms - 7.38ms
previous-release previous-release	41.34ms - 43.03ms	slower ❌ 16% - 21% 5.67ms - 7.42ms	slower ❌ 15% - 21% 5.53ms - 7.38ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	100.31ms - 103.35ms	-	unsure 🔍 -3% - +2% -3.13ms - +2.08ms	unsure 🔍 -4% - +2% -3.63ms - +2.03ms
tip-of-tree tip-of-tree	100.24ms - 104.47ms	unsure 🔍 -2% - +3% -2.08ms - +3.13ms	-	unsure 🔍 -3% - +3% -3.46ms - +2.92ms
previous-release previous-release	100.24ms - 105.01ms	unsure 🔍 -2% - +4% -2.03ms - +3.63ms	unsure 🔍 -3% - +3% -2.92ms - +3.46ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.40ms - 31.90ms	-	unsure 🔍 -9% - +2% -2.89ms - +0.56ms	faster ✔ 9% - 19% 2.92ms - 7.19ms
tip-of-tree tip-of-tree	31.10ms - 34.52ms	unsure 🔍 -2% - +9% -0.56ms - +2.89ms	-	faster ✔ 4% - 18% 1.17ms - 6.61ms
previous-release previous-release	34.58ms - 38.83ms	slower ❌ 9% - 23% 2.92ms - 7.19ms	slower ❌ 3% - 21% 1.17ms - 6.61ms	-

lit-html-repeat

Browser: chrome-headless 101.0.4951.64
Sample size: 30
Built by: Benchmarks #3274
Commit: 652c161

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.00ms - 13.47ms	-	unsure 🔍 -2% - +3% -0.23ms - +0.41ms	faster ✔ 6% - 10% 0.89ms - 1.39ms
tip-of-tree tip-of-tree	12.93ms - 13.35ms	unsure 🔍 -3% - +2% -0.41ms - +0.23ms	-	faster ✔ 7% - 10% 1.01ms - 1.47ms
previous-release previous-release	14.29ms - 14.46ms	slower ❌ 7% - 11% 0.89ms - 1.39ms	slower ❌ 8% - 11% 1.01ms - 1.47ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	407.42ms - 445.01ms	-	unsure 🔍 -3% - +10% -11.35ms - +41.07ms	faster ✔ 18% - 26% 96.10ms - 146.89ms
tip-of-tree tip-of-tree	393.09ms - 429.62ms	unsure 🔍 -10% - +3% -41.07ms - +11.35ms	-	faster ✔ 21% - 29% 111.35ms - 161.36ms
previous-release previous-release	530.64ms - 564.78ms	slower ❌ 22% - 35% 96.10ms - 146.89ms	slower ❌ 26% - 40% 111.35ms - 161.36ms	-

lit-html-template-heavy

Browser: chrome-headless 101.0.4951.64
Sample size: 50
Built by: Benchmarks #3274
Commit: 652c161

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.01ms - 66.29ms	-	unsure 🔍 -1% - +1% -0.63ms - +0.93ms	faster ✔ 14% - 16% 10.92ms - 12.85ms
tip-of-tree tip-of-tree	65.05ms - 65.94ms	unsure 🔍 -1% - +1% -0.93ms - +0.63ms	-	faster ✔ 15% - 16% 11.19ms - 12.88ms
previous-release previous-release	76.82ms - 78.25ms	slower ❌ 17% - 20% 10.92ms - 12.85ms	slower ❌ 17% - 20% 11.19ms - 12.88ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	148.77ms - 151.46ms	-	unsure 🔍 -2% - +0% -2.99ms - +0.62ms	faster ✔ 12% - 14% 19.98ms - 23.93ms
tip-of-tree tip-of-tree	150.10ms - 152.50ms	unsure 🔍 -0% - +2% -0.62ms - +2.99ms	-	faster ✔ 11% - 13% 18.89ms - 22.65ms
previous-release previous-release	170.62ms - 173.52ms	slower ❌ 13% - 16% 19.98ms - 23.93ms	slower ❌ 12% - 15% 18.89ms - 22.65ms	-

reactive-element-list

Browser: chrome-headless 101.0.4951.64
Sample size: 50
Built by: Benchmarks #3274
Commit: 652c161

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	78.49ms - 96.28ms	-	unsure 🔍 -10% - +21% -7.59ms - +16.74ms	unsure 🔍 -9% - +21% -7.42ms - +16.91ms
tip-of-tree tip-of-tree	74.51ms - 91.11ms	unsure 🔍 -19% - +8% -16.74ms - +7.59ms	-	unsure 🔍 -14% - +14% -11.57ms - +11.91ms
previous-release previous-release	74.34ms - 90.94ms	unsure 🔍 -19% - +8% -16.91ms - +7.42ms	unsure 🔍 -14% - +14% -11.91ms - +11.57ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1295.59ms - 1522.49ms	-	unsure 🔍 -10% - +14% -133.04ms - +186.24ms	unsure 🔍 -10% - +14% -134.29ms - +186.91ms
tip-of-tree tip-of-tree	1270.12ms - 1494.76ms	unsure 🔍 -13% - +9% -186.24ms - +133.04ms	-	unsure 🔍 -12% - +12% -160.09ms - +159.52ms
previous-release previous-release	1269.05ms - 1496.40ms	unsure 🔍 -13% - +9% -186.91ms - +134.29ms	unsure 🔍 -12% - +12% -159.52ms - +160.09ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1035.61ms - 1061.14ms	-	unsure 🔍 -2% - +2% -19.42ms - +18.46ms	unsure 🔍 -3% - +1% -31.37ms - +9.22ms
tip-of-tree tip-of-tree	1034.87ms - 1062.84ms	unsure 🔍 -2% - +2% -18.46ms - +19.42ms	-	unsure 🔍 -3% - +1% -31.68ms - +10.49ms
previous-release previous-release	1043.68ms - 1075.23ms	unsure 🔍 -1% - +3% -9.22ms - +31.37ms	unsure 🔍 -1% - +3% -10.49ms - +31.68ms	-

_{tachometer-reporter-action v2 for Benchmarks}

AndrewJakubowicz

The spacing changes in the starter kits and test package-lock files don't render in Github. Checked them in vscode and look good.

Thank you!

augustjk · 2022-06-01T21:36:49Z

The spacing changes in the starter kits and test package-lock files don't render in Github. Checked them in vscode and look good.

Thanks for taking a look! I'm still unsure exactly when those whitespaces are turned into spaces that npm turns them back into tabs but hopefully it's not a constant flip flop kind of thing.

augustjk added 2 commits June 1, 2022 13:54

[chore] Update package-lock.json files

436b39b

Add empty changeset

3d0a34f

augustjk requested a review from AndrewJakubowicz June 1, 2022 20:57

augustjk requested a review from justinfagnani as a code owner June 1, 2022 20:57

AndrewJakubowicz approved these changes Jun 1, 2022

View reviewed changes

augustjk merged commit 9e40dbd into main Jun 1, 2022

augustjk deleted the update-lockfiles branch June 1, 2022 21:37

[chore] Update package-lock.json files #2980

[chore] Update package-lock.json files #2980

Uh oh!

Conversation

augustjk commented Jun 1, 2022

Uh oh!

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Uh oh!

github-actions bot commented Jun 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

AndrewJakubowicz left a comment

Choose a reason for hiding this comment

Uh oh!

augustjk commented Jun 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Jun 1, 2022 •

edited

Loading