[labs/react] Only add `suppressHydrationWarning` prop in the client #3978

augustjk · 2023-06-23T23:02:51Z

#3977 causes the suppressHydrationWarning prop to actually get emitted as an attribute on the host element for wrapped components being server rendered as shown in this test output: https://github.com/lit/lit/actions/runs/5361038597/jobs/9726603547?pr=3977#step:8:443

The suppressHydrationWarning only has effect on React components in the client so there's no reason to add it if in node mode.

changeset-bot · 2023-06-23T23:02:54Z

🦋 Changeset detected

Latest commit: ac82698

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-06-23T23:03:11Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -6% - +14% (-1.21ms - +3.08ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 69.24ms - 73.13ms
lit-html-kitchen-sink: unsure 🔍 -7% - +11% (-2.06ms - +3.32ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -3% - +3% (-0.32ms - +0.25ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.76ms - +1.52ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +3% (-0.65ms - +1.21ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 814.83ms - 828.25ms
lit-html-kitchen-sink: unsure 🔍 -3% - +7% (-2.20ms - +5.80ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +5% (-2.99ms - +15.17ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-0.62ms - +3.25ms)
^{this-change vs tip-of-tree}
reactive-element-list: faster ✔ 0% - 2% (0.06ms - 18.84ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 775.65ms - 783.88ms
reactive-element-list: faster ✔ 0% - 2% (0.51ms - 16.68ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 114.0.5735.133
Sample size: 50
Built by: Benchmarks #4924
Commit: 701f985

render

Version	Avg time	vs
	69.24ms - 73.13ms	-

update

Version	Avg time	vs
	814.83ms - 828.25ms	-

update-reflect

Version	Avg time	vs
	775.65ms - 783.88ms	-

lit-html-kitchen-sink

Browser: chrome-headless 114.0.5735.133
Sample size: 30
Built by: Benchmarks #4924
Commit: 701f985

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.51ms - 33.60ms	-	unsure 🔍 -7% - +11% -2.06ms - +3.32ms	unsure 🔍 -6% - +11% -1.73ms - +3.38ms
tip-of-tree tip-of-tree	29.19ms - 32.67ms	unsure 🔍 -10% - +6% -3.32ms - +2.06ms	-	unsure 🔍 -7% - +8% -2.12ms - +2.51ms
previous-release previous-release	29.20ms - 32.26ms	unsure 🔍 -11% - +5% -3.38ms - +1.73ms	unsure 🔍 -8% - +7% -2.51ms - +2.12ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	78.13ms - 83.80ms	-	unsure 🔍 -3% - +7% -2.20ms - +5.80ms	unsure 🔍 -5% - +5% -4.26ms - +3.87ms
tip-of-tree tip-of-tree	76.34ms - 81.98ms	unsure 🔍 -7% - +3% -5.80ms - +2.20ms	-	unsure 🔍 -7% - +2% -6.05ms - +2.05ms
previous-release previous-release	78.25ms - 84.07ms	unsure 🔍 -5% - +5% -3.87ms - +4.26ms	unsure 🔍 -3% - +8% -2.05ms - +6.05ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	21.05ms - 24.19ms	-	unsure 🔍 -6% - +14% -1.21ms - +3.08ms	unsure 🔍 -12% - +7% -2.78ms - +1.60ms
tip-of-tree tip-of-tree	20.23ms - 23.15ms	unsure 🔍 -13% - +5% -3.08ms - +1.21ms	-	unsure 🔍 -15% - +2% -3.64ms - +0.59ms
previous-release previous-release	21.68ms - 24.74ms	unsure 🔍 -7% - +12% -1.60ms - +2.78ms	unsure 🔍 -3% - +17% -0.59ms - +3.64ms	-

lit-html-repeat

Browser: chrome-headless 114.0.5735.133
Sample size: 30
Built by: Benchmarks #4924
Commit: 701f985

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	9.74ms - 10.12ms	-	unsure 🔍 -3% - +3% -0.32ms - +0.25ms	unsure 🔍 -4% - +2% -0.38ms - +0.17ms
tip-of-tree tip-of-tree	9.75ms - 10.18ms	unsure 🔍 -3% - +3% -0.25ms - +0.32ms	-	unsure 🔍 -4% - +2% -0.37ms - +0.23ms
previous-release previous-release	9.83ms - 10.24ms	unsure 🔍 -2% - +4% -0.17ms - +0.38ms	unsure 🔍 -2% - +4% -0.23ms - +0.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	285.71ms - 298.16ms	-	unsure 🔍 -1% - +5% -2.99ms - +15.17ms	unsure 🔍 -4% - +2% -12.99ms - +5.83ms
tip-of-tree tip-of-tree	279.24ms - 292.46ms	unsure 🔍 -5% - +1% -15.17ms - +2.99ms	-	unsure 🔍 -6% - -0% -19.33ms - +0.01ms
previous-release previous-release	288.46ms - 302.57ms	unsure 🔍 -2% - +4% -5.83ms - +12.99ms	unsure 🔍 -0% - +7% -0.01ms - +19.33ms	-

lit-html-template-heavy

Browser: chrome-headless 114.0.5735.133
Sample size: 50
Built by: Benchmarks #4924
Commit: 701f985

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	50.77ms - 52.43ms	-	unsure 🔍 -1% - +3% -0.76ms - +1.52ms	unsure 🔍 -3% - +1% -1.75ms - +0.69ms
tip-of-tree tip-of-tree	50.44ms - 51.99ms	unsure 🔍 -3% - +1% -1.52ms - +0.76ms	-	unsure 🔍 -4% - +1% -2.09ms - +0.28ms
previous-release previous-release	51.23ms - 53.02ms	unsure 🔍 -1% - +3% -0.69ms - +1.75ms	unsure 🔍 -1% - +4% -0.28ms - +2.09ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	117.16ms - 120.19ms	-	unsure 🔍 -1% - +3% -0.62ms - +3.25ms	slower ❌ 0% - 4% 0.31ms - 4.10ms
tip-of-tree tip-of-tree	116.15ms - 118.56ms	unsure 🔍 -3% - +1% -3.25ms - +0.62ms	-	unsure 🔍 -1% - +2% -0.77ms - +2.55ms
previous-release previous-release	115.33ms - 117.61ms	faster ✔ 0% - 3% 0.31ms - 4.10ms	unsure 🔍 -2% - +1% -2.55ms - +0.77ms	-

reactive-element-list

Browser: chrome-headless 114.0.5735.133
Sample size: 50
Built by: Benchmarks #4924
Commit: 701f985

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	45.46ms - 46.80ms	-	unsure 🔍 -1% - +3% -0.65ms - +1.21ms	unsure 🔍 -1% - +3% -0.52ms - +1.32ms
tip-of-tree tip-of-tree	45.20ms - 46.50ms	unsure 🔍 -3% - +1% -1.21ms - +0.65ms	-	unsure 🔍 -2% - +2% -0.79ms - +1.03ms
previous-release previous-release	45.09ms - 46.36ms	unsure 🔍 -3% - +1% -1.32ms - +0.52ms	unsure 🔍 -2% - +2% -1.03ms - +0.79ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	814.29ms - 826.50ms	-	faster ✔ 0% - 2% 0.06ms - 18.84ms	unsure 🔍 -1% - +1% -8.86ms - +7.81ms
tip-of-tree tip-of-tree	822.71ms - 836.98ms	slower ❌ 0% - 2% 0.06ms - 18.84ms	-	unsure 🔍 -0% - +2% -0.19ms - +18.04ms
previous-release previous-release	815.24ms - 826.60ms	unsure 🔍 -1% - +1% -7.81ms - +8.86ms	unsure 🔍 -2% - +0% -18.04ms - +0.19ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	792.55ms - 803.57ms	-	faster ✔ 0% - 2% 0.51ms - 16.68ms	faster ✔ 0% - 2% 0.45ms - 15.22ms
tip-of-tree tip-of-tree	800.74ms - 812.57ms	slower ❌ 0% - 2% 0.51ms - 16.68ms	-	unsure 🔍 -1% - +1% -6.93ms - +8.45ms
previous-release previous-release	800.98ms - 810.81ms	slower ❌ 0% - 2% 0.45ms - 15.22ms	unsure 🔍 -1% - +1% -8.45ms - +6.93ms	-

_{tachometer-reporter-action v2 for Benchmarks}

AndrewJakubowicz

Nice!

augustjk added 2 commits June 23, 2023 15:56

Only add suppressHydrationWarning prop in client

bb96896

Add changeset

ac82698

augustjk requested review from AndrewJakubowicz and justinfagnani June 23, 2023 23:02

augustjk requested a review from kevinpschaaf as a code owner June 23, 2023 23:02

augustjk mentioned this pull request Jun 23, 2023

[labs/ssr] Make attribute handling case-insensitive #3977

Merged

AndrewJakubowicz approved these changes Jun 23, 2023

View reviewed changes

augustjk merged commit 3711e66 into main Jun 26, 2023

augustjk deleted the labs-react-suppress-warning branch June 26, 2023 20:32

lit-robot mentioned this pull request Jul 5, 2023

Version Packages #3990

Merged

[labs/react] Only add suppressHydrationWarning prop in the client #3978

[labs/react] Only add suppressHydrationWarning prop in the client #3978

Uh oh!

Conversation

augustjk commented Jun 23, 2023

Uh oh!

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Uh oh!

github-actions bot commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

AndrewJakubowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[labs/react] Only add `suppressHydrationWarning` prop in the client #3978

[labs/react] Only add `suppressHydrationWarning` prop in the client #3978

github-actions bot commented Jun 23, 2023 •

edited

Loading