Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[infra] fix root package-lock to bump published dependencies #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndrewJakubowicz merged 2 commits into from
Jul 6, 2023
Merged

[infra] fix root package-lock to bump published dependencies #3992

AndrewJakubowicz merged 2 commits into from
Jul 6, 2023

Conversation

@AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Jul 6, 2023 •
edited
Loading

Ran npm i, bumping the package versions of the recently released: #3990

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e04a065

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -10% - +11% (-2.33ms - +2.50ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 72.05ms - 75.49ms
  • lit-html-kitchen-sink: unsure 🔍 -8% - +8% (-2.45ms - +2.58ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +4% (-0.28ms - +0.36ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +3% (-0.86ms - +1.41ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +3% (-0.18ms - +1.52ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 826.66ms - 837.39ms
  • lit-html-kitchen-sink: unsure 🔍 -3% - +8% (-2.60ms - +6.45ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +2% (-9.08ms - +7.44ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.31ms - +1.47ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-10.94ms - +1.49ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 782.97ms - 790.74ms
  • reactive-element-list: unsure 🔍 -1% - +0% (-9.74ms - +0.52ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
72.05ms - 75.49ms-

update

VersionAvg timevs
826.66ms - 837.39ms-

update-reflect

VersionAvg timevs
782.97ms - 790.74ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
29.00ms - 32.99ms-unsure 🔍
-8% - +8%
-2.45ms - +2.58ms		unsure 🔍
-15% - +2%
-5.14ms - +0.72ms
tip-of-tree
tip-of-tree		29.39ms - 32.47msunsure 🔍
-8% - +8%
-2.58ms - +2.45ms		-unsure 🔍
-14% - +1%
-4.91ms - +0.37ms
previous-release
previous-release		31.06ms - 35.35msunsure 🔍
-3% - +17%
-0.72ms - +5.14ms		unsure 🔍
-1% - +16%
-0.37ms - +4.91ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
80.85ms - 88.36ms-unsure 🔍
-3% - +8%
-2.60ms - +6.45ms		unsure 🔍
-3% - +8%
-2.61ms - +6.33ms
tip-of-tree
tip-of-tree		80.16ms - 85.21msunsure 🔍
-8% - +3%
-6.45ms - +2.60ms		-unsure 🔍
-4% - +4%
-3.56ms - +3.44ms
previous-release
previous-release		80.31ms - 85.17msunsure 🔍
-7% - +3%
-6.33ms - +2.61ms		unsure 🔍
-4% - +4%
-3.44ms - +3.56ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
20.91ms - 24.40ms-unsure 🔍
-10% - +11%
-2.33ms - +2.50ms		unsure 🔍
-9% - +10%
-2.10ms - +2.22ms
tip-of-tree
tip-of-tree		20.90ms - 24.23msunsure 🔍
-11% - +10%
-2.50ms - +2.33ms		-unsure 🔍
-9% - +9%
-2.12ms - +2.07ms
previous-release
previous-release		21.33ms - 23.86msunsure 🔍
-10% - +9%
-2.22ms - +2.10ms		unsure 🔍
-9% - +9%
-2.07ms - +2.12ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.01ms - 10.45ms-unsure 🔍
-3% - +4%
-0.28ms - +0.36ms		unsure 🔍
-5% - +5%
-0.47ms - +0.47ms
tip-of-tree
tip-of-tree		9.95ms - 10.43msunsure 🔍
-3% - +3%
-0.36ms - +0.28ms		-unsure 🔍
-5% - +4%
-0.52ms - +0.44ms
previous-release
previous-release		9.81ms - 10.65msunsure 🔍
-5% - +5%
-0.47ms - +0.47ms		unsure 🔍
-4% - +5%
-0.44ms - +0.52ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
293.99ms - 306.21ms-unsure 🔍
-3% - +2%
-9.08ms - +7.44ms		unsure 🔍
-4% - +3%
-11.41ms - +9.61ms
tip-of-tree
tip-of-tree		295.36ms - 306.48msunsure 🔍
-2% - +3%
-7.44ms - +9.08ms		-unsure 🔍
-3% - +3%
-10.29ms - +10.12ms
previous-release
previous-release		292.45ms - 309.56msunsure 🔍
-3% - +4%
-9.61ms - +11.41ms		unsure 🔍
-3% - +3%
-10.12ms - +10.29ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
51.95ms - 53.44ms-unsure 🔍
-2% - +3%
-0.86ms - +1.41ms		unsure 🔍
-4% - +0%
-2.08ms - +0.19ms
tip-of-tree
tip-of-tree		51.57ms - 53.27msunsure 🔍
-3% - +2%
-1.41ms - +0.86ms		-faster ✔
0% - 4%
0.01ms - 2.43ms
previous-release
previous-release		52.79ms - 54.49msunsure 🔍
-0% - +4%
-0.19ms - +2.08ms		unsure 🔍
-0% - +5%
+0.01ms - +2.43ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
120.20ms - 122.21ms-unsure 🔍
-2% - +1%
-2.31ms - +1.47ms		unsure 🔍
-1% - +2%
-1.27ms - +1.82ms
tip-of-tree
tip-of-tree		120.03ms - 123.22msunsure 🔍
-1% - +2%
-1.47ms - +2.31ms		-unsure 🔍
-1% - +2%
-1.28ms - +2.68ms
previous-release
previous-release		119.76ms - 122.10msunsure 🔍
-1% - +1%
-1.82ms - +1.27ms		unsure 🔍
-2% - +1%
-2.68ms - +1.28ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
46.25ms - 47.64ms-unsure 🔍
-0% - +3%
-0.18ms - +1.52ms		unsure 🔍
-1% - +3%
-0.41ms - +1.51ms
tip-of-tree
tip-of-tree		45.78ms - 46.77msunsure 🔍
-3% - +0%
-1.52ms - +0.18ms		-unsure 🔍
-2% - +2%
-0.95ms - +0.71ms
previous-release
previous-release		45.72ms - 47.06msunsure 🔍
-3% - +1%
-1.51ms - +0.41ms		unsure 🔍
-2% - +2%
-0.71ms - +0.95ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
859.02ms - 866.96ms-unsure 🔍
-1% - +0%
-10.94ms - +1.49ms		unsure 🔍
-1% - +0%
-10.09ms - +3.03ms
tip-of-tree
tip-of-tree		862.93ms - 872.50msunsure 🔍
-0% - +1%
-1.49ms - +10.94ms		-unsure 🔍
-1% - +1%
-5.89ms - +8.28ms
previous-release
previous-release		861.29ms - 871.75msunsure 🔍
-0% - +1%
-3.03ms - +10.09ms		unsure 🔍
-1% - +1%
-8.28ms - +5.89ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
830.55ms - 838.17ms-unsure 🔍
-1% - +0%
-9.74ms - +0.52ms		unsure 🔍
-1% - +0%
-9.48ms - +1.36ms
tip-of-tree
tip-of-tree		835.54ms - 842.41msunsure 🔍
-0% - +1%
-0.52ms - +9.74ms		-unsure 🔍
-1% - +1%
-4.62ms - +5.71ms
previous-release
previous-release		834.57ms - 842.28msunsure 🔍
-0% - +1%
-1.36ms - +9.48ms		unsure 🔍
-1% - +1%
-5.71ms - +4.62ms		-

tachometer-reporter-action v2 for Benchmarks

augustjk
augustjk approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Wish there was a way to make this happen in the Version Packages PR, but this'll do for now.

@AndrewJakubowicz AndrewJakubowicz merged commit 5f25f99 into main Jul 6, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the fix-package-lock branch July 6, 2023 18:28
@augustjk
Copy link
Member

augustjk commented Jul 6, 2023

Possible fix: changesets/action#203 (comment)
Turns out I tried this a while back when we had lerna #2921 but it didn't work. #3028 (comment)
Maybe now with npm workspaces this would work here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewJakubowicz @augustjk