Don't include unistd #807
Merged
Don't include unistd #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
approved these changes
Dec 19, 2025
Collaborator
drreynolds
left a comment
There was a problem hiding this comment.
I'm assuming everything in the CI passes
gardner48
requested changes
Dec 19, 2025
| #include <mpi.h> | ||
| #include <stdlib.h> | ||
| #include <string.h> | ||
| #include <unistd.h> |
Member
There was a problem hiding this comment.
This header is also included in:
- benchmarks/nvector/test_nvector_performance.c
- cmake/tpl/SundialsPOSIXTimers.cmake
- src/sundials/sundials_profiler_impl.h
- src/sundials/sundials_mpi_errors.c
- test/unit_tests/sunlinsol/test_sunlinsol.c
- test/unit_tests/sunmatrix/test_sunmatrix.c
- test/unit_tests/sundomeigest/test_sundomeigest.c
- test/unit_tests/nvector/test_nvector.c
We should update the windows tests to enable the units tests, benchmarks, and profiling (maybe MPI too if that's easy).
Member
Author
There was a problem hiding this comment.
In all of those other places, it is properly guarded with SUNDIALS_HAVE_POSIX_TIMERS.
Member
There was a problem hiding this comment.
Ah, thanks for checking. Looking that the Windows testing configs we don't have an MPI test so that how this slipped through the CI, should add that as a to do item for a future PR.
gardner48
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #806. This header isnt used.