Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't include unistd #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gardner48 merged 1 commit into from
Dec 19, 2025
Merged

Don't include unistd #807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/sundials/sundials_mpi_errors.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include <mpi.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
Copy link
Member

@gardner48 gardner48 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header is also included in:

  • benchmarks/nvector/test_nvector_performance.c
  • cmake/tpl/SundialsPOSIXTimers.cmake
  • src/sundials/sundials_profiler_impl.h
  • src/sundials/sundials_mpi_errors.c
  • test/unit_tests/sunlinsol/test_sunlinsol.c
  • test/unit_tests/sunmatrix/test_sunmatrix.c
  • test/unit_tests/sundomeigest/test_sundomeigest.c
  • test/unit_tests/nvector/test_nvector.c

We should update the windows tests to enable the units tests, benchmarks, and profiling (maybe MPI too if that's easy).

Copy link
Member Author

@balos1 balos1 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all of those other places, it is properly guarded with SUNDIALS_HAVE_POSIX_TIMERS.

Copy link
Member

@gardner48 gardner48 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for checking. Looking that the Windows testing configs we don't have an MPI test so that how this slipped through the CI, should add that as a to do item for a future PR.


#include <sundials/priv/sundials_mpi_errors_impl.h>
#include <sundials/sundials_core.h>
Expand Down
Loading