Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[MooreToCore] Return early on non-convertable type #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

[MooreToCore] Return early on non-convertable type #7631

merged 1 commit into from
Sep 25, 2024

Conversation

@maerhart
Copy link
Member

Fixes #7627

terapines-osc-circt
terapines-osc-circt approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@terapines-osc-circt terapines-osc-circt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I do the same thing on this PR(#7614).

@maerhart
Copy link
Member Author

Thanks for the review @hailongSun2000!
It's not the same thing because the variable op might have other return types as well. But in that case I should probably change the regression test here because that'd otherwise break your PR.

@maerhart maerhart force-pushed the maerhart-mooretocore-fix branch from df8eaa7 to 2713db1 Compare September 25, 2024 12:27
@maerhart maerhart merged commit 7c80a60 into main Sep 25, 2024
4 checks passed
@maerhart maerhart deleted the maerhart-mooretocore-fix branch September 25, 2024 13:20
@fabianschuiki fabianschuiki mentioned this pull request Sep 26, 2024
Closed
@terapines-osc-circt terapines-osc-circt mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terapines-osc-circt terapines-osc-circt terapines-osc-circt approved these changes

@fabianschuiki fabianschuiki Awaiting requested review from fabianschuiki

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MooreToCore] Unpacked array causes crash

2 participants

@maerhart @terapines-osc-circt