[circt-test] fix SymbiYosys integration test #7886
Conversation
a771274 to
ccfacf5
Compare
|
https://github.com/llvm/circt/actions/runs/11998261862/job/33447711728#step:5:330 |
|
Good thinking! We should definitely add SymbiYosys to the set of tools installed for integration tests. |
|
If you would like to land this yourself once CI passes, feel free to obtain commit access to LLVM. Otherwise let me know and I can merge things for you 😃 |
|
@unlsycn I have added SymbiYosys and a more up-to-date build of Yosys to the integration test CI image (v18.0) in #7895. I'll land that in a few minutes if CI passes. Once that's in main, you could try to rebase this PR onto main and see if the integration test CI picks up the SymbiYosys installation and the test you fixed here now runs 🙂 |
ccfacf5 to
7a2a321
Compare
|
It looks like something might be broken in the integration image's sby setup 😞, sorry about that. This is going to be a bit annoying to debug. One approach could be to tweak the |
7a2a321 to
79d6f5f
Compare
|
We can rerun the ci now since it is merged. |
hmmmm..I forgot that the image has not been released. I can pass all the tests on my machine with the latest docker image. |
|
I have added a few sanity checks to the integration-test image: circt/images#36. Once this lands, I'll release a new version of the image such that we can land this PR. |
|
@unlsycn I have released v18.2 of the integration-test image which contains your fixes for sby, alongside a sanity check of the installation. You should be able to tweak these versions to v18.2 to get this PR to pass. |
79d6f5f to
c8e02b1
Compare
Thanks! It should pass the test now. |
Signed-off-by: unlsycn <[email protected]>
Signed-off-by: unlsycn <[email protected]>
llvm#7756 adds the SymbiYosys test runner and requires the `sby` feature, but did not add the corresponding available feature in `lit.cfg.py`, so this test never seems to run, and llvm#7763 introduces a syntax error, a backslash in the f-string expression part, in the Python script. Unlike llvm#7884, there is no need to modify PATH variable for the script since `sby` should be in the PATH if we can check it in CMake. Signed-off-by: unlsycn <[email protected]>
#7756 adds the SymbiYosys test runner and requires the
sbyfeature, but did not add the corresponding available feature inlit.cfg.py, so this test never seems to run, and #7763 introduces a syntax error, a backslash in the f-string expression part, in the Python script.Unlike #7884, there is no need to modify PATH variable for the script since
sbyshould be in the PATH if we can check it in CMake.