[FIRRTL] Rip out OMIRTracker and logic that uses it. #7908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
added a commit
that referenced
this pull request
Nov 26, 2024
This legacy system for representing an object model has been replaced by FIRRTL classes, objects, and properties. This removes the old system completely. The main change is removing the EmitOMIR pass completely, but there are several other things related to OMIR JSON to clean up. This includes command line options and annotations for specifying input and output OMIR JSON, as well as support for parsing the JSON and scattering OMIR tracker annotations. Any tests related to the above were also removed. The only remaining legacy OMIR feature is the OMIRTracker annotation, which is currently used in some canBeDeleted logic on annotations in folders, IMDCE, etc. This is being separated, and removed in this PR: #7908.
b38306e to
d2dcbb3
Compare
Change the behavior of how annotations work such that now _all_ annotations are interpreted by passes as blocking optimizations or removal. This is in preparation to rip out the last of the OMIR Tracker annotations which had some flavors which would not block optimizations. Co-authored-by: Mike Urbach <[email protected]> Signed-off-by: Schuyler Eldridge <[email protected]>
Remove the OMIRTracker annotation. This is now no longer load-bearing. Co-authored-by: Mike Urbach <[email protected]> Signed-off-by: Schuyler Eldridge <[email protected]>
Change Annotation handling behavior so that no annotation can be deleted. Previously, there existed a method that would report if an annotation could be deleted. However, now that the only annotation that had this semantic, OMIRTracker, is gone, this method is now always `false` for a single annotation and equivalent to `empty` for an `AnnotationSet`. Use these simpler functions instead and delete the `canBeDeleted` functions. Co-authored-by: Mike Urbach <[email protected]> Signed-off-by: Schuyler Eldridge <[email protected]>
d2dcbb3 to
09fc391
Compare
|
Thanks for pushing this through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used in the old legacy OMIR JSON system. Now that is gone, we don't need to support this annotation. Furthermore, the canBeDeleted logic on annotations will always return false, since we don't actually see this annotation any more. That means we can just get rid of that method, and fix up all the call sites to reflect the fact that it would have always returned false.