[test] create unit-test framework for RPC wallets #2396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2396 +/- ##
==========================================
+ Coverage 59.96% 60.29% +0.33%
==========================================
Files 65 65
Lines 9434 9458 +24
==========================================
+ Hits 5657 5703 +46
+ Misses 3777 3755 -22 ☔ View full report in Codecov by Sentry. |
dni
reviewed
Apr 12, 2024
This reverts commit ee32c42.
ba661a6 to
9f877a7
Compare
dni
reviewed
Apr 15, 2024
dni
approved these changes
Apr 15, 2024
talvasconcelos
approved these changes
Apr 15, 2024
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TLDR;
lnbits/wallets/corelightning.pyneeds serious reviewing, the rest of the changes are testslnbits/wallets/corelightning.pyis only refactored to better handle errors (no functional changes added)This PR:
corelightningandbreez(which are disabled/skipped until feat: add Breez SDK wallet #1897 is merged)