test: unit tests for lndrpc #2442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fcad44 to
7c8656b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2442 +/- ##
==========================================
+ Coverage 60.69% 60.89% +0.20%
==========================================
Files 65 65
Lines 9367 9370 +3
==========================================
+ Hits 5685 5706 +21
+ Misses 3682 3664 -18 ☔ View full report in Codecov by Sentry. |
This reverts commit ee32c42.
9694c4b to
0e0cc44
Compare
dni
approved these changes
Apr 19, 2024
arcbtc
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2396
Summary
TLDR;
lnbits/wallets/lndrpc.pyneeds serious reviewing, the rest of the changes are testslnbits/wallets/lndrpc.pyis only refactored to better handle errors (no functional changes added)