Blink review 01 #2575
Merged
Blink review 01 #2575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21236c1 to
2a077c0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## blink-rebase #2575 +/- ##
===============================================
Coverage ? 60.83%
===============================================
Files ? 70
Lines ? 10073
Branches ? 0
===============================================
Hits ? 6128
Misses ? 3945
Partials ? 0 ☔ View full report in Codecov by Sentry. |
arcbtc
pushed a commit
that referenced
this pull request
Jul 19, 2024
* refactor: mark `graphql_query` as private (`_` prefix) * feat: set default value for `blink_api_endpoint` * fix: raise if HTTP call failed * refactor: move private method to the bottom * refactor: make `wallet_id` a property * fix: key mapping for attribute * chore: fix `mypy` * chore: fix `make check` * refactor: extract query strings * refactor: extract `BlinkGrafqlQueries` class * chore: code clean-up * chore: add `try-catch` * refactor: extract `tx_query` * chore: format grapfhql queries * fix: set funding source class * chore: `make format` * fix: test by following the other patterns
arcbtc
pushed a commit
that referenced
this pull request
Jul 19, 2024
* feat: Blink funding source * chore: make bundle * Blink review 01 (#2575) * refactor: mark `graphql_query` as private (`_` prefix) * feat: set default value for `blink_api_endpoint` * fix: raise if HTTP call failed * refactor: move private method to the bottom * refactor: make `wallet_id` a property * fix: key mapping for attribute * chore: fix `mypy` * chore: fix `make check` * refactor: extract query strings * refactor: extract `BlinkGrafqlQueries` class * chore: code clean-up * chore: add `try-catch` * refactor: extract `tx_query` * chore: format grapfhql queries * fix: set funding source class * chore: `make format` * fix: test by following the other patterns * Update docs/guide/wallets.md Co-authored-by: openoms <[email protected]> * feat: add websocket connection to blink (#2577) * feat: add websocket connection to blink * feat: close websocket on shutdown * feat: add `blink_ws_endpoint` to the UI * fix: use `SEND` tx for `settlementFee` * refactor: remove `else` when `if` has `return` * fix: remove test env file --------- Co-authored-by: bitkarrot <[email protected]> Co-authored-by: Vlad Stan <[email protected]> Co-authored-by: openoms <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review code and refactor ocasiaonally.