Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@motorina0
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 18.60465% with 35 lines in your changes missing coverage. Please review.

Project coverage is 60.68%. Comparing base (ec2330d) to head (946e76d).

Files Patch % Lines
lnbits/wallets/blink.py 16.66% 35 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           blink-rebase    #2577      +/-   ##
================================================
- Coverage         60.83%   60.68%   -0.16%     
================================================
  Files                70       70              
  Lines             10073    10113      +40     
================================================
+ Hits               6128     6137       +9     
- Misses             3945     3976      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 marked this pull request as ready for review July 10, 2024 14:02
@motorina0 motorina0 merged commit 30ff25e into blink-rebase Jul 10, 2024
@motorina0 motorina0 deleted the blink_payment_notifications branch July 10, 2024 14:03
arcbtc pushed a commit that referenced this pull request Jul 19, 2024
* feat: add websocket connection to blink

* feat: close websocket on shutdown
arcbtc pushed a commit that referenced this pull request Jul 19, 2024
* feat: Blink funding source

* chore: make bundle

* Blink review 01 (#2575)

* refactor: mark `graphql_query` as private (`_` prefix)

* feat: set default value for `blink_api_endpoint`

* fix: raise if HTTP call failed

* refactor: move private method to the bottom

* refactor: make `wallet_id` a property

* fix: key mapping for attribute

* chore: fix `mypy`

* chore: fix `make check`

* refactor: extract query strings

* refactor: extract `BlinkGrafqlQueries` class

* chore: code clean-up

* chore: add `try-catch`

* refactor: extract `tx_query`

* chore: format grapfhql queries

* fix: set funding source class

* chore: `make format`

* fix: test by following the other patterns

* Update docs/guide/wallets.md

Co-authored-by: openoms <[email protected]>

* feat: add websocket connection to blink (#2577)

* feat: add websocket connection to blink

* feat: close websocket on shutdown

* feat: add `blink_ws_endpoint` to the UI

* fix: use `SEND` tx for `settlementFee`

* refactor: remove `else` when `if` has `return`

* fix: remove test env file

---------

Co-authored-by: bitkarrot <[email protected]>
Co-authored-by: Vlad Stan <[email protected]>
Co-authored-by: openoms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant