Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jGaboardi
Copy link
Member

This PR:

@jGaboardi jGaboardi self-assigned this Jul 13, 2025
@jGaboardi jGaboardi added maintenance docs github_actions Pull requests that update Github_actions code labels Jul 13, 2025
@codecov
Copy link

codecov bot commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.2%. Comparing base (13ca45e) to head (bfcc186).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #497     +/-   ##
=======================================
+ Coverage   77.8%   78.2%   +0.4%     
=======================================
  Files         27      28      +1     
  Lines       2638    2716     +78     
=======================================
+ Hits        2053    2125     +72     
- Misses       585     591      +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi jGaboardi requested review from gegen07 and martinfleis July 13, 2025 02:24
os:
- ubuntu-latest
environment-file:
- ci/py313_spopt-latest.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, I missed something in dev call. Why use suffix spopt in ci environment test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.

Simply it is my preference to have the file name and environment name exactly matching for local setup and testing. Since I generally have at least an "oldest", "latest", and "dev" for 1 or more versions of Python per package at any given time locally this helps keep things in order. (And explicit is better than implicit).

So it is really for ease of maintenance and my sanity.

But if you are strongly against, I am willing to compromise on naming etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, easing the maintenance is always great! Good to go with naming convention.

@jGaboardi jGaboardi merged commit 7ebf7fe into pysal:main Jul 14, 2025
11 checks passed
@jGaboardi jGaboardi deleted the add_new_SA3_to_docs branch July 14, 2025 00:31
fiendskrah pushed a commit to fiendskrah/spopt that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs github_actions Pull requests that update Github_actions code maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants