-
Notifications
You must be signed in to change notification settings - Fork 56
update infra & add new SA3 functionality to docs #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
=======================================
+ Coverage 77.8% 78.2% +0.4%
=======================================
Files 27 28 +1
Lines 2638 2716 +78
=======================================
+ Hits 2053 2125 +72
- Misses 585 591 +6 🚀 New features to boost your workflow:
|
| os: | ||
| - ubuntu-latest | ||
| environment-file: | ||
| - ci/py313_spopt-latest.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, I missed something in dev call. Why use suffix spopt in ci environment test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.
Simply it is my preference to have the file name and environment name exactly matching for local setup and testing. Since I generally have at least an "oldest", "latest", and "dev" for 1 or more versions of Python per package at any given time locally this helps keep things in order. (And explicit is better than implicit).
So it is really for ease of maintenance and my sanity.
But if you are strongly against, I am willing to compromise on naming etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, easing the maintenance is always great! Good to go with naming convention.
This PR: