Fix unit tests to pass under pytorch v0.3.0 branch #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge as soon as tests pass. |
neerajprad
approved these changes
Nov 10, 2017
|
Restarted the unit test; will merge once it passes. |
|
Feel free to merge before integration tests, since this only changes a unit test. |
|
@neerajprad Can we merge this so it makes it into the 0.1.2 release #553 ? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #554
mean_and_vartests to testsqrt(variance)rather thanvariance, so that mean and variance can reasonably share a precision parameter. (This probabilistic test fails in PyTorchv0.3.0due to slightly changed randomness.)test_gradient_step_golden()test because it is not stable across pytorch versions.