Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump to version 0.1.2 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2017
Merged

Bump to version 0.1.2 #553

merged 1 commit into from
Nov 10, 2017

Conversation

@fritzo
Copy link
Member

@fritzo fritzo commented Nov 10, 2017 •
edited
Loading

This minor patch release contains:

@fritzo fritzo requested a review from jpchen November 10, 2017 05:06
martinjankowiak
martinjankowiak previously approved these changes Nov 10, 2017
View reviewed changes
Copy link
Collaborator

@martinjankowiak martinjankowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

jpchen
jpchen previously approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@jpchen jpchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes! a few things:
1 if were gonna patch often, do we need more placeholders for minor changes 0.0.1_2(like pt does)
2 ill try to look into automatic deployment of the docs/tutorials with every release of master. until then, let me know when you cut the release and ill update them accordingly

@fritzo
Copy link
Member Author

fritzo commented Nov 10, 2017

do we need more placeholders for minor changes 0.0.1_2

I'd prefer not to succumb to version inflation by hiding changes in a subpatch 😉 Also, PyTorch's subpatch versioning is a pain, since they don't follow Semver and are incompatible with the semver package (hence our need to write a custom parse_torch_version())

@fritzo
Copy link
Member Author

fritzo commented Nov 10, 2017

Possibly waiting on https://github.com/null-a/pyro/commit/b84cc99f0f2edb02f069af67115cb0eecf52fa96 ...

@fritzo fritzo mentioned this pull request Nov 10, 2017
Merged
@fritzo fritzo dismissed stale reviews from jpchen and martinjankowiak via f83be2c November 10, 2017 18:56
@fritzo
Copy link
Member Author

fritzo commented Nov 10, 2017

Ready to merge and cut a patch release (since @null-a believs #555 is lower priority)

@jpchen
Copy link
Member

jpchen commented Nov 10, 2017

waiting for tests

@fritzo fritzo mentioned this pull request Nov 10, 2017
Merged
@fritzo
Copy link
Member Author

fritzo commented Nov 10, 2017

Waiting on #560 ...

@jpchen jpchen merged commit 6e2e192 into dev Nov 10, 2017
@fritzo fritzo deleted the bump-to-0.1.2 branch November 11, 2017 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpchen jpchen jpchen approved these changes

@martinjankowiak martinjankowiak martinjankowiak left review comments

Assignees

No one assigned

Labels

easy WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fritzo @jpchen @martinjankowiak