Parse pyro.__version__ and README.md in setup.py #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neerajprad
reviewed
Nov 10, 2017
|
|
||
| # Find pyro version. | ||
| for line in open('pyro/__init__.py'): | ||
| if line.startswith('__version__ = '): |
There was a problem hiding this comment.
Would pyro.__version__ not work here?
There was a problem hiding this comment.
This is avoided since the pyro module would requires setup.py would require pyro ...
Also text parsing is faster than loading all of pyro as is done in pyro/__init__.py.
neerajprad
reviewed
Nov 10, 2017
| version='0.1.1', | ||
| version=version, | ||
| description='A Python library for probabilistic modeling and inference', | ||
| long_description=long_description, |
|
Ok, I'm ready to merge. I'd like to get this in before the 0.1.2 patch release so we can have a nice pypi page 😃 |
fritzo
commented
Nov 10, 2017
| [Getting Started](http://pyro.ai/examples) | [Documentation](http://docs.pyro.ai/) | [Contributing](CONTRIBUTING.md) | ||
| [Getting Started](http://pyro.ai/examples) | | ||
| [Documentation](http://docs.pyro.ai/) | | ||
| [Contributing](https://github.com/uber/pyro/blob/master/CONTRIBUTING.md) |
There was a problem hiding this comment.
changed this to an absolute link so it still works on pypi.python.org
|
@neerajprad would you mind merging this so I can rebase #553 ? |
neerajprad
approved these changes
Nov 10, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pytopyro.__init__.pyso it is available aspyro.__version__. (This is common practice.)README.mdinsetup.pyso it can display on https://pypi.python.org/pypi/pyro-ppl (Also common practice)Tests cancelled after linting.