Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ObjectMetadata::save(): Argument #4 ($position) must be of type string #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2023
Merged

Fix ObjectMetadata::save(): Argument #4 ($position) must be of type string #15853

merged 2 commits into from
Aug 30, 2023

Conversation

@dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Aug 30, 2023 •
edited by ghost
Loading

Changes in this pull request

Resolves #15821

Additional info

WHAT

🤖 Generated by Copilot at e5c03e2

This pull request enhances the code quality and compatibility of two data types that handle advanced many-to-many relations between data objects and other elements. It applies null coalescing operators and string casting where appropriate in AdvancedManyToManyObjectRelation.php and AdvancedManyToManyRelation.php.

🤖 Generated by Copilot at e5c03e2

Sing, O Muse, of the skillful coder who refined
The AdvancedManyToManyObjectRelation type, and aligned
Its logic with the null coalescing operator, sublime
And cast the strings with care, avoiding errors hard to find.

HOW

🤖 Generated by Copilot at e5c03e2

  • Simplify ternary operators for default values using null coalesasing operator (?:) in AdvancedManyToManyObjectRelation and AdvancedManyToManyRelation classes (link, link)
  • Cast $position variable to string for consistency with database schema and avoid potential issues in AdvancedManyToManyObjectRelation and AdvancedManyToManyRelation classes (link, link)
  • Remove unnecessary string casting of $position variable in AdvancedManyToManyRelation class (link)

@dvesh3 dvesh3 added the Bug label Aug 30, 2023
@dvesh3 dvesh3 added this to the 11.0.8 milestone Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Aug 30, 2023 •
edited by aryaantony92
Loading

Review Checklist

  • Target branch (11.0 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@aryaantony92 aryaantony92 self-assigned this Aug 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
20.0% 20.0% Duplication

@aryaantony92 aryaantony92 merged commit 2e94c3c into 11.0 Aug 30, 2023
@aryaantony92 aryaantony92 deleted the fix_objectmetaddata_save_position_arg branch August 30, 2023 12:48
@aryaantony92 aryaantony92 mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aryaantony92 aryaantony92

Labels

Bug

Projects

None yet

Milestone

11.0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@dvesh3 @aryaantony92