Extension of javascript abstract plugin class. #4

Hagith · 2011-12-17T17:51:15Z

Allows to easily integrate custom plugin menu item(s) with admin toolbar.
Menu is automaticaly included if plugin class implements getMenu() abstract method.

Example (pimcore.plugin.poll class):

getMenu: function(){
    return new Ext.menu.Item({
        text: t("polls"),
        iconCls: "poll_plugin_menu_icon",
        hideOnClick: false,
        menu: [{
            text: t("create_poll"),
            iconCls: "poll_plugin_menu_new",
            handler: this.openCreateTab
        },{
            text: t("manage_polls"),
            iconCls: "poll_plugin_menu_list",
            handler: this.openListTab
        },{
            text: t("settings"),
            iconCls: "poll_plugin_settings",
            handler: this.openSettingsTab
        }]
    });
}

PS: If this code will be accepted i will update plugin anatomy section in docs.
PS2: I think that this aproach could replace existing option for plugin settings management.

Allows to easily integrate custom plugin menu item(s) with admin toolbar. Menu is automaticaly included if plugin class implements getMenu() abstract method.

timglabisch · 2012-01-04T23:39:03Z

i dont like the name getMenu, there are a lot of different menu's like context menus, the toolbar menu and so on ...

timglabisch · 2012-01-04T23:47:19Z

i think i would prefere something like

currentMenu = event.fireAndReceive(event.MODIFY_MENU_CONTEXT, currentMenu);

and a plugin could register on this event like, plugin.dispatchEvent(event.MODIFY_MENU_CONTEXT, function(currentMenu) { return currentMenu } );

Hagith · 2012-01-05T09:34:04Z

I agree about the method name, getToolbarMenu() or getPimcoreToolbarMenu() would be better.

Current abstract plugin class implementation not using proposed event handling so i think this may introduce a slight confusion to the plugin anatomy.

timglabisch · 2012-01-05T18:39:40Z

i think it would be ok to implement it like that for now. if you have a look at other systems there will be a lot of hooks, events and so on. i think next time there will be a lot of "we need this hook" requests for plugins. the abstract interface would grow up and up and up. so we should be very careful implementing such things.

timglabisch · 2012-01-08T01:28:40Z

i started to develop an alternative event system based on extJs.
timglabisch@fcb2bb5

pull request will be as soon as possible =)

Hagith · 2013-05-23T11:29:36Z

Hi, any progress with this?
Plugins repository is growing and everyone place plugin options in different places in admin menu. There should be a standarized interface for adding plugins to admin menu.

brusch · 2013-08-19T07:13:18Z

We are currently in the progress of redesigning the plugin-architecture. We'll of course consider this topic.
Thanks for your valuable input!

see pull request: pimcore#4

Hi, Maybe a little bit special, but i got an error because of undefined Service for `monolog.logger.pimcore` while Check Requirements Route. The Exception: ``` request.CRITICAL: Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: "You have requested a non-existent service "monolog.logger.pimcore". Did you mean one of these: "monolog.logger.event", "monolog.logger.php", "monolog.logger.request", "monolog.logger.cache", "monolog.logger.console"?" at /var/www/html/client.local/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Container.php line 348 {"exception":"[object] (Symfony\\Component\\DependencyInjection\\Exception\\ServiceNotFoundException(code: 0): You have requested a non-existent service \"monolog.logger.pimcore\". Did you mean one of these: \"monolog.logger.event\", \"monolog.logger.php\", \"monolog.logger.request\", \"monolog.logger.cache\", \"monolog.logger.console\"? at /var/www/html/client.local/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Container.php:348)"} [] ``` It is caused because of Pimcore\Logger usage of some Methods like `Pimcore\Config::getSystemConfig()` An Example ExceptionTrace (Working dir is replaced with `./`) ```` #0 ./pimcore/lib/Pimcore/Logger.php(29): Symfony\Component\DependencyInjection\Container->get('monolog.logger....') #1 ./pimcore/lib/Pimcore/Logger.php(44): Pimcore\Logger::log('Cannot find sys...', 'emergency', Array) pimcore#2 ./pimcore/lib/Pimcore/Config.php(114): Pimcore\Logger::emergency('Cannot find sys...') pimcore#3 ./pimcore/lib/Pimcore/Tool/Console.php(80): Pimcore\Config::getSystemConfig() pimcore#4 ./pimcore/lib/Pimcore/Tool/Console.php(233): Pimcore\Tool\Console::getExecutable('php', true) pimcore#5 ./pimcore/lib/Pimcore/Tool/Requirements.php(328): Pimcore\Tool\Console::getPhpCli() pimcore#6 ./pimcore/lib/Pimcore/Bundle/InstallBundle/Controller/InstallController.php(88): Pimcore\Tool\Requirements::checkExternalApplications() pimcore#7 ./vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php(151): Pimcore\Bundle\InstallBundle\Controller\InstallController->checkAction(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Install\Installer)) pimcore#8 ./vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) pimcore#9 ./vendor/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php(202): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) pimcore#10./web/install.php(72): Symfony\Component\HttpKernel\Kernel->handle(Object(Symfony\Component\HttpFoundation\Request)) pimcore#11 {main} ```` best regards

Example error message: Warning: Undefined array key "localizedfields" Es ist eine Ausnahme aufgetreten - der Vorgang konnte nicht durchgeführt werden. Bitte laden Sie die Adminoberfläche neu und versuchen Sie es danach erneut.Timestamp: Wed Nov 09 2022 16:06:23 GMT+0100 (Mitteleuropäische Normalzeit) Status: 500 | Internal Server Error URL: /admin/object-helper/grid-get-column-config Message: Warning: Undefined array key "localizedfields" Trace: in /var/www/html/vendor/pimcore/pimcore/models/DataObject/Service.php:1263 #0 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(257): Pimcore\Model\DataObject\Service::getCustomGridFieldDefinitions('subscription', 49356) pimcore#1 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(225): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->doGetGridColumnConfig(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) pimcore#2 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(153): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->gridGetColumnConfigAction(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) pimcore#3 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(75): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) pimcore#4 /var/www/html/vendor/symfony/http-kernel/Kernel.php(202): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) pimcore#5 /var/www/html/public/index.php(40): Symfony\Component\HttpKernel\Kernel->handle(Object(Symfony\Component\HttpFoundation\Request)) pimcore#6 {main}

Example error message: Warning: Undefined array key "localizedfields" Es ist eine Ausnahme aufgetreten - der Vorgang konnte nicht durchgeführt werden. Bitte laden Sie die Adminoberfläche neu und versuchen Sie es danach erneut.Timestamp: Wed Nov 09 2022 16:06:23 GMT+0100 (Mitteleuropäische Normalzeit) Status: 500 | Internal Server Error URL: /admin/object-helper/grid-get-column-config Message: Warning: Undefined array key "localizedfields" Trace: in /var/www/html/vendor/pimcore/pimcore/models/DataObject/Service.php:1263 #0 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(257): Pimcore\Model\DataObject\Service::getCustomGridFieldDefinitions('subscription', 49356) #1 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(225): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->doGetGridColumnConfig(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) #2 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(153): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->gridGetColumnConfigAction(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) #3 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(75): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #4 /var/www/html/vendor/symfony/http-kernel/Kernel.php(202): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #5 /var/www/html/public/index.php(40): Symfony\Component\HttpKernel\Kernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #6 {main}

10.5

…tring - resolves #15821

…tring (#15853) undefined

Workflows update

Can not filter checkbox values in Grid. Fatal Error File - vendor/doctrine/dbal/src/Connection.php Line - 568 Trace - Doctrine\DBAL\Connection::quote(): Argument pimcore#1 ($value) must be of type string, int given, called in vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php on line 174 Trace - #0 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(174): Doctrine\DBAL\Connection->quote() pimcore#1 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(158): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterConditionExt() pimcore#2 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(366): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterCondition() pimcore#3 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(667): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->getFilterCondition() pimcore#4 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectActionsTrait.php(102): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->prepareListingForGrid() pimcore#5 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectController.php(1693): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxy() pimcore#6 vendor/symfony/http-kernel/HttpKernel.php(181): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxyAction() pimcore#7 vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw() pimcore#8 vendor/symfony/http-kernel/Kernel.php(197): Symfony\Component\HttpKernel\HttpKernel->handle() pimcore#9 vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php(35): Symfony\Component\HttpKernel\Kernel->handle() pimcore#10 vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run() pimcore#11 public/index.php(19): require_once('...') pimcore#12 {main}

Can not filter checkbox values in Grid. Fatal Error File - vendor/doctrine/dbal/src/Connection.php Line - 568 Trace - Doctrine\DBAL\Connection::quote(): Argument #1 ($value) must be of type string, int given, called in vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php on line 174 Trace - #0 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(174): Doctrine\DBAL\Connection->quote() #1 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(158): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterConditionExt() #2 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(366): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterCondition() #3 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(667): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->getFilterCondition() #4 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectActionsTrait.php(102): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->prepareListingForGrid() #5 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectController.php(1693): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxy() #6 vendor/symfony/http-kernel/HttpKernel.php(181): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxyAction() #7 vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw() #8 vendor/symfony/http-kernel/Kernel.php(197): Symfony\Component\HttpKernel\HttpKernel->handle() #9 vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php(35): Symfony\Component\HttpKernel\Kernel->handle() #10 vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run() #11 public/index.php(19): require_once('...') #12 {main}

Extension of javascript abstract plugin class.

acf9c10

Allows to easily integrate custom plugin menu item(s) with admin toolbar. Menu is automaticaly included if plugin class implements getMenu() abstract method.

brusch closed this Aug 19, 2013

Hagith added a commit to Hagith/pimcore-boilerplate that referenced this pull request Apr 23, 2014

plugins menu

8e6bf8a

see pull request: pimcore#4

Hagith added a commit to Hagith/pimcore-boilerplate that referenced this pull request Apr 23, 2014

plugins menu

ecc1fd6

see pull request: pimcore#4

brusch mentioned this pull request Jul 17, 2015

Object bricks error while filter an export in object grid #190

Closed

kardasz mentioned this pull request Mar 23, 2016

Pimcore completely broken after upgrade to 4.0.0 RC1 #506

Closed

weisswurstkanone mentioned this pull request May 25, 2016

Custom views do not update #512

Closed

Yivan mentioned this pull request Aug 2, 2016

Bug: Export custom reports doesn't work #782

Closed

brusch pushed a commit that referenced this pull request Nov 14, 2016

Revert "Notifications" (#4)

aa2614f

LosHawlos mentioned this pull request Feb 27, 2017

[Documents] UTF-8 support for keys and pretty-urls #1317

Closed

drietsch mentioned this pull request Apr 4, 2017

Geopoint within block data component #1387

Closed

KailaJayapalreddy mentioned this pull request Sep 8, 2017

[Pimcore 5] Search and Replace Assignments functionality is not working with Multi-Href with metadata #1930

Closed

1 task

elwininc mentioned this pull request Dec 26, 2017

Pimcore-stable.zip install problem #2386

Closed

elwininc mentioned this pull request Jan 4, 2018

CSV import error #2408

Closed

RoKoh mentioned this pull request Jan 17, 2018

Exception during FullPageCache for BinaryFileResponse #2460

Closed

Cruiser13 mentioned this pull request Feb 7, 2018

Cannot update to 5.1.3 #2559

Closed

incoxx mentioned this pull request Feb 9, 2018

PIMCORE Update to 5.1 to 5.1.3 failed #2580

Closed

omeryuce mentioned this pull request Feb 13, 2018

The file is giving a PDO error during upload #2587

Closed

cadeyrn mentioned this pull request May 29, 2018

Pimcore 5.2.3 broke assets upload / thumbnail generation #2881

Closed

alphaDev23 mentioned this pull request May 21, 2019

Upgrade to 4.6.x results in Internal Server Error #4415

Closed

MercuryKojo mentioned this pull request May 27, 2019

Pimcore 6 Many-To-One Relation with Lazy-Loading in Fieldcollection is not working #4446

Closed

Digital-Media-Team mentioned this pull request Oct 1, 2019

Syntax error or access violation: 1305 FUNCTION pimcore_ecomm.PLUGIN_CMF_COLLECT_DOCUMENT_SEGMENT_ASSIGNMENTS does not exist #5032

Closed

ultramegatom mentioned this pull request Nov 11, 2022

Fix warning undefined array key #13562

Merged

salmanshafiq8630 mentioned this pull request Dec 7, 2022

[Bug]: Pimcore - Page not found. 500 (Internal Server Error) #13758

Closed

Cruiser13 mentioned this pull request Dec 15, 2022

[Bug]: cannot publish documents that where created with pimcore 6.9 #11801

Closed

svenkovhd mentioned this pull request Jan 16, 2023

[Bug]: Saving of select value in Block > Field Collection > Block produce 500 | Internal Server Error #14072

Closed

This was referenced Feb 27, 2023

[Bug]: Classification Store type error #14459

Closed

[Bug]: Save of custom layout doesn't work #14527

Closed

bitbirddev pushed a commit to bitbirddev/pimcore that referenced this pull request Mar 7, 2023

Merge pull request pimcore#4 from pimcore/10.5

c0a8fc1

10.5

felixflor-twocream mentioned this pull request Apr 24, 2023

force process timeout to type integer in Composer Class #15012

Merged

ascheider mentioned this pull request May 17, 2023

[Bug]: Upload of new Excel File Version leads to wrong assets customSettings and big logs #15221

Open

abdelrhmanyosry mentioned this pull request Aug 11, 2023

[Bug]: #15739

Closed

dvesh3 added a commit that referenced this pull request Aug 30, 2023

Fix ObjectMetadata::save(): Argument #4 ($position) must be of type s…

e5c03e2

…tring - resolves #15821

aryaantony92 pushed a commit that referenced this pull request Aug 30, 2023

Fix ObjectMetadata::save(): Argument #4 ($position) must be of type s…

2e94c3c

…tring (#15853) undefined

abhiramalli mentioned this pull request Oct 1, 2023

[Bug]: saving class with multiple object brick #16035

Closed

martinkaucic mentioned this pull request Dec 11, 2023

[Bug]: DataObject OptionsProvider with dynamic options throws exception #16355

Closed

pimcore-deployments pushed a commit that referenced this pull request Dec 18, 2023

Merge pull request #4 from pimcore/workflows_update

dbe36cb

Workflows update

shades3002 mentioned this pull request Dec 18, 2023

[Asset] Video preview not working when storing assets in remote stream #5007

Closed

Thejaswini-Rao-U mentioned this pull request Jan 2, 2024

After updating from 10.6 pimcore v to 11 version, facing version count issue #16404

Closed

muratbinerbay mentioned this pull request Jan 23, 2024

[Bug]: Relation fields with PathFormatters cannot be opened in panel in grid mode #16500

Closed

sevarozh mentioned this pull request Feb 28, 2024

[Bug]: Thumbnails generation with frame=true throw exception, if GD image adapter in use #16693

Closed

gutentag2012 mentioned this pull request Jun 3, 2024

[Bug]: Dynamic Text Block breaks Grid options #17118

Open

zhikai-aiken mentioned this pull request Jan 3, 2025

[Bug]: Object class: Adding a new object class throws error 500 #17954

Open

christophbrejla mentioned this pull request Jan 28, 2025

[Bug]: SQLERROR Table 'cache_items' already exists upon pimcore install #18032

Open

dturopoli mentioned this pull request May 13, 2025

[Bug]: SimpleBackendSearch issue with localized fields in bricks #18417

Closed

roynilsson mentioned this pull request Jul 24, 2025

[Bug]: Application logger error in admin #18567

Closed

djbodya mentioned this pull request Aug 23, 2025

[Bug]: Fix Checkbox quote string issue #18640

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Extension of javascript abstract plugin class. #4

Extension of javascript abstract plugin class. #4

Uh oh!

Hagith commented Dec 17, 2011

Uh oh!

timglabisch commented Jan 4, 2012

Uh oh!

timglabisch commented Jan 4, 2012

Uh oh!

Hagith commented Jan 5, 2012

Uh oh!

timglabisch commented Jan 5, 2012

Uh oh!

timglabisch commented Jan 8, 2012

Uh oh!

Hagith commented May 23, 2013

Uh oh!

brusch commented Aug 19, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Extension of javascript abstract plugin class. #4

Extension of javascript abstract plugin class. #4

Uh oh!

Conversation

Hagith commented Dec 17, 2011

Uh oh!

timglabisch commented Jan 4, 2012

Uh oh!

timglabisch commented Jan 4, 2012

Uh oh!

Hagith commented Jan 5, 2012

Uh oh!

timglabisch commented Jan 5, 2012

Uh oh!

timglabisch commented Jan 8, 2012

Uh oh!

Hagith commented May 23, 2013

Uh oh!

brusch commented Aug 19, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants