escape columns in inheritance helper #17174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
|
|
Hello @AlternateIf , Line 113 in 22b2ae4 Should have the same affect, right? And would help to reduce duplicated code. |
|
@mcop1 changed it to use the helper function |
|
LGTM - thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of having a reserved keyword as field on an objectbrick (e.g "use") the inheritance helper fails to update a child that does not have a brick that is set on the parent.
since this helper is called upon save of an object, this leads to the obect save throwing an exception in the backend. the dbal insert function states:
"Table expression and columns are not escaped and are not safe for user-input."%
the same might also apply for localized fields.