Thanks to visit codestin.com
Credit goes to github.com

Skip to content

escape columns in inheritance helper #17174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2024
Merged

escape columns in inheritance helper #17174

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
050a292
escape columns in inheritance helper
AlternateIf Jun 13, 2024
f10793b
escape table in inheritance helper
AlternateIf Jun 13, 2024
d5ff149
use quoteIdentifier
AlternateIf Jul 1, 2024
4b5b9ee
Merge remote-tracking branch 'origin/11.2' into patch-29
markus-moser Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions models/DataObject/Concrete/Dao/InheritanceHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
namespace Pimcore\Model\DataObject\Concrete\Dao;

use Doctrine\DBAL\Connection;
use Pimcore\Db\Helper;
use Pimcore\Model\DataObject;

/**
Expand Down Expand Up @@ -233,10 +234,11 @@ public function doUpdate(int $oo_id, bool $createMissingChildrenRows = false, ar
$missingIds = $this->db->fetchFirstColumn($query);

// create entries for children that don't have an entry yet
$originalEntry = $this->db->fetchAssociative('SELECT * FROM ' . $this->querytable . ' WHERE ' . $this->idField . ' = ?', [$oo_id]);
$originalEntry = Helper::quoteDataIdentifiers($this->db, $this->db->fetchAssociative('SELECT * FROM ' . $this->querytable . ' WHERE ' . $this->idField . ' = ?', [$oo_id]));

foreach ($missingIds as $id) {
$originalEntry[$this->idField] = $id;
$this->db->insert($this->querytable, $originalEntry);
$originalEntry[$this->db->quoteIdentifier($this->idField)] = $id;
$this->db->insert($this->db->quoteIdentifier($this->querytable), $originalEntry);
}
}
}
Expand Down